Attachment 132926 Details for Bug 27123 – Bug 27123: Delete useless code

[patch] Bug 27123: Delete useless code

Bug-27123-Delete-useless-code.patch (text/plain), 3.13 KB, created by Jérémy Breuillard on 2022-04-04 10:16:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jérémy Breuillard

Created: 2022-04-04 10:16:54 UTC

Size: 3.13 KB

patch

obsolete

>From 13533156e1752bd16ab70cb67ca3e1c833c03495 Mon Sep 17 00:00:00 2001
>From: jeremy breuillard <jeremy.breuillard@biblibre.com>
>Date: Mon, 4 Apr 2022 12:04:27 +0200
>Subject: [PATCH] Bug 27123: Delete useless code
>
>---
> .../prog/en/modules/tools/modborrowers.tt     |  3 ++
> tools/modborrowers.pl                         | 35 +++++++------------
> 2 files changed, 16 insertions(+), 22 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>index db8cd4610f..b1ac074827 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>@@ -33,6 +33,8 @@
>     <div class="row">
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
>+                            [% USE Dumper %] [% Dumper.dump(message, message_type) %]
>+
> 
>                 [% IF ( op == 'show_form' ) %]
>                 <h1>Batch patron modification</h1>
>@@ -426,6 +428,7 @@
>             </aside>
>         </div> 
>      </div> 
>+                [% USE Dumper %] [% Dumper.dump(message, message_type) %]
> 
> [% MACRO jsinclude BLOCK %]
>     [% INCLUDE 'calendar.inc' %]
>diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
>index 1cf8cc4cc8..c8908fc508 100755
>--- a/tools/modborrowers.pl
>+++ b/tools/modborrowers.pl
>@@ -439,31 +439,22 @@ if ( $op eq 'do' ) {
>             }
>             $i++;
>         }
>-        # Create a block to save in database the patron_messages update + security slice : "if" this field is filled-up then...etc
>-        my $patron_messages = Koha::Patron::Messages->search(
>+
>+        # Handle patron messages
>+        my $message          = $input->param('message');
>+        my $branchcode       = C4::Context::mybranch;
>+        my $message_type     = $input->param('add_message_type');
>+
>+        Koha::Patron::Message->new(
>             {
>-                'me.borrowernumber' => $patron->borrowernumber,
>-            }
>-        );
>-        if ( defined $patron_messages ) {
>-            if ( defined $infos ) {
>-                my $message          = $input->param('message');
>-                my $borrowernumber   = $patron->borrowernumber;
>-                my $branchcode       = C4::Context::mybranch;
>-                my $message_type     = $input->param('add_message_type');
>-
>-                Koha::Patron::Message->new(
>-                    {
>-                        borrowernumber => $borrowernumber,
>-                        branchcode     => $branchcode,
>-                        message_type   => $message_type,
>-                        message        => $message,
>-                    }
>-                )->store;
>-                $template->param( message_type => $message_type );
>+                borrowernumber => $borrowernumber,
>+                branchcode     => $branchcode,
>+                message_type   => $message_type,
>+                message        => $message,
>             }
>-        }
>+        )->store;
>     }
>+
>     $op = "show_results"; # We have process modifications, the user want to view its
> 
>     # Construct the results list
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 27123: 131015 | 131042 | 132923 | 132924 | 132925 | 132926 | 132927 | 134065 | 172012 | 172013 | 172053 | 172086 | 172087 | 172120 | 172121 | 172122