Bug 27123 - Add messages to batch patrons modification
Summary: Add messages to batch patrons modification
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Jérémy Breuillard
QA Contact: Kyle M Hall (khall)
URL:
Keywords: Manual, release-notes-needed
Depends on:
Blocks:
 
Reported: 2020-12-01 09:32 UTC by Séverine Queune
Modified: 2024-10-09 20:18 UTC (History)
15 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 27123: Add messages to batch patrons modification (9.44 KB, patch)
2022-02-22 14:38 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.46 KB, patch)
2022-02-23 15:12 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.49 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Add filter + translate comment (2.08 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: whitespaces deleted (2.03 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Delete useless code (3.13 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Remove Dumpers (1.12 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.33 KB, patch)
2022-04-27 12:20 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.49 KB, patch)
2024-09-26 18:39 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.49 KB, patch)
2024-09-26 18:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27123: (follow-up) Add note to warn about removing all messages (1.85 KB, patch)
2024-09-26 19:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.54 KB, patch)
2024-09-27 01:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 27123: (follow-up) Add note to warn about removing all messages (1.90 KB, patch)
2024-09-27 01:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.56 KB, patch)
2024-09-27 15:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 27123: (follow-up) Add note to warn about removing all messages (1.92 KB, patch)
2024-09-27 15:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 27123: (QA follow-up) Tidy modborrowers.pl (25.25 KB, patch)
2024-09-27 15:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Séverine Queune 2020-12-01 09:32:21 UTC
It could be useful if using the batch patrons modification form, we could add new circulation messages for all selected patrons.
Comment 1 Jérémy Breuillard 2022-02-22 14:38:38 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2022-02-23 15:12:52 UTC
Created attachment 131042 [details] [review]
Bug 27123: Add messages to batch patrons modification

With this patch you can write or delete circulation messages on the batch patrons modification form

Test plan:
1)Go to Home > Tools > Batch patron modification
2)Write one or more card numbers to access the modification form
3)Notice the input you can interact with
4)Apply patch and repeat 1) & 2)
5)Notice the new input 'Message:' which appeared down the form
6)Write a message and choose a type (opac or intranet)
7)Save & notice the new 'Message' column filled up with what you wrote before
8)To delete: back on the modification form - check the checkbox beside the input - save again

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Katrin Fischer 2022-02-26 19:57:34 UTC
Hi Jeremy,

0) Please assign yourself the bugs you plan to work on :)

1) QA test tools

A good habit to start is to always run the QA test tools against your patches before submitting, so simple stuff doesn't get your patches sent back:

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
   FAIL	  filters
		missing_filter at line 265 (                                                            [% patron_message.message %] <br>)

 FAIL	tools/modborrowers.pl
   FAIL	  spelling
		 bloc ==> block

For adding the filter, this might be helpful in the future: misc/devel/add_missing_filters.pl

2) Code comments in English please :)

+        # Créer un bloc pour enregistrer en bdd l'update de la table patron_messages + sécurité : 'si' tel champ est remplit alors.... etc

Can you please provide a follow-up and switch back to signed off?
Comment 4 Jérémy Breuillard 2022-04-04 10:16:41 UTC Comment hidden (obsolete)
Comment 5 Jérémy Breuillard 2022-04-04 10:16:45 UTC Comment hidden (obsolete)
Comment 6 Jérémy Breuillard 2022-04-04 10:16:50 UTC Comment hidden (obsolete)
Comment 7 Jérémy Breuillard 2022-04-04 10:16:54 UTC Comment hidden (obsolete)
Comment 8 Jérémy Breuillard 2022-04-04 10:16:58 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2022-04-25 10:18:25 UTC
I am sorry, Jérémy, this no longer applies. I fixed the first conflict, but got stuck on the second:

Applying: Bug 27123: Add messages to batch patrons modification
Applying: Bug 27123: whitespaces deleted
Applying: Bug 27123: Delete useless code
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 27123: Delete useless code
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-27123-Delete-useless-code-g_KXIH.patch

Can you please rebase?
Comment 10 Jérémy Breuillard 2022-04-26 14:59:31 UTC
Thanks Katrin for this, I fix it asap :)
Comment 11 Jérémy Breuillard 2022-04-27 12:20:07 UTC Comment hidden (obsolete)
Comment 12 Katrin Fischer 2022-04-27 12:49:05 UTC
Hi Jérémy, is this ready for testing again? The sequence of patches doesn't appear to be right - or maybe some need to be obsoleted if you squashed?
Comment 13 George Williams (NEKLS) 2024-09-26 18:08:15 UTC
This would be a great addition to the patron batch modification tool.
Comment 14 Owen Leonard 2024-09-26 18:20:19 UTC
I notice that if you check the checkbox next to the message field ("Checking the box right next to the label will disable the entry and delete the values of that field on all selected patrons") it will delete *all* messages on that patron's account. I don't know if that was intentional? I can see it as being useful but also dangerous. At the very least we should add a hint about this behavior.
Comment 15 PTFS Europe Sandboxes 2024-09-26 18:39:08 UTC Comment hidden (obsolete)
Comment 16 Owen Leonard 2024-09-26 18:42:31 UTC
Created attachment 172013 [details] [review]
Bug 27123: Add messages to batch patrons modification

With this patch you can write or delete circulation messages on the
batch patrons modification form

Test plan:
1)Go to Home > Tools > Batch patron modification
2)Write one or more card numbers to access the modification form
3)Notice the input you can interact with
4)Apply patch and repeat 1) & 2)
5)Notice the new input 'Message:' which appeared down the form
6)Write a message and choose a type (opac or intranet)
7)Save & notice the new 'Message' column filled up with what you wrote
  before
8)To delete: back on the modification form - check the checkbox beside
  the input - save again

Signed-off-by: Valerie Burnett <valerie@bywatersolutions.com>
Comment 17 Owen Leonard 2024-09-26 19:44:14 UTC
Created attachment 172053 [details] [review]
Bug 27123: (follow-up) Add note to warn about removing all messages

This patch adds a note to the batch patron modification form in order to
warn the user about removing multiple messages at once.

To test:

- Apply the patch and go to Tools -> Batch patron modification
- Enter or select multiple patrons and submit them for modification
- On the page previewing the list patrons for modification, scroll down
  to the form.
- Find the field for "Message" and confirm that there is a note next to
  the checkbox.
Comment 18 ByWater Sandboxes 2024-09-27 01:01:42 UTC
Created attachment 172086 [details] [review]
Bug 27123: Add messages to batch patrons modification

With this patch you can write or delete circulation messages on the
batch patrons modification form

Test plan:
1)Go to Home > Tools > Batch patron modification
2)Write one or more card numbers to access the modification form
3)Notice the input you can interact with
4)Apply patch and repeat 1) & 2)
5)Notice the new input 'Message:' which appeared down the form
6)Write a message and choose a type (opac or intranet)
7)Save & notice the new 'Message' column filled up with what you wrote
  before
8)To delete: back on the modification form - check the checkbox beside
  the input - save again

Signed-off-by: Valerie Burnett <valerie@bywatersolutions.com>
Signed-off-by: George Williams <george@nekls.org>
Comment 19 ByWater Sandboxes 2024-09-27 01:01:45 UTC
Created attachment 172087 [details] [review]
Bug 27123: (follow-up) Add note to warn about removing all messages

This patch adds a note to the batch patron modification form in order to
warn the user about removing multiple messages at once.

To test:

- Apply the patch and go to Tools -> Batch patron modification
- Enter or select multiple patrons and submit them for modification
- On the page previewing the list patrons for modification, scroll down
  to the form.
- Find the field for "Message" and confirm that there is a note next to
  the checkbox.

Signed-off-by: George Williams <george@nekls.org>
Comment 20 George Williams (NEKLS) 2024-09-27 01:02:38 UTC
Signed off a second time with followups - work per test plan
Comment 21 Kyle M Hall (khall) 2024-09-27 15:08:12 UTC
Created attachment 172120 [details] [review]
Bug 27123: Add messages to batch patrons modification

With this patch you can write or delete circulation messages on the
batch patrons modification form

Test plan:
1)Go to Home > Tools > Batch patron modification
2)Write one or more card numbers to access the modification form
3)Notice the input you can interact with
4)Apply patch and repeat 1) & 2)
5)Notice the new input 'Message:' which appeared down the form
6)Write a message and choose a type (opac or intranet)
7)Save & notice the new 'Message' column filled up with what you wrote
  before
8)To delete: back on the modification form - check the checkbox beside
  the input - save again

Signed-off-by: Valerie Burnett <valerie@bywatersolutions.com>
Signed-off-by: George Williams <george@nekls.org>
Comment 22 Kyle M Hall (khall) 2024-09-27 15:08:19 UTC
Created attachment 172121 [details] [review]
Bug 27123: (follow-up) Add note to warn about removing all messages

This patch adds a note to the batch patron modification form in order to
warn the user about removing multiple messages at once.

To test:

- Apply the patch and go to Tools -> Batch patron modification
- Enter or select multiple patrons and submit them for modification
- On the page previewing the list patrons for modification, scroll down
  to the form.
- Find the field for "Message" and confirm that there is a note next to
  the checkbox.

Signed-off-by: George Williams <george@nekls.org>
Comment 23 Kyle M Hall (khall) 2024-09-27 15:08:22 UTC
Created attachment 172122 [details] [review]
Bug 27123: (QA follow-up) Tidy modborrowers.pl