It could be useful if using the batch patrons modification form, we could add new circulation messages for all selected patrons.
Created attachment 131015 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again
Created attachment 131042 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Hi Jeremy, 0) Please assign yourself the bugs you plan to work on :) 1) QA test tools A good habit to start is to always run the QA test tools against your patches before submitting, so simple stuff doesn't get your patches sent back: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt FAIL filters missing_filter at line 265 ( [% patron_message.message %] <br>) FAIL tools/modborrowers.pl FAIL spelling bloc ==> block For adding the filter, this might be helpful in the future: misc/devel/add_missing_filters.pl 2) Code comments in English please :) + # Créer un bloc pour enregistrer en bdd l'update de la table patron_messages + sécurité : 'si' tel champ est remplit alors.... etc Can you please provide a follow-up and switch back to signed off?
Created attachment 132923 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again
Created attachment 132924 [details] [review] Bug 27123: Add filter + translate comment
Created attachment 132925 [details] [review] Bug 27123: whitespaces deleted
Created attachment 132926 [details] [review] Bug 27123: Delete useless code
Created attachment 132927 [details] [review] Bug 27123: Remove Dumpers
I am sorry, Jérémy, this no longer applies. I fixed the first conflict, but got stuck on the second: Applying: Bug 27123: Add messages to batch patrons modification Applying: Bug 27123: whitespaces deleted Applying: Bug 27123: Delete useless code error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt). error: could not build fake ancestor Patch failed at 0001 Bug 27123: Delete useless code hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-27123-Delete-useless-code-g_KXIH.patch Can you please rebase?
Thanks Katrin for this, I fix it asap :)
Created attachment 134065 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again
Hi Jérémy, is this ready for testing again? The sequence of patches doesn't appear to be right - or maybe some need to be obsoleted if you squashed?