Bug 27123 - Add messages to batch patrons modification
Summary: Add messages to batch patrons modification
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jérémy Breuillard
QA Contact: Testopia
URL:
Keywords: Manual, release-notes-needed
Depends on:
Blocks:
 
Reported: 2020-12-01 09:32 UTC by Séverine Queune
Modified: 2024-04-03 18:24 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27123: Add messages to batch patrons modification (9.44 KB, patch)
2022-02-22 14:38 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.46 KB, patch)
2022-02-23 15:12 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.49 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Add filter + translate comment (2.08 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: whitespaces deleted (2.03 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Delete useless code (3.13 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Remove Dumpers (1.12 KB, patch)
2022-04-04 10:16 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 27123: Add messages to batch patrons modification (9.33 KB, patch)
2022-04-27 12:20 UTC, Jérémy Breuillard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Séverine Queune 2020-12-01 09:32:21 UTC
It could be useful if using the batch patrons modification form, we could add new circulation messages for all selected patrons.
Comment 1 Jérémy Breuillard 2022-02-22 14:38:38 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2022-02-23 15:12:52 UTC
Created attachment 131042 [details] [review]
Bug 27123: Add messages to batch patrons modification

With this patch you can write or delete circulation messages on the batch patrons modification form

Test plan:
1)Go to Home > Tools > Batch patron modification
2)Write one or more card numbers to access the modification form
3)Notice the input you can interact with
4)Apply patch and repeat 1) & 2)
5)Notice the new input 'Message:' which appeared down the form
6)Write a message and choose a type (opac or intranet)
7)Save & notice the new 'Message' column filled up with what you wrote before
8)To delete: back on the modification form - check the checkbox beside the input - save again

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Katrin Fischer 2022-02-26 19:57:34 UTC
Hi Jeremy,

0) Please assign yourself the bugs you plan to work on :)

1) QA test tools

A good habit to start is to always run the QA test tools against your patches before submitting, so simple stuff doesn't get your patches sent back:

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
   FAIL	  filters
		missing_filter at line 265 (                                                            [% patron_message.message %] <br>)

 FAIL	tools/modborrowers.pl
   FAIL	  spelling
		 bloc ==> block

For adding the filter, this might be helpful in the future: misc/devel/add_missing_filters.pl

2) Code comments in English please :)

+        # Créer un bloc pour enregistrer en bdd l'update de la table patron_messages + sécurité : 'si' tel champ est remplit alors.... etc

Can you please provide a follow-up and switch back to signed off?
Comment 4 Jérémy Breuillard 2022-04-04 10:16:41 UTC Comment hidden (obsolete)
Comment 5 Jérémy Breuillard 2022-04-04 10:16:45 UTC Comment hidden (obsolete)
Comment 6 Jérémy Breuillard 2022-04-04 10:16:50 UTC Comment hidden (obsolete)
Comment 7 Jérémy Breuillard 2022-04-04 10:16:54 UTC Comment hidden (obsolete)
Comment 8 Jérémy Breuillard 2022-04-04 10:16:58 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2022-04-25 10:18:25 UTC
I am sorry, Jérémy, this no longer applies. I fixed the first conflict, but got stuck on the second:

Applying: Bug 27123: Add messages to batch patrons modification
Applying: Bug 27123: whitespaces deleted
Applying: Bug 27123: Delete useless code
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 27123: Delete useless code
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-27123-Delete-useless-code-g_KXIH.patch

Can you please rebase?
Comment 10 Jérémy Breuillard 2022-04-26 14:59:31 UTC
Thanks Katrin for this, I fix it asap :)
Comment 11 Jérémy Breuillard 2022-04-27 12:20:07 UTC
Created attachment 134065 [details] [review]
Bug 27123: Add messages to batch patrons modification

With this patch you can write or delete circulation messages on the batch patrons modification form

Test plan:
1)Go to Home > Tools > Batch patron modification
2)Write one or more card numbers to access the modification form
3)Notice the input you can interact with
4)Apply patch and repeat 1) & 2)
5)Notice the new input 'Message:' which appeared down the form
6)Write a message and choose a type (opac or intranet)
7)Save & notice the new 'Message' column filled up with what you wrote before
8)To delete: back on the modification form - check the checkbox beside the input - save again
Comment 12 Katrin Fischer 2022-04-27 12:49:05 UTC
Hi Jérémy, is this ready for testing again? The sequence of patches doesn't appear to be right - or maybe some need to be obsoleted if you squashed?