Bugzilla – Attachment 133211 Details for
Bug 30512
Staff interface search results template error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30512: Staff interface search results template error
Bug-30512-Staff-interface-search-results-template-.patch (text/plain), 4.71 KB, created by
Owen Leonard
on 2022-04-12 12:07:17 UTC
(
hide
)
Description:
Bug 30512: Staff interface search results template error
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-04-12 12:07:17 UTC
Size:
4.71 KB
patch
obsolete
>From c58671e9410dd6090ddde682e84b4d375dbd24f9 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 12 Apr 2022 11:56:43 +0000 >Subject: [PATCH] Bug 30512: Staff interface search results template error > >This patch removes some markup from the search results template which >was causing markup to be output on the screen. Rather than correct the >markup so that the "p1" class is correctly added to the relevant links >I'm removing it. The "p1" class isn't used anywhere. > >The patch also corrects two incorrect template filters on one of the >page's links. > >To test, apply the patch and enable the following system preferences: > >- AmazonCoverImages >- IntranetCoce (if available) >- LocalCoverImages > >- Perform a catalog search in the staff interface which will return > results with cover images from each of the enabled services. >- The covers should show correctly in the search results with no markup > being output on screen. >--- > .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index d404da064d..369bbf6488 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -434,7 +434,7 @@ > <div id="cover-slides-[% SEARCH_RESULT.biblionumber | html %]" class="cover-slides" data-biblionumber="[% SEARCH_RESULT.biblionumber | html %]"> > [% IF ( LocalCoverImages ) %][% SEARCH_RESULT.localimage | html %] > <div id="local-coverimg-[% SEARCH_RESULT.biblionumber | html %]" class="cover-image local-coverimg"> >- <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]" class => 'p1'> >+ <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]"> > <img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&biblionumber=[% SEARCH_RESULT.biblionumber | uri %]" alt="Local cover image" /> > </a> > <div class="hint">Local cover image</div> >@@ -443,7 +443,7 @@ > > [% IF ( AmazonCoverImages && SEARCH_RESULT.normalized_isbn ) %] > <div id="amazon-bookcoverimg-[% SEARCH_RESULT.biblionumber | html %]" class="cover-image amazon-bookcoverimg"> >- <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]" class => 'p1'> >+ <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]"> > <img src="https://images-na.ssl-images-amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn | html %].01.TZZZZZZZ.jpg" alt="Cover image from Amazon.com" /> > </a> > <div class="hint">Amazon cover image</div> >@@ -453,7 +453,7 @@ > [% IF ( SyndeticsCovers ) %] > [% IF ( SEARCH_RESULT.normalized_isbn || SEARCH_RESULT.normalized_upc || SEARCH_RESULT.normalized_oclc ) %] > <div id="syndetics-bookcoverimg-[% SEARCH_RESULT.biblionumber | html %]" class="cover-image syndetics-bookcoverimg"> >- <a class="p1" href="/cgi-bin/koha/catalogue/[% DetailPage | html %]?biblionumber=[% SEARCH_RESULT.biblionumber |url %]"> >+ <a href="/cgi-bin/koha/catalogue/[% DetailPage | url %]?biblionumber=[% SEARCH_RESULT.biblionumber | uri %]"> > <img src="https://secure.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn | html %]/SC.GIF&client=[% Koha.Preference('SyndeticsClientCode') | html %]&type=xw10&upc=[% SEARCH_RESULT.normalized_upc | html %]&oclc=[% SEARCH_RESULT.normalized_oclc | html %]" alt="Cover from Syndetics" /> > </a> > <div class="hint">Syndetics cover image</div> >@@ -465,7 +465,7 @@ > [% coce_id = SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn %] > [% IF ( coce_id ) %] > <div id="coce-coverimg-[% SEARCH_RESULT.biblionumber | html %]" class="cover-image coce-coverimg"> >- <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]" class => 'p1'> >+ <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]"> > <span style="block" title="[% SEARCH_RESULT.biblionumber | url %]" class="[% coce_id | html %]" id="coce-thumbnail[% SEARCH_RESULT.biblionumber | html %]"></span> > </a> > <div class="hint">Coce cover image</div> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30512
:
133210
|
133211
|
133571