Bug 29609 made a change to results.tt which result in broken markup: <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]" class => 'p1'> biblio_a_href doesn't accept a "class" property. The problem will only appear if you have IntranetCoce, AmazonCoverImages, or LocalCoverImages enabled.
Created attachment 133210 [details] Screenshot showing the problem
Created attachment 133211 [details] [review] Bug 30512: Staff interface search results template error This patch removes some markup from the search results template which was causing markup to be output on the screen. Rather than correct the markup so that the "p1" class is correctly added to the relevant links I'm removing it. The "p1" class isn't used anywhere. The patch also corrects two incorrect template filters on one of the page's links. To test, apply the patch and enable the following system preferences: - AmazonCoverImages - IntranetCoce (if available) - LocalCoverImages - Perform a catalog search in the staff interface which will return results with cover images from each of the enabled services. - The covers should show correctly in the search results with no markup being output on screen.
Created attachment 133571 [details] [review] Bug 30512: Staff interface search results template error This patch removes some markup from the search results template which was causing markup to be output on the screen. Rather than correct the markup so that the "p1" class is correctly added to the relevant links I'm removing it. The "p1" class isn't used anywhere. The patch also corrects two incorrect template filters on one of the page's links. To test, apply the patch and enable the following system preferences: - AmazonCoverImages - IntranetCoce (if available) - LocalCoverImages - Perform a catalog search in the staff interface which will return results with cover images from each of the enabled services. - The covers should show correctly in the search results with no markup being output on screen. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Oops, thanks Owen!
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Not applying to 21.11.x, please rebase if you think this should be backported!