Bugzilla – Attachment 133461 Details for
Bug 30446
Add a test for GetTagsLabels
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30446: (follow-up) Remove warning
Bug-30446-follow-up-Remove-warning.patch (text/plain), 1.01 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-04-20 12:19:51 UTC
(
hide
)
Description:
Bug 30446: (follow-up) Remove warning
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-04-20 12:19:51 UTC
Size:
1.01 KB
patch
obsolete
>From 6bb1d23ce718f191a7a2a0c4be83c1d0dfec16de Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 20 Apr 2022 09:17:03 -0300 >Subject: [PATCH] Bug 30446: (follow-up) Remove warning > >This patch removes a trivial warning caused by a parameter being >compared to a literal but not being defined. Doing a > >$ git grep GetTagsLabels > >shows the change is safe as the function is always called with a value >of either 0 or 1. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/AuthoritiesMarc.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index a7915e90562..6245d89ec7d 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -465,7 +465,7 @@ sub GetTagsLabels { > my $dbh=C4::Context->dbh; > $authtypecode="" unless $authtypecode; > my $sth; >- my $libfield = ($forlibrarian == 1)? 'liblibrarian' : 'libopac'; >+ my $libfield = ($forlibrarian) ? 'liblibrarian' : 'libopac'; > > > # check that authority exists >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30446
:
132932
|
133460
| 133461