Attachment 134132 Details for Bug 22785 – Bug 22785: (QA follow-up) Remove superflous spec files

[patch] Bug 22785: (QA follow-up) Remove superflous spec files

Bug-22785-QA-follow-up-Remove-superflous-spec-file.patch (text/plain), 7.08 KB, created by Martin Renvoize (ashimema) on 2022-04-27 16:32:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-04-27 16:32:51 UTC

Size: 7.08 KB

patch

obsolete

>From cbd2bea16aa6d4116a408b50433c752c1553b216 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 27 Apr 2022 17:31:03 +0100
>Subject: [PATCH] Bug 22785: (QA follow-up) Remove superflous spec files
>
>We don't need these any more.. I think they crept back in during
>rebases
>---
> .../definitions/import_record_match.json      |  21 ---
> .../parameters/import_record_match.json       |  16 --
> .../parameters/import_record_match.yaml       |  13 --
> .../swagger/paths/import_record_matches.json  | 144 ------------------
> 4 files changed, 194 deletions(-)
> delete mode 100644 api/v1/swagger/definitions/import_record_match.json
> delete mode 100644 api/v1/swagger/parameters/import_record_match.json
> delete mode 100644 api/v1/swagger/parameters/import_record_match.yaml
> delete mode 100644 api/v1/swagger/paths/import_record_matches.json
>
>diff --git a/api/v1/swagger/definitions/import_record_match.json b/api/v1/swagger/definitions/import_record_match.json
>deleted file mode 100644
>index abde7365b0..0000000000
>--- a/api/v1/swagger/definitions/import_record_match.json
>+++ /dev/null
>@@ -1,21 +0,0 @@
>-{
>-  "type": "object",
>-  "properties": {
>-    "import_record_id": {
>-      "type": "integer",
>-      "description": "Internal import record identifier"
>-    },
>-    "candidate_match_id": {
>-      "type": "integer",
>-      "description": "Internal import record match candidate identifier"
>-    },
>-    "chosen": {
>-      "type": "boolean",
>-      "description": "Whether match has been chosen for overlay"
>-    },
>-    "score": {
>-      "type": "integer",
>-      "description": "Ranking value for this match calculated by the matching rules"
>-    }
>-  }
>-}
>diff --git a/api/v1/swagger/parameters/import_record_match.json b/api/v1/swagger/parameters/import_record_match.json
>deleted file mode 100644
>index 5268c2a2dc..0000000000
>--- a/api/v1/swagger/parameters/import_record_match.json
>+++ /dev/null
>@@ -1,16 +0,0 @@
>-{
>-  "import_record_id_pp": {
>-    "name": "import_record_id",
>-    "in": "path",
>-    "description": "Internal import_record identifier",
>-    "required": true,
>-    "type": "integer"
>-  },
>-  "candidate_match_id_pp": {
>-    "name": "candidate_match_id",
>-    "in": "path",
>-    "description": "Internal import_record_match_candidate identifier",
>-    "required": true,
>-    "type": "integer"
>-  }
>-}
>diff --git a/api/v1/swagger/parameters/import_record_match.yaml b/api/v1/swagger/parameters/import_record_match.yaml
>deleted file mode 100644
>index 376c406bca..0000000000
>--- a/api/v1/swagger/parameters/import_record_match.yaml
>+++ /dev/null
>@@ -1,13 +0,0 @@
>----
>-import_record_id_pp:
>-  name: import_record_id
>-  in: path
>-  description: Internal import_record identifier
>-  required: true
>-  type: integer
>-candidate_match_id_pp:
>-  name: candidate_match_id
>-  in: path
>-  description: Internal import_record_match_candidate identifier
>-  required: true
>-  type: integer
>diff --git a/api/v1/swagger/paths/import_record_matches.json b/api/v1/swagger/paths/import_record_matches.json
>deleted file mode 100644
>index 3c0be19d97..0000000000
>--- a/api/v1/swagger/paths/import_record_matches.json
>+++ /dev/null
>@@ -1,144 +0,0 @@
>-{
>-  "/import/{import_batch_id}/records/{import_record_id}/matches/chosen": {
>-    "put": {
>-      "x-mojo-to": "ImportRecordMatches#set_chosen",
>-      "operationId": "setChosen",
>-      "tags": ["import_record_matches"],
>-      "parameters": [{
>-          "name": "import_batch_id",
>-          "in": "path",
>-          "required": true,
>-          "description": "An import_batch ID",
>-          "type": "integer"
>-      }, {
>-          "name": "import_record_id",
>-          "in": "path",
>-          "required": true,
>-          "description": "An import_record ID",
>-          "type": "integer"
>-      }, {
>-          "name": "body",
>-          "in": "body",
>-          "description": "A JSON object containing fields to modify",
>-          "required": true,
>-          "schema": {
>-            "type": "object",
>-            "properties": {
>-              "candidate_match_id": {
>-                "description": "Candudate match to choose",
>-                "type": "integer"
>-              }
>-            }
>-          }
>-        }
>-      ],
>-      "consumes": ["application/json"],
>-      "produces": ["application/json"],
>-      "responses": {
>-        "200": {
>-          "description": "Match updated"
>-        },
>-        "400": {
>-          "description": "Missing or wrong parameters",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        },
>-        "401": {
>-          "description": "Authentication required",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        },
>-        "403": {
>-          "description": "Match management not allowed",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        },
>-        "404": {
>-          "description": "Import record match not found",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        },
>-        "500": {
>-          "description": "Internal server error",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        },
>-        "503": {
>-          "description": "Under maintenance",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        }
>-      },
>-      "x-koha-authorization": {
>-        "permissions": {
>-          "tools": "manage_staged_marc"
>-        }
>-      }
>-    },
>-    "delete": {
>-      "x-mojo-to": "ImportRecordMatches#unset_chosen",
>-      "operationId": "unsetChosen",
>-      "tags": ["import_record_matches"],
>-      "parameters": [{
>-          "name": "import_batch_id",
>-          "in": "path",
>-          "required": true,
>-          "description": "An import_batch ID",
>-          "type": "integer"
>-      }, {
>-          "name": "import_record_id",
>-          "in": "path",
>-          "required": true,
>-          "description": "An import_record ID",
>-          "type": "integer"
>-      }],
>-      "produces": ["application/json"],
>-      "responses": {
>-        "204": {
>-          "description": "Matches unchosen"
>-        },
>-        "401": {
>-          "description": "Authentication required",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        },
>-        "403": {
>-          "description": "Match management not allowed",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        },
>-        "404": {
>-          "description": "Import record matches not found",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        },
>-        "500": {
>-          "description": "Internal server error",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        },
>-        "503": {
>-          "description": "Under maintenance",
>-          "schema": {
>-            "$ref": "../definitions.json#/error"
>-          }
>-        }
>-      },
>-      "x-koha-authorization": {
>-        "permissions": {
>-          "tools": "manage_staged_marc"
>-        }
>-      }
>-    }
>-  }
>-}
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22785: 114813 | 114814 | 114815 | 114816 | 120995 | 120996 | 120997 | 121149 | 121167 | 121168 | 121169 | 121170 | 121171 | 121172 | 121173 | 121174 | 121204 | 121205 | 121206 | 121207 | 126369 | 126370 | 126371 | 126372 | 126522 | 126523 | 126524 | 126525 | 126531 | 126532 | 126533 | 126534 | 126535 | 126536 | 126537 | 126538 | 128820 | 128821 | 128822 | 128823 | 128824 | 130726 | 130727 | 130728 | 130729 | 130730 | 131143 | 131144 | 131145 | 131146 | 131147 | 133947 | 133948 | 133949 | 133950 | 133951 | 134127 | 134128 | 134129 | 134130 | 134131 | 134132 | 134219 | 134368 | 134369 | 134370 | 134371 | 134372 | 134373 | 134374 | 134575 | 134608