Bug 22785 - Manage matches when importing through Stage Marc Record Import
Summary: Manage matches when importing through Stage Marc Record Import
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement with 10 votes (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on: 26326
Blocks:
  Show dependency treegraph
 
Reported: 2019-04-26 15:31 UTC by Joy Nelson
Modified: 2021-08-27 09:18 UTC (History)
9 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26326: Add Koha Objects for Import Records and Import Record Matches (14.62 KB, patch)
2021-01-04 16:52 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: Allow option to choose which record match is applied during import (37.68 KB, patch)
2021-01-04 16:53 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: DO NOT PUSH Schema updates (1.61 KB, patch)
2021-01-04 16:53 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: Update Schema for boolean (857 bytes, patch)
2021-01-04 16:53 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: Allow option to choose which record match is applied during import (37.53 KB, patch)
2021-05-14 17:52 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: DO NOT PUSH Schema updates (1.66 KB, patch)
2021-05-14 17:52 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: Update Schema for boolean (859 bytes, patch)
2021-05-14 17:52 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches (2.68 KB, patch)
2021-05-19 10:56 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: Allow option to choose which record match is applied during import (37.53 KB, patch)
2021-05-19 12:59 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: DO NOT PUSH Schema updates (1.44 KB, patch)
2021-05-19 12:59 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: Update Schema for boolean (859 bytes, patch)
2021-05-19 12:59 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches (2.68 KB, patch)
2021-05-19 12:59 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: Allow option to choose which record match is applied during import (39.64 KB, patch)
2021-05-19 13:01 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: DO NOT PUSH Schema updates (1.44 KB, patch)
2021-05-19 13:01 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: Update Schema for boolean (859 bytes, patch)
2021-05-19 13:01 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches (2.68 KB, patch)
2021-05-19 13:01 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22785: Allow option to choose which record match is applied during import (39.70 KB, patch)
2021-05-19 22:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 22785: DO NOT PUSH Schema updates (1.50 KB, patch)
2021-05-19 22:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 22785: Update Schema for boolean (925 bytes, patch)
2021-05-19 22:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches (2.75 KB, patch)
2021-05-19 22:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Joy Nelson 2019-04-26 15:31:03 UTC Comment hidden (obsolete)
Comment 1 Nick Clemens 2021-01-04 16:52:27 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2021-01-04 16:53:00 UTC
Created attachment 114814 [details] [review]
Bug 22785: Allow option to choose which record match is applied during import

This patchset adds the display of all matches found during import to the import management screen

A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import

To test:
1 - Import a batch of records or export existing records from your catalog
2 - Import the file (again) and select a matching rule that will find matches
3 - Note that you now have radio buttons allowing you to select a record, or none
4 - Test scenarios:
    I - When 'Action if matching record found' is 'Ignore'
        a - Imported record ignored if match is selected
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    II - When 'Action if matching record found' is 'Replace'
        a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm)
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    III - When 'Action if matching record found' is 'Add incoming record'
        a - Record is added regardless of matches
5 - Confirm 'Diff' 'View' links work as expected
6 - Confirm that after records are imported the radio buttons to choose are disabled
Comment 3 Nick Clemens 2021-01-04 16:53:02 UTC
Created attachment 114815 [details] [review]
Bug 22785: DO NOT PUSH Schema updates
Comment 4 Nick Clemens 2021-01-04 16:53:05 UTC
Created attachment 114816 [details] [review]
Bug 22785: Update Schema for boolean
Comment 5 Pascale Nalon 2021-04-01 13:57:33 UTC
In the test plan,is it necessary to set matching rules in administration page ?
Without one, the only choice in "Record matching rule" line is "Don't look for matching records"
Comment 6 Pascale Nalon 2021-04-02 09:18:28 UTC
I've set concordance rule in my sandbox and play 2nd step of the test plan : it's OK.
At the step 3, I don't understand where radio buttons should to be ? I can't see no radio buttons, before or after importing the new file.

Is the patch really applied on this sandbox  http://sandboxes.ptfs-europe.co.uk/provision_log/bz22785 ?
Comment 7 Nick Clemens 2021-04-02 10:52:28 UTC
(In reply to Pascale Nalon from comment #6)
> I've set concordance rule in my sandbox and play 2nd step of the test plan :
> it's OK.
> At the step 3, I don't understand where radio buttons should to be ? I can't
> see no radio buttons, before or after importing the new file.
> 
> Is the patch really applied on this sandbox 
> http://sandboxes.ptfs-europe.co.uk/provision_log/bz22785 ?

Checking the git log it only appears the dependency was applied - you can click 'Apply patches' under 'Actions' to apply the patches from this bug
Comment 8 Nick Clemens 2021-05-14 17:52:07 UTC
Created attachment 120995 [details] [review]
Bug 22785: Allow option to choose which record match is applied during import

This patchset adds the display of all matches found during import to the import management screen

A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import

To test:
1 - Import a batch of records or export existing records from your catalog
2 - Import the file (again) and select a matching rule that will find matches
3 - Note that you now have radio buttons allowing you to select a record, or none
4 - Test scenarios:
    I - When 'Action if matching record found' is 'Ignore'
        a - Imported record ignored if match is selected
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    II - When 'Action if matching record found' is 'Replace'
        a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm)
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    III - When 'Action if matching record found' is 'Add incoming record'
        a - Record is added regardless of matches
5 - Confirm 'Diff' 'View' links work as expected
6 - Confirm that after records are imported the radio buttons to choose are disabled
Comment 9 Nick Clemens 2021-05-14 17:52:14 UTC
Created attachment 120996 [details] [review]
Bug 22785: DO NOT PUSH Schema updates
Comment 10 Nick Clemens 2021-05-14 17:52:20 UTC
Created attachment 120997 [details] [review]
Bug 22785: Update Schema for boolean
Comment 11 Andrew Fuerste-Henry 2021-05-14 20:37:25 UTC
I took bib#1, and reimported it without editing, creating bib#439. I then edited ONLY the 245a in my downloaded copy of the bib and reimported it again, matching on ISBN. The incoming record shows matches with #1 and #439, as expected.

The smaller issue is that the list of potential matches isn't consistently in the same order. Sometimes 1 was above 439 and sometimes it was the other way around. This is really confusing, as it changed on the page load at import - I picked the bottom match, selected import, and when it finished the two matches had reversed their order.

Much more importantly, though, it consistently overlaid on bib#1, even when I told it I wanted to match to bib#439 instead. To recreate:
- have two identical bibs in your system
- import a third bib that you know will match the identical bibs but has a different title
- stage and match, telling Koha to overlay on a match
- select the higher bib number from your two potential matches
- import
- see the title changed on the lower bib number
Comment 12 Nick Clemens 2021-05-19 10:56:53 UTC
Created attachment 121149 [details] [review]
Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches

Previously the sorting took 'chosen' into account and would move a selected match to the
top on next load - it is better to preserve the same sorting every time

When loading matches the 'cehcked' variable was not being cleared, so multiple matches were
being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen
Comment 13 Nick Clemens 2021-05-19 12:59:15 UTC
Created attachment 121167 [details] [review]
Bug 22785: Allow option to choose which record match is applied during import

This patchset adds the display of all matches found during import to the import management screen

A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import

To test:
1 - Import a batch of records or export existing records from your catalog
2 - Import the file (again) and select a matching rule that will find matches
3 - Note that you now have radio buttons allowing you to select a record, or none
4 - Test scenarios:
    I - When 'Action if matching record found' is 'Ignore'
        a - Imported record ignored if match is selected
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    II - When 'Action if matching record found' is 'Replace'
        a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm)
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    III - When 'Action if matching record found' is 'Add incoming record'
        a - Record is added regardless of matches
5 - Confirm 'Diff' 'View' links work as expected
6 - Confirm that after records are imported the radio buttons to choose are disabled
Comment 14 Nick Clemens 2021-05-19 12:59:19 UTC
Created attachment 121168 [details] [review]
Bug 22785: DO NOT PUSH Schema updates
Comment 15 Nick Clemens 2021-05-19 12:59:22 UTC
Created attachment 121169 [details] [review]
Bug 22785: Update Schema for boolean
Comment 16 Nick Clemens 2021-05-19 12:59:26 UTC
Created attachment 121170 [details] [review]
Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches

Previously the sorting took 'chosen' into account and would move a selected match to the
top on next load - it is better to preserve the same sorting every time

When loading matches the 'cehcked' variable was not being cleared, so multiple matches were
being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen
Comment 17 Nick Clemens 2021-05-19 13:01:26 UTC
Created attachment 121171 [details] [review]
Bug 22785: Allow option to choose which record match is applied during import

This patchset adds the display of all matches found during import to the import management screen

A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import

To test:
1 - Import a batch of records or export existing records from your catalog
2 - Import the file (again) and select a matching rule that will find matches
3 - Note that you now have radio buttons allowing you to select a record, or none
4 - Test scenarios:
    I - When 'Action if matching record found' is 'Ignore'
        a - Imported record ignored if match is selected
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    II - When 'Action if matching record found' is 'Replace'
        a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm)
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    III - When 'Action if matching record found' is 'Add incoming record'
        a - Record is added regardless of matches
5 - Confirm 'Diff' 'View' links work as expected
6 - Confirm that after records are imported the radio buttons to choose are disabled
Comment 18 Nick Clemens 2021-05-19 13:01:30 UTC
Created attachment 121172 [details] [review]
Bug 22785: DO NOT PUSH Schema updates
Comment 19 Nick Clemens 2021-05-19 13:01:34 UTC
Created attachment 121173 [details] [review]
Bug 22785: Update Schema for boolean
Comment 20 Nick Clemens 2021-05-19 13:01:37 UTC
Created attachment 121174 [details] [review]
Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches

Previously the sorting took 'chosen' into account and would move a selected match to the
top on next load - it is better to preserve the same sorting every time

When loading matches the 'cehcked' variable was not being cleared, so multiple matches were
being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen
Comment 21 Andrew Fuerste-Henry 2021-05-19 22:16:08 UTC
Created attachment 121204 [details] [review]
Bug 22785: Allow option to choose which record match is applied during import

This patchset adds the display of all matches found during import to the import management screen

A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import

To test:
1 - Import a batch of records or export existing records from your catalog
2 - Import the file (again) and select a matching rule that will find matches
3 - Note that you now have radio buttons allowing you to select a record, or none
4 - Test scenarios:
    I - When 'Action if matching record found' is 'Ignore'
        a - Imported record ignored if match is selected
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    II - When 'Action if matching record found' is 'Replace'
        a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm)
        b - 'Action if no match found' followed if no match is selected (Ignore matches)
    III - When 'Action if matching record found' is 'Add incoming record'
        a - Record is added regardless of matches
5 - Confirm 'Diff' 'View' links work as expected
6 - Confirm that after records are imported the radio buttons to choose are disabled

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 22 Andrew Fuerste-Henry 2021-05-19 22:16:12 UTC
Created attachment 121205 [details] [review]
Bug 22785: DO NOT PUSH Schema updates

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 23 Andrew Fuerste-Henry 2021-05-19 22:16:16 UTC
Created attachment 121206 [details] [review]
Bug 22785: Update Schema for boolean

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 24 Andrew Fuerste-Henry 2021-05-19 22:16:20 UTC
Created attachment 121207 [details] [review]
Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches

Previously the sorting took 'chosen' into account and would move a selected match to the
top on next load - it is better to preserve the same sorting every time

When loading matches the 'cehcked' variable was not being cleared, so multiple matches were
being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 25 Marcel de Rooy 2021-08-27 09:18:11 UTC
Base does not apply