Attachment 13446 Details for Bug 7368 – [SIGNED-OFF] 7368 Removing occurrences of dependant= feature in javascript open calls

[patch] [SIGNED-OFF] 7368 Removing occurrences of dependant= feature in javascript open calls

SIGNED-OFF-7368-Removing-occurrences-of-dependant-.patch (text/plain), 7.59 KB, created by Owen Leonard on 2012-11-14 13:49:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2012-11-14 13:49:24 UTC

Size: 7.59 KB

patch

obsolete

>From 1ce347d7b6b3deaffba150030905b0cf61a3c0e0 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 12 Nov 2012 13:17:04 +0100
>Subject: [PATCH] [SIGNED-OFF] 7368 Removing occurrences of dependant= feature
> in javascript open calls
>Content-Type: text/plain; charset="utf-8"
>
>The window feature dependant= should have been written as dependent=
>Note that this feature is ignored in most/current browsers.
>Since the feature was misspelled, removing it will not change any behavior or hurt anybody.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../prog/en/includes/virtualshelves-toolbar.inc    |    4 ++--
> koha-tmpl/intranet-tmpl/prog/en/js/basket.js       |    6 +++---
> koha-tmpl/opac-tmpl/ccsr/en/js/basket.js           |    6 +++---
> koha-tmpl/opac-tmpl/prog/en/js/basket.js           |    4 ++--
> .../opac-tmpl/prog/en/modules/opac-shelves.tt      |    4 ++--
> 5 files changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc
>index 7318fb6..b2bd544 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc
>@@ -15,11 +15,11 @@
> 	 });
> 	 
> 	[% IF ( viewshelf ) %] function sendList(){
>-		open(CGIBIN+'virtualshelves/sendshelf.pl?shelfid=[% shelfnumber %]','win_form','dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
>+        open(CGIBIN+'virtualshelves/sendshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
> 	 }
> 	 
> 	 function downloadList(){
>-		open(CGIBIN+'virtualshelves/downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
>+        open(CGIBIN+'virtualshelves/downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
> 	 }[% END %]
> 
> 	// YUI Toolbar Functions
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/basket.js b/koha-tmpl/intranet-tmpl/prog/en/js/basket.js
>index 2043cd6..cddddf7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/basket.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/basket.js
>@@ -79,7 +79,7 @@ function openBasket() {
>     if ( strCookie ) {
>         var iW = 820;
>         var iH = 450;
>-        var optWin = "dependant=yes,status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
>+        var optWin = "status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
>         var loc = CGIBIN + "basket/basket.pl?" + strCookie;
>         var basket = open(loc, "basket", optWin);
>         if (window.focus) {basket.focus()}
>@@ -335,7 +335,7 @@ function sendBasket() {
> 
>     var loc = CGIBIN + "basket/sendbasket.pl?" + strCookie;
> 
>-    var optWin="dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100";
>+    var optWin="scrollbars=no,resizable=no,height=300,width=450,top=50,left=100";
>     var win_form = open(loc,"win_form",optWin);
> }
> 
>@@ -345,7 +345,7 @@ function downloadBasket() {
> 
>     var loc = CGIBIN + "basket/downloadcart.pl?" + strCookie;
> 
>-    open(loc,"win_form",'dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
>+    open(loc,"win_form",'scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
> }
> 
> function printBasket() {
>diff --git a/koha-tmpl/opac-tmpl/ccsr/en/js/basket.js b/koha-tmpl/opac-tmpl/ccsr/en/js/basket.js
>index 0ee0622..115880f 100644
>--- a/koha-tmpl/opac-tmpl/ccsr/en/js/basket.js
>+++ b/koha-tmpl/opac-tmpl/ccsr/en/js/basket.js
>@@ -80,7 +80,7 @@ function openBasket() {
>     if ( strCookie ) {
>         var iW = 820;
>         var iH = 450;
>-        var optWin = "dependant=yes,status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
>+        var optWin = "status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
>         var loc = CGIBIN + "opac-basket.pl?" + strCookie;
>         var basket = open(loc, "basket", optWin);
>         if (window.focus) {basket.focus()}
>@@ -354,7 +354,7 @@ function sendBasket() {
> 
>     var loc = CGIBIN + "opac-sendbasket.pl?" + strCookie;
> 
>-    var optWin="dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100";
>+    var optWin="scrollbars=no,resizable=no,height=300,width=450,top=50,left=100";
>     var win_form = open(loc,"win_form",optWin);
> }
> 
>@@ -365,7 +365,7 @@ function downloadBasket() {
> 
>     var loc = CGIBIN + "opac-downloadcart.pl?" + strCookie;
> 
>-    open(loc,"win_form",'dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
>+    open(loc,"win_form",'scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
> }
> 
> function printBasket() {
>diff --git a/koha-tmpl/opac-tmpl/prog/en/js/basket.js b/koha-tmpl/opac-tmpl/prog/en/js/basket.js
>index 13a2c36..8a0af37 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/js/basket.js
>+++ b/koha-tmpl/opac-tmpl/prog/en/js/basket.js
>@@ -80,7 +80,7 @@ function openBasket() {
>     if ( strCookie ) {
>         var iW = 820;
>         var iH = 450;
>-        var optWin = "dependant=yes,status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
>+        var optWin = "status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
>         var loc = CGIBIN + "opac-basket.pl?" + strCookie;
>         var basket = open(loc, "basket", optWin);
>         if (window.focus) {basket.focus()}
>@@ -365,7 +365,7 @@ function downloadBasket() {
> 
>     var loc = CGIBIN + "opac-downloadcart.pl?" + strCookie;
> 
>-    open(loc,"win_form",'dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
>+    open(loc,"win_form",'scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
> }
> 
> function printBasket() {
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt
>index 76a78b9..b94f1b5 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt
>@@ -261,9 +261,9 @@ $(function() {
>               [% IF ( itemsloop ) %]
>                   <div id="toolbar" class="list-actions">
> 
>-                      <a href="/cgi-bin/koha/opac-downloadshelf.pl?shelfid=[% shelfnumber %]" class="download" onclick="open(CGIBIN+'opac-downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false;">Download list</a>
>+                      <a href="/cgi-bin/koha/opac-downloadshelf.pl?shelfid=[% shelfnumber %]" class="download" onclick="open(CGIBIN+'opac-downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false;">Download list</a>
> 
>-[% IF ( opacuserlogin ) %]<span class="sendlist"><a href="/cgi-bin/koha/opac-sendshelf.pl?shelfid=[% shelfnumber %]" class="send" onclick="open(CGIBIN+'opac-sendshelf.pl?shelfid=[% shelfnumber %]','win_form','dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false; ">Send list</a></span>[% END %]
>+[% IF ( opacuserlogin ) %]<span class="sendlist"><a href="/cgi-bin/koha/opac-sendshelf.pl?shelfid=[% shelfnumber %]" class="send" onclick="open(CGIBIN+'opac-sendshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false; ">Send list</a></span>[% END %]
> 
> <a class="print" href="opac-shelves.pl" onclick="print(); return false;">Print list</a>
> 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 7368: 6867 | 8179 | 8925 | 9496 | 9497 | 9564 | 10191 | 10457 | 10458 | 10937 | 10939 | 10956 | 11048 | 11069 | 11189 | 11760 | 11761 | 13395 | 13443 | 13446 | 13971 | 14114 | 14115 | 14263 | 16095 | 17182 | 17183 | 17452 | 17785 | 17817 | 18400 | 18401 | 18407 | 19206 | 19208 | 19230 | 19258