Bugzilla – Attachment 134655 Details for
Bug 30572
Field search_marc_to_field.sort needs syncing too
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30572: (QA follow-up) Fix failing unit test
Bug-30572-QA-follow-up-Fix-failing-unit-test.patch (text/plain), 2.54 KB, created by
Martin Renvoize (ashimema)
on 2022-05-05 16:13:53 UTC
(
hide
)
Description:
Bug 30572: (QA follow-up) Fix failing unit test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-05-05 16:13:53 UTC
Size:
2.54 KB
patch
obsolete
>From 4e9d8bb29702544d08c217501484f1d796442065 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 5 May 2022 17:12:29 +0100 >Subject: [PATCH] Bug 30572: (QA follow-up) Fix failing unit test > >We changed from 'null' being meainingful to using a tinyint and >explicitly requiring '0'. This patch simply updates the unit test to >reflect that change. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../Koha/SearchEngine/Elasticsearch/ExportConfig.t | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/ExportConfig.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/ExportConfig.t >index 1c5ce67649..b2328a8d46 100755 >--- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/ExportConfig.t >+++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/ExportConfig.t >@@ -58,7 +58,7 @@ $search_field->add_to_search_marc_maps($marc_field, > { > facet => 0, > suggestible => 0, >- sort => undef >+ sort => 0 > } ); > > $marc_field = Koha::SearchMarcMaps->find_or_create( >@@ -72,7 +72,7 @@ $search_field->add_to_search_marc_maps($marc_field, > { > facet => 0, > suggestible => 0, >- sort => undef >+ sort => 0 > } ); > > $marc_field = Koha::SearchMarcMaps->find_or_create( >@@ -86,7 +86,7 @@ $search_field->add_to_search_marc_maps($marc_field, > { > facet => 0, > suggestible => 1, >- sort => undef >+ sort => 0 > } ); > > my $mappings = Koha::SearchEngine::Elasticsearch::raw_elasticsearch_mappings(); >@@ -105,14 +105,14 @@ is( $f212_map->{marc_field}, 212, 'First mapping is on field 212'); > is( $f212_map->{marc_type}, 'marc21', 'First mapping is for marc21'); > is( $f212_map->{facet}, '', 'First mapping facet is empty'); > is( $f212_map->{suggestible}, '', 'First mapping is not suggestible'); >-is( $f212_map->{sort}, undef, 'First mapping is not sortable'); >+is( $f212_map->{sort}, 0, 'First mapping is not sortable'); > > my $f247_map = $mappings->{biblios}{title}{mappings}[1]; > is( $f247_map->{marc_field}, 247, 'Second mapping is on field 247'); > is( $f247_map->{marc_type}, 'marc21', 'Second mapping is for marc21'); > is( $f247_map->{facet}, '', 'Second mapping facet is empty'); > is( $f247_map->{suggestible}, '', 'Second mapping is not suggestible'); >-is( $f247_map->{sort}, undef, 'Second mapping is not sortable'); >+is( $f247_map->{sort}, 0, 'Second mapping is not sortable'); > > $mappings = Koha::SearchEngine::Elasticsearch::raw_elasticsearch_mappings('unimarc'); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30572
:
133552
|
133553
|
133554
|
133892
|
133893
|
133894
| 134655