$DBversion = '20.11.03.003'; if( CheckVersion( $DBversion ) ) { $dbh->do( "UPDATE search_marc_to_field SET sort = 1 WHERE sort IS NULL" ); $dbh->do( "ALTER TABLE search_marc_to_field MODIFY COLUMN sort tinyint(1) DEFAULT 1 NOT NULL COMMENT 'Sort defaults to 1 (Yes) and creates sort fields in the index, 0 (no) will prevent this'" ); kohastructure: CREATE TABLE `search_marc_to_field` ( `sort` tinyint(1) DEFAULT NULL COMMENT 'true/false creates special sort handling, null doesn''t',
Created attachment 133552 [details] [review] Bug 30572: Adjust search_marc_to_field.sort in kohastructure Test plan: New install or run kohastructure on empty database. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 133553 [details] [review] Bug 30572: Dbrev for search_marc_to_field.sort Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 133554 [details] [review] Bug 30572: DBIx schema change for SearchMarcToField No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial: self SO
Created attachment 133892 [details] [review] Bug 30572: Adjust search_marc_to_field.sort in kohastructure Test plan: New install or run kohastructure on empty database. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 133893 [details] [review] Bug 30572: Dbrev for search_marc_to_field.sort Test plan: Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 133894 [details] [review] Bug 30572: DBIx schema change for SearchMarcToField No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works well, PQA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
This leads to failures on t/db_dependent/Koha/SearchEngine/Elasticsearch/ExportConfig.t
Created attachment 134655 [details] [review] Bug 30572: (QA follow-up) Fix failing unit test We changed from 'null' being meainingful to using a tinyint and explicitly requiring '0'. This patch simply updates the unit test to reflect that change. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Follow-up pushed to master, lets turn Jenkins green!
Pushed to 21.11.x for 21.11.06
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.
Another background thing, Not documentation changes required.