Bugzilla – Attachment 136157 Details for
Bug 29282
Show items.issue and items.renewals in the holdings table on the detail page in the staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29282: (QA follow-up) Class consistency
Bug-29282-QA-follow-up-Class-consistency.patch (text/plain), 3.94 KB, created by
Martin Renvoize (ashimema)
on 2022-06-16 12:18:47 UTC
(
hide
)
Description:
Bug 29282: (QA follow-up) Class consistency
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-06-16 12:18:47 UTC
Size:
3.94 KB
patch
obsolete
>From fe49628cc066ec6eb40b26004551c3fd7872bdb1 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 16 Jun 2022 13:15:17 +0100 >Subject: [PATCH] Bug 29282: (QA follow-up) Class consistency > >This patch updates the field classes introduced in this patchset to >improve class name consistency. We remove the _field apendment and to >repvent a clash we update the existing 'renewals' class elsewhere to >'renewals-info' to more clearly reflect it's content. > >Test plan >1) The patchset should continue to function as described in prior patches >2) Build the CSS for the staff client >3) Check the 'Checkouts' table on various screens and confirm the > renewals information still displays as it always has in the table. >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 49a5ce8767..129f8c152c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -3906,7 +3906,7 @@ input.renew { > margin-right: 1em; > } > >-.renewals { >+.renewals-info { > display: block; > font-size: .8em; > padding: .5em; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index ad33f33a82..b0a313a9d3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -533,8 +533,8 @@ Note that permanent location is a code, and location may be an authval. > [% END %] > </td> > <td class="datelastseen" data-order="[% item.datelastseen | html %]">[% item.datelastseen | $KohaDates %]</td> >- <td class="issues_field" data-order="[% item.issues || 0 | html %]">[% item.issues || 0 | html %]</td> >- <td class="renewals_field" data-order="[% item.renewals || 0 | html %]">[% item.renewals || 0 | html %]</td> >+ <td class="issues" data-order="[% item.issues || 0 | html %]">[% item.issues || 0 | html %]</td> >+ <td class="renewals" data-order="[% item.renewals || 0 | html %]">[% item.renewals || 0 | html %]</td> > <td class="dateaccessioned" data-order="[% item.dateaccessioned | html %]">[% item.dateaccessioned | $KohaDates %]</td> > <td class="datelastborrowed" data-order="[% item.datelastborrowed | html %]">[% item.datelastborrowed | $KohaDates %]</td> > <td><a href="/cgi-bin/koha/catalogue/moredetail.pl?type=[% item.type | uri %]&itemnumber=[% item.itemnumber | uri %]&biblionumber=[% item.biblionumber | uri %]&bi=[% item.biblioitemnumber | uri %]#item[% item.itemnumber | uri %]">[% item.barcode | html %]</a></td> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index b649ada637..471ec6bc68 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -587,7 +587,7 @@ $(document).ready(function() { > } > content += msg; > if ( can_renew || can_force_renew ) { >- content += "<span class='renewals'>("; >+ content += "<span class='renewals-info'>("; > content += __("%s of %s renewals remaining").format(oObj.renewals_remaining, oObj.renewals_allowed); > if (UnseenRenewals && oObj.unseen_allowed) { > content += __("%s of %s unseen renewals remaining").format(oObj.unseen_remaining, oObj.unseen_allowed); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29282
:
130568
|
131373
|
134981
|
135042
|
135043
|
136155
|
136156
| 136157