Some users would like to be able to see lifetime checkouts and renewals in the holdings table on a bib detail page. It'd be cool to make those columns available, but toggled off by default.
I like the idea
Created attachment 130568 [details] [review] Bug 29282: Add issues and renewals columns to holdings tbale on details page To test: 1 - Apply patch, restart all 2 - View a record with items in the staff client 3 - Note issues and renewals columns not shown 4 - Click the gear to edit visible columns 5 - Issues and renewals are present and hidden 6 - Click to view columns 7 - Confirm counts show, or 0 if item has not circulated/been renewed 8 - Circulate/renew an item 9 - Verify counts increase 10 - Make columns visible by default in Admin->Table settings 11 - Confirm columns show by default on details page
We would love to see the total checkouts column from the edit items screen appear on the main bib detail page. this will allow us to immediately see how many times a materials has circulated without having additional clicks. It will aid with acquisitions. Bossier Parish Libraries.
Created attachment 131373 [details] [review] Bug 29282: Add issues and renewals columns to holdings tbale on details page To test: 1 - Apply patch, restart all 2 - View a record with items in the staff client 3 - Note issues and renewals columns not shown 4 - Click the gear to edit visible columns 5 - Issues and renewals are present and hidden 6 - Click to view columns 7 - Confirm counts show, or 0 if item has not circulated/been renewed 8 - Circulate/renew an item 9 - Verify counts increase 10 - Make columns visible by default in Admin->Table settings 11 - Confirm columns show by default on details page Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Hi Andrew, this works really nicely and I like that they are hidden by default. But could you make the same changes to the otherholdings table so we keep them in sync? It's tied to the SeparateHoldings system preference that divides the items between your own and the other branches.
Created attachment 134981 [details] [review] Bug 29282: (follow-up) Account for otherholdings table This patch accounts for the otherholdins table. To test: 1. Turn on SeparateHoldings 2. Find a record where the items are split by SeparateHoldings. 3. Make sure you can hide columns from the table in the Other holdings tab.
Created attachment 135042 [details] [review] Bug 29282: Add issues and renewals columns to holdings tbale on details page To test: 1 - Apply patch, restart all 2 - View a record with items in the staff client 3 - Note issues and renewals columns not shown 4 - Click the gear to edit visible columns 5 - Issues and renewals are present and hidden 6 - Click to view columns 7 - Confirm counts show, or 0 if item has not circulated/been renewed 8 - Circulate/renew an item 9 - Verify counts increase 10 - Make columns visible by default in Admin->Table settings 11 - Confirm columns show by default on details page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 135043 [details] [review] Bug 29282: (follow-up) Account for otherholdings table This patch accounts for the otherholdins table. To test: 1. Turn on SeparateHoldings 2. Find a record where the items are split by SeparateHoldings. 3. Make sure you can hide columns from the table in the Other holdings tab. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Really nice patch - works great, thanks both!
Is there a reason to use the classes issues_field and renewals_field for the values when the other columns don't have the _field prefix? There doesn't seem to be a name clash in the file with issues and renewals. Otherwise everything looks good for QA.
(In reply to Victor Grousset/tuxayo from comment #10) > Is there a reason to use the classes issues_field and renewals_field for the > values when the other columns don't have the _field prefix? There doesn't > seem to be a name clash in the file with issues and renewals. > > Otherwise everything looks good for QA. I think those classes already has associated styles, and this was just a way to differentiate the view on this page
(In reply to Nick Clemens from comment #11) > (In reply to Victor Grousset/tuxayo from comment #10) > > Is there a reason to use the classes issues_field and renewals_field for the > > values when the other columns don't have the _field prefix? There doesn't > > seem to be a name clash in the file with issues and renewals. > > > > Otherwise everything looks good for QA. > > I think those classes already has associated styles, and this was just a way > to differentiate the view on this page I see a .renewals rule in staff-global.scss (though I'm struggling to find anything using the class in the templates right now) but I don't see any rules that would catch an 'issues' class. I think personally I'd like to see the consistency carried through and the _field dropped from the class names. Asking Owen for an opinion in case I've missed something obvious.
Created attachment 136155 [details] [review] Bug 29282: Add issues and renewals columns to holdings tbale on details page To test: 1 - Apply patch, restart all 2 - View a record with items in the staff client 3 - Note issues and renewals columns not shown 4 - Click the gear to edit visible columns 5 - Issues and renewals are present and hidden 6 - Click to view columns 7 - Confirm counts show, or 0 if item has not circulated/been renewed 8 - Circulate/renew an item 9 - Verify counts increase 10 - Make columns visible by default in Admin->Table settings 11 - Confirm columns show by default on details page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 136156 [details] [review] Bug 29282: (follow-up) Account for otherholdings table This patch accounts for the otherholdins table. To test: 1. Turn on SeparateHoldings 2. Find a record where the items are split by SeparateHoldings. 3. Make sure you can hide columns from the table in the Other holdings tab. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 136157 [details] [review] Bug 29282: (QA follow-up) Class consistency This patch updates the field classes introduced in this patchset to improve class name consistency. We remove the _field apendment and to repvent a clash we update the existing 'renewals' class elsewhere to 'renewals-info' to more clearly reflect it's content. Test plan 1) The patchset should continue to function as described in prior patches 2) Build the CSS for the staff client 3) Check the 'Checkouts' table on various screens and confirm the renewals information still displays as it always has in the table.
All works as described. I added a follow-up to make the classes introduced consistent with the rest of the table, but that also entailed updating an existing class elsewhere. I'll leave it to the RM to decide which way to jump here.. we can push with or without the final followup. Passing QA
Pushed to master for 22.11. Nice work everyone, thanks!
Enhancment will not be backported to 22.05.x series unless requested