Attachment 136926 Details for Bug 28854 – Bug 28854: Unit test for Koha::Item additions

[patch] Bug 28854: Unit test for Koha::Item additions

Bug-28854-Unit-test-for-KohaItem-additions.patch (text/plain), 8.49 KB, created by Katrin Fischer on 2022-07-01 13:52:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-07-01 13:52:54 UTC

Size: 8.49 KB

patch

obsolete

>From 7cef926e239dcc390e398a2b00dea41afb3c70b6 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 17 Jun 2022 13:08:46 +0100
>Subject: [PATCH] Bug 28854: Unit test for Koha::Item additions
>
>This patch adds unit tests for the new methods added to Koha::Item
>including:
>
>* return_claim
>* return_claims
>* is_bundle
>* in_bundle
>* bundle_host
>* bundle_items
>* add_to_bundle
>* remove_from_bundle
>
>Test plan
>1) Run t/db_dependent/Koha/Item.t
>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>---
> t/db_dependent/Koha/Item.t | 195 ++++++++++++++++++++++++++++++++++++-
> 1 file changed, 194 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t
>index cbe52ed63e..813ea66371 100755
>--- a/t/db_dependent/Koha/Item.t
>+++ b/t/db_dependent/Koha/Item.t
>@@ -20,7 +20,7 @@
> use Modern::Perl;
> use utf8;
> 
>-use Test::More tests => 16;
>+use Test::More tests => 24;
> use Test::Exception;
> use Test::MockModule;
> 
>@@ -41,6 +41,66 @@ use t::lib::Mocks;
> my $schema  = Koha::Database->new->schema;
> my $builder = t::lib::TestBuilder->new;
> 
>+subtest 'return_claims relationship' => sub {
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $biblio = $builder->build_sample_biblio();
>+    my $item   = $builder->build_sample_item({
>+        biblionumber => $biblio->biblionumber,
>+    });
>+    my $return_claims = $item->return_claims;
>+    is( ref($return_claims), 'Koha::Checkouts::ReturnClaims', 'return_claims returns a Koha::Checkouts::ReturnClaims object set' );
>+    is($item->return_claims->count, 0, "Empty Koha::Checkouts::ReturnClaims set returned if no return_claims");
>+    my $claim1 = $builder->build({ source => 'ReturnClaim', value => { itemnumber => $item->itemnumber }});
>+    my $claim2 = $builder->build({ source => 'ReturnClaim', value => { itemnumber => $item->itemnumber }});
>+
>+    is($item->return_claims()->count,2,"Two ReturnClaims found for item");
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'return_claim accessor' => sub {
>+    plan tests => 5;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $biblio = $builder->build_sample_biblio();
>+    my $item   = $builder->build_sample_item({
>+        biblionumber => $biblio->biblionumber,
>+    });
>+    my $return_claim = $item->return_claim;
>+    is( $return_claim, undef, 'return_claim returned undefined if there are no claims for this item' );
>+
>+    my $claim1 = $builder->build_object(
>+        {
>+            class => 'Koha::Checkouts::ReturnClaims',
>+            value => { itemnumber => $item->itemnumber, resolution => undef, created_on => dt_from_string()->subtract( minutes => 10 ) }
>+        }
>+    );
>+    my $claim2 = $builder->build_object(
>+        {
>+            class => 'Koha::Checkouts::ReturnClaims',
>+            value  => { itemnumber => $item->itemnumber, resolution => undef, created_on => dt_from_string()->subtract( minutes => 5 ) }
>+        }
>+    );
>+
>+    $return_claim = $item->return_claim;
>+    is( ref($return_claim), 'Koha::Checkouts::ReturnClaim', 'return_claim returned a Koha::Checkouts::ReturnClaim object' );
>+    is( $return_claim->id, $claim2->id, 'return_claim returns the most recent unresolved claim');
>+
>+    $claim2->resolution('test')->store();
>+    $return_claim = $item->return_claim;
>+    is( $return_claim->id, $claim1->id, 'return_claim returns the only unresolved claim');
>+
>+    $claim1->resolution('test')->store();
>+    $return_claim = $item->return_claim;
>+    is( $return_claim, undef, 'return_claim returned undefined if there are no active claims for this item' );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
> subtest 'tracked_links relationship' => sub {
>     plan tests => 3;
> 
>@@ -57,6 +117,139 @@ subtest 'tracked_links relationship' => sub {
>     is($item->tracked_links()->count,2,"Two tracked links found");
> };
> 
>+subtest 'is_bundle tests' => sub {
>+    plan tests => 2;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $item   = $builder->build_sample_item();
>+
>+    my $is_bundle = $item->is_bundle;
>+    is($is_bundle, 0, 'is_bundle returns 0 when there are no items attached');
>+
>+    my $item2 = $builder->build_sample_item();
>+    $schema->resultset('ItemBundle')
>+      ->create( { host => $item->itemnumber, item => $item2->itemnumber } );
>+
>+    $is_bundle = $item->is_bundle;
>+    is($is_bundle, 1, 'is_bundle returns 1 when there is at least one item attached');
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'in_bundle tests' => sub {
>+    plan tests => 2;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $item   = $builder->build_sample_item();
>+
>+    my $in_bundle = $item->in_bundle;
>+    is($in_bundle, 0, 'in_bundle returns 0 when the item is not in a bundle');
>+
>+    my $host_item = $builder->build_sample_item();
>+    $schema->resultset('ItemBundle')
>+      ->create( { host => $host_item->itemnumber, item => $item->itemnumber } );
>+
>+    $in_bundle = $item->in_bundle;
>+    is($in_bundle, 1, 'in_bundle returns 1 when the item is in a bundle');
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'bundle_items tests' => sub {
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $host_item = $builder->build_sample_item();
>+    my $bundle_items = $host_item->bundle_items;
>+    is( ref($bundle_items), 'Koha::Items',
>+        'bundle_items returns a Koha::Items object set' );
>+    is( $bundle_items->count, 0,
>+        'bundle_items set is empty when no items are bundled' );
>+
>+    my $bundle_item1 = $builder->build_sample_item();
>+    my $bundle_item2 = $builder->build_sample_item();
>+    my $bundle_item3 = $builder->build_sample_item();
>+    $schema->resultset('ItemBundle')
>+      ->create(
>+        { host => $host_item->itemnumber, item => $bundle_item1->itemnumber } );
>+    $schema->resultset('ItemBundle')
>+      ->create(
>+        { host => $host_item->itemnumber, item => $bundle_item2->itemnumber } );
>+    $schema->resultset('ItemBundle')
>+      ->create(
>+        { host => $host_item->itemnumber, item => $bundle_item3->itemnumber } );
>+
>+    $bundle_items = $host_item->bundle_items;
>+    is( $bundle_items->count, 3,
>+        'bundle_items returns all the bundled items in the set' );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'bundle_host tests' => sub {
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $host_item = $builder->build_sample_item();
>+    my $bundle_item1 = $builder->build_sample_item();
>+    my $bundle_item2 = $builder->build_sample_item();
>+    $schema->resultset('ItemBundle')
>+      ->create(
>+        { host => $host_item->itemnumber, item => $bundle_item2->itemnumber } );
>+
>+    my $bundle_host = $bundle_item1->bundle_host;
>+    is( $bundle_host, undef, 'bundle_host returns undefined when the item it not part of a bundle');
>+    $bundle_host = $bundle_item2->bundle_host;
>+    is( ref($bundle_host), 'Koha::Item', 'bundle_host returns a Koha::Item object when the item is in a bundle');
>+    is( $bundle_host->id, $host_item->id, 'bundle_host returns the host item when called against an item in a bundle');
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'add_to_bundle tests' => sub {
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    t::lib::Mocks::mock_preference( 'BundleNotLoanValue', 1 );
>+
>+    my $host_item = $builder->build_sample_item();
>+    my $bundle_item1 = $builder->build_sample_item();
>+    my $bundle_item2 = $builder->build_sample_item();
>+
>+    ok($host_item->add_to_bundle($bundle_item1), 'bundle_item1 added to bundle');
>+    is($bundle_item1->notforloan, 1, 'add_to_bundle sets notforloan to BundleNotLoanValue');
>+
>+    throws_ok { $host_item->add_to_bundle($bundle_item1) }
>+    'Koha::Exceptions::Object::DuplicateID',
>+      'Exception thrown if you try to add the same item twice';
>+
>+    $schema->storage->txn_rollback;
>+};
>+
>+subtest 'remove_from_bundle tests' => sub {
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $host_item = $builder->build_sample_item();
>+    my $bundle_item1 = $builder->build_sample_item({ notforloan => 1 });
>+    $schema->resultset('ItemBundle')
>+      ->create(
>+        { host => $host_item->itemnumber, item => $bundle_item1->itemnumber } );
>+
>+    is($bundle_item1->remove_from_bundle(), 1, 'remove_from_bundle returns 1 when item is removed from a bundle');
>+    is($bundle_item1->notforloan, 0, 'remove_from_bundle resets notforloan to 0');
>+    $bundle_item1 = $bundle_item1->get_from_storage;
>+    is($bundle_item1->remove_from_bundle(), 0, 'remove_from_bundle returns 0 when item is not in a bundle');
>+
>+    $schema->storage->txn_rollback;
>+};
>+
> subtest 'hidden_in_opac() tests' => sub {
> 
>     plan tests => 4;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 28854: 124319 | 124498 | 124616 | 125200 | 125201 | 125202 | 125203 | 125204 | 125205 | 125206 | 126103 | 126104 | 126105 | 126106 | 126107 | 126108 | 126109 | 126110 | 126148 | 126149 | 126150 | 126151 | 126152 | 126153 | 126154 | 126155 | 126166 | 126167 | 126168 | 126169 | 126170 | 126171 | 126172 | 126173 | 127498 | 127499 | 127500 | 127501 | 127502 | 127503 | 127504 | 127505 | 127659 | 127660 | 127661 | 127662 | 127663 | 127664 | 127665 | 127666 | 127829 | 127830 | 127831 | 127832 | 127833 | 127834 | 127835 | 127836 | 127837 | 127838 | 130313 | 130314 | 130315 | 130316 | 130317 | 130318 | 130319 | 130320 | 130321 | 130322 | 130323 | 130324 | 130325 | 130326 | 130327 | 130328 | 130329 | 130330 | 130331 | 130332 | 130456 | 132703 | 132704 | 132705 | 132706 | 132707 | 132708 | 132709 | 132710 | 132711 | 132712 | 132713 | 132714 | 132715 | 132716 | 132717 | 132718 | 132719 | 132720 | 132721 | 132722 | 132723 | 135019 | 135020 | 135021 | 135022 | 135023 | 135024 | 135025 | 135026 | 135027 | 135028 | 135029 | 135030 | 135031 | 135032 | 135033 | 135034 | 135035 | 135036 | 135037 | 136226 | 136227 | 136228 | 136229 | 136230 | 136231 | 136232 | 136233 | 136234 | 136235 | 136236 | 136237 | 136238 | 136239 | 136240 | 136241 | 136242 | 136243 | 136244 | 136249 | 136253 | 136254 | 136264 | 136265 | 136266 | 136267 | 136268 | 136269 | 136270 | 136271 | 136272 | 136273 | 136274 | 136275 | 136276 | 136277 | 136278 | 136279 | 136280 | 136281 | 136282 | 136283 | 136284 | 136285 | 136287 | 136340 | 136341 | 136342 | 136343 | 136344 | 136345 | 136346 | 136347 | 136348 | 136349 | 136350 | 136351 | 136352 | 136353 | 136354 | 136355 | 136356 | 136357 | 136358 | 136359 | 136360 | 136361 | 136362 | 136363 | 136364 | 136365 | 136366 | 136367 | 136368 | 136369 | 136370 | 136371 | 136498 | 136529 | 136530 | 136613 | 136614 | 136615 | 136616 | 136617 | 136618 | 136619 | 136620 | 136621 | 136622 | 136623 | 136624 | 136625 | 136626 | 136627 | 136628 | 136629 | 136630 | 136631 | 136632 | 136633 | 136634 | 136635 | 136636 | 136637 | 136638 | 136639 | 136640 | 136641 | 136642 | 136643 | 136644 | 136645 | 136646 | 136647 | 136648 | 136649 | 136650 | 136651 | 136652 | 136654 | 136655 | 136806 | 136809 | 136811 | 136814 | 136817 | 136821 | 136824 | 136826 | 136829 | 136832 | 136835 | 136838 | 136841 | 136843 | 136846 | 136849 | 136850 | 136851 | 136852 | 136853 | 136854 | 136855 | 136856 | 136857 | 136858 | 136859 | 136860 | 136861 | 136862 | 136863 | 136864 | 136865 | 136866 | 136867 | 136868 | 136869 | 136870 | 136871 | 136872 | 136873 | 136874 | 136875 | 136876 | 136877 | 136905 | 136906 | 136907 | 136908 | 136909 | 136910 | 136911 | 136912 | 136913 | 136914 | 136915 | 136916 | 136917 | 136918 | 136919 | 136920 | 136921 | 136922 | 136923 | 136924 | 136925 | 136926 | 136927 | 136928 | 136929 | 136930 | 136931 | 136932 | 136933 | 136934 | 136935 | 136936 | 136937 | 136938 | 136939 | 136940 | 136941 | 136942 | 136943 | 136944 | 136945 | 136946 | 136947 | 136949 | 136978 | 136979 | 136980 | 136981 | 136982 | 136985 | 136988 | 136989 | 136990 | 136991 | 136992 | 136993 | 136994 | 136995 | 136996 | 136997 | 136998 | 136999 | 137000 | 137001 | 137002 | 137003 | 137004 | 137005 | 137006 | 137007 | 137008 | 137009 | 137010 | 137011 | 137012 | 137013 | 137014 | 137015 | 137016 | 137017 | 137018 | 137019 | 137020 | 137021 | 137022 | 137461 | 137462 | 137463 | 137464 | 137465 | 137466 | 137467 | 137468 | 137469 | 137470 | 137471 | 137472 | 137473 | 137474 | 137475 | 137476 | 137477 | 137478 | 137479 | 137480 | 137481 | 137482 | 137483 | 137484 | 137485 | 137486 | 137487 | 137488 | 137489 | 137490 | 137491 | 137492 | 137493 | 137494 | 137495 | 137496 | 137497 | 137498 | 137499 | 137500 | 137501 | 137503 | 137506 | 137524 | 137525 | 137527 | 137528 | 137529 | 137530 | 137531 | 137532 | 137533 | 137534 | 137535 | 137536 | 137537 | 137538 | 137540 | 137541 | 137542 | 137543 | 137544 | 137545 | 137546 | 137547 | 137548 | 137549 | 137550 | 137551 | 137552 | 137553 | 137554 | 137555 | 137556 | 137557 | 137558 | 137559 | 137560 | 137561 | 137562 | 137563 | 137564 | 137565 | 137566 | 137567 | 137568 | 137569 | 137570 | 137571 | 137684 | 137685 | 139347