Bug 28854 - Add ability to create bundles of items for circulation
Summary: Add ability to create bundles of items for circulation
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low new feature (vote)
Assignee: Martin Renvoize
QA Contact: Kyle M Hall
URL: https://gitlab.com/mrenvoize/Koha/-/m...
Keywords:
: 24023 28602 (view as bug list)
Depends on: 27358 29408 29575 31085 31087
Blocks: 29099 29560 29566 31078 31079 31080 31081 31084 31130 33035 34881 35963 25503 31083 31192 31615 32121 32134 33817
  Show dependency treegraph
 
Reported: 2021-08-13 09:41 UTC by Martin Renvoize
Modified: 2024-01-31 15:43 UTC (History)
27 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Large patch
Documentation contact: Martin Renvoize
Documentation submission:
Text to go in the release notes:
This new feature adds the ability to create item bundles for loans. One can create a new collection level biblio record and add items to it as normal. Those items can then be converted to bundles by adding existing items to them using their barcodes. The items will be marked as 'not for loan' in their original parent records. Bundle items follow normal circulation rules for checkout. Upon check-in a new verification step is added where by the librarian is expected to scan each constituent item to varify it's presence in the bundle. If an item is missing from the bundle it is marked as lost with a new lost - Missing from bundle value. If an item is found that is not expected to be in the bundle it it highlighted to the librarian after check-in so it can be placed to one side. **Sponsored by** *PTFS Europe*
Version(s) released in:
22.11.00


Attachments
Bug 28854: Add ability to create and circulate item bundles (86.41 KB, patch)
2021-09-01 10:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ability to create and circulate item bundles (87.32 KB, patch)
2021-09-03 15:50 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ability to create and circulate item bundles (87.32 KB, patch)
2021-09-07 14:21 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (6.29 KB, patch)
2021-09-23 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (7.92 KB, patch)
2021-09-23 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.70 KB, patch)
2021-09-23 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add bundle content display to OPAC (6.65 KB, patch)
2021-09-23 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (24.80 KB, patch)
2021-09-23 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (3.89 KB, patch)
2021-09-23 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Respect WhenLostChargeReplacementFee (2.78 KB, patch)
2021-09-23 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (6.21 KB, patch)
2021-10-12 15:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (7.86 KB, patch)
2021-10-12 15:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (37.52 KB, patch)
2021-10-12 15:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add bundle content display to OPAC (6.60 KB, patch)
2021-10-12 15:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (24.76 KB, patch)
2021-10-12 15:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (3.83 KB, patch)
2021-10-12 15:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Respect WhenLostChargeReplacementFee (2.72 KB, patch)
2021-10-12 15:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2021-10-12 15:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (6.21 KB, patch)
2021-10-13 08:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (7.86 KB, patch)
2021-10-13 08:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (37.52 KB, patch)
2021-10-13 08:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add bundle content display to OPAC (10.78 KB, patch)
2021-10-13 08:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (24.76 KB, patch)
2021-10-13 08:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (3.83 KB, patch)
2021-10-13 08:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Respect WhenLostChargeReplacementFee (2.72 KB, patch)
2021-10-13 08:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2021-10-13 08:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (6.21 KB, patch)
2021-10-13 09:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (7.86 KB, patch)
2021-10-13 09:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (37.52 KB, patch)
2021-10-13 09:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add bundle content display to OPAC (10.13 KB, patch)
2021-10-13 09:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (24.76 KB, patch)
2021-10-13 09:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (3.83 KB, patch)
2021-10-13 09:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Respect WhenLostChargeReplacementFee (2.72 KB, patch)
2021-10-13 09:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2021-10-13 09:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (6.21 KB, patch)
2021-11-10 08:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (7.86 KB, patch)
2021-11-10 08:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (34.71 KB, patch)
2021-11-10 08:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add bundle content display to OPAC (9.50 KB, patch)
2021-11-10 08:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (24.76 KB, patch)
2021-11-10 08:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (3.83 KB, patch)
2021-11-10 08:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Respect WhenLostChargeReplacementFee (2.72 KB, patch)
2021-11-10 08:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2021-11-10 08:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (6.21 KB, patch)
2021-11-15 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (7.86 KB, patch)
2021-11-15 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (34.72 KB, patch)
2021-11-15 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add bundle content display to OPAC (9.50 KB, patch)
2021-11-15 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (24.76 KB, patch)
2021-11-15 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (3.83 KB, patch)
2021-11-15 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Respect WhenLostChargeReplacementFee (2.72 KB, patch)
2021-11-15 16:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2021-11-15 16:46 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.04 KB, patch)
2021-11-19 08:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (4.42 KB, patch)
2021-11-19 08:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.22 KB, patch)
2021-11-19 08:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add bundle content display to OPAC (9.50 KB, patch)
2021-11-19 08:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (24.32 KB, patch)
2021-11-19 08:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (15.42 KB, patch)
2021-11-19 08:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.93 KB, patch)
2021-11-19 08:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.18 KB, patch)
2021-11-19 08:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2021-11-19 08:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.19 KB, patch)
2021-11-19 08:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.04 KB, patch)
2022-02-08 16:52 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (4.42 KB, patch)
2022-02-08 16:52 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.60 KB, patch)
2022-02-08 16:52 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.87 KB, patch)
2022-02-08 16:52 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2022-02-08 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.93 KB, patch)
2022-02-08 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.18 KB, patch)
2022-02-08 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.67 KB, patch)
2022-02-08 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.19 KB, patch)
2022-02-08 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.76 KB, patch)
2022-02-08 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.74 KB, patch)
2022-02-08 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.01 KB, patch)
2022-02-08 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (2.90 KB, patch)
2022-02-08 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.23 KB, patch)
2022-02-08 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.71 KB, patch)
2022-02-08 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.32 KB, patch)
2022-02-08 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.47 KB, patch)
2022-02-08 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.26 KB, patch)
2022-02-08 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.54 KB, patch)
2022-02-08 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Fix rebase re-indroduction of .json (5.63 KB, patch)
2022-02-08 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Documentation (2.21 MB, application/pdf)
2022-02-10 16:50 UTC, Martin Renvoize
Details
Bug 28854: Database update (4.04 KB, patch)
2022-03-31 12:06 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Rename atomicupdate (.perl -> .pl) (692 bytes, patch)
2022-03-31 12:06 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.78 KB, patch)
2022-03-31 12:06 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.43 KB, patch)
2022-03-31 12:07 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.79 KB, patch)
2022-03-31 12:07 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2022-03-31 12:07 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.92 KB, patch)
2022-03-31 12:07 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.18 KB, patch)
2022-03-31 12:08 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.67 KB, patch)
2022-03-31 12:08 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.19 KB, patch)
2022-03-31 12:08 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.76 KB, patch)
2022-03-31 12:08 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.74 KB, patch)
2022-03-31 12:08 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.01 KB, patch)
2022-03-31 12:09 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (2.78 KB, patch)
2022-03-31 12:09 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.23 KB, patch)
2022-03-31 12:09 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.71 KB, patch)
2022-03-31 12:09 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.32 KB, patch)
2022-03-31 12:09 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.47 KB, patch)
2022-03-31 12:10 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.26 KB, patch)
2022-03-31 12:10 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.54 KB, patch)
2022-03-31 12:10 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: (follow-up) Fix rebase re-indroduction of .json (5.63 KB, patch)
2022-03-31 12:10 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 28854: Database update (4.03 KB, patch)
2022-05-16 14:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.78 KB, patch)
2022-05-16 14:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (37.08 KB, patch)
2022-05-16 14:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.79 KB, patch)
2022-05-16 14:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2022-05-16 14:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.92 KB, patch)
2022-05-16 14:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.18 KB, patch)
2022-05-16 14:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.67 KB, patch)
2022-05-16 14:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.19 KB, patch)
2022-05-16 14:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.76 KB, patch)
2022-05-16 14:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.74 KB, patch)
2022-05-16 14:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.01 KB, patch)
2022-05-16 14:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.17 KB, patch)
2022-05-16 14:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.23 KB, patch)
2022-05-16 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.71 KB, patch)
2022-05-16 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.32 KB, patch)
2022-05-16 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.47 KB, patch)
2022-05-16 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.26 KB, patch)
2022-05-16 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.54 KB, patch)
2022-05-16 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.03 KB, patch)
2022-06-17 08:46 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.78 KB, patch)
2022-06-17 08:46 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (37.10 KB, patch)
2022-06-17 08:46 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.79 KB, patch)
2022-06-17 08:46 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2022-06-17 08:46 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.92 KB, patch)
2022-06-17 08:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.18 KB, patch)
2022-06-17 08:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.68 KB, patch)
2022-06-17 08:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.19 KB, patch)
2022-06-17 08:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.76 KB, patch)
2022-06-17 08:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.74 KB, patch)
2022-06-17 08:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.01 KB, patch)
2022-06-17 08:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.17 KB, patch)
2022-06-17 08:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.23 KB, patch)
2022-06-17 08:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.71 KB, patch)
2022-06-17 08:48 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.32 KB, patch)
2022-06-17 08:48 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.47 KB, patch)
2022-06-17 08:48 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.26 KB, patch)
2022-06-17 08:48 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.54 KB, patch)
2022-06-17 08:48 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (2.26 KB, patch)
2022-06-17 09:34 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (3.82 KB, patch)
2022-06-17 11:20 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 (913 bytes, patch)
2022-06-17 11:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.03 KB, patch)
2022-06-17 13:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.78 KB, patch)
2022-06-17 13:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.90 KB, patch)
2022-06-17 13:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.79 KB, patch)
2022-06-17 13:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2022-06-17 13:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.92 KB, patch)
2022-06-17 13:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.18 KB, patch)
2022-06-17 13:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.68 KB, patch)
2022-06-17 13:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.19 KB, patch)
2022-06-17 13:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.76 KB, patch)
2022-06-17 13:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.74 KB, patch)
2022-06-17 13:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.01 KB, patch)
2022-06-17 13:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.17 KB, patch)
2022-06-17 13:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.23 KB, patch)
2022-06-17 13:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.71 KB, patch)
2022-06-17 13:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.32 KB, patch)
2022-06-17 13:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.47 KB, patch)
2022-06-17 13:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.26 KB, patch)
2022-06-17 13:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.54 KB, patch)
2022-06-17 13:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (3.82 KB, patch)
2022-06-17 13:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 (913 bytes, patch)
2022-06-17 13:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for Koha::Item additions (8.44 KB, patch)
2022-06-17 13:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for AddReturn addition (1.70 KB, patch)
2022-06-17 14:05 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit tests - chargelostitem (3.63 KB, patch)
2022-06-20 09:07 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add default AV and Syspref values (2.62 KB, patch)
2022-06-20 09:20 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Translations fixes (15.10 KB, patch)
2022-06-20 10:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Translations fixes (15.10 KB, patch)
2022-06-20 10:27 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.03 KB, patch)
2022-06-20 10:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.78 KB, patch)
2022-06-20 10:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.91 KB, patch)
2022-06-20 10:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.79 KB, patch)
2022-06-20 10:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2022-06-20 10:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.92 KB, patch)
2022-06-20 10:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.18 KB, patch)
2022-06-20 10:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.68 KB, patch)
2022-06-20 10:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.19 KB, patch)
2022-06-20 10:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.76 KB, patch)
2022-06-20 10:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.74 KB, patch)
2022-06-20 10:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.01 KB, patch)
2022-06-20 10:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.17 KB, patch)
2022-06-20 10:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.23 KB, patch)
2022-06-20 10:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.71 KB, patch)
2022-06-20 10:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.32 KB, patch)
2022-06-20 10:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.47 KB, patch)
2022-06-20 10:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.26 KB, patch)
2022-06-20 10:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.54 KB, patch)
2022-06-20 10:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (3.82 KB, patch)
2022-06-20 10:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 (913 bytes, patch)
2022-06-20 10:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for Koha::Item additions (8.43 KB, patch)
2022-06-20 10:35 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for AddReturn addition (1.70 KB, patch)
2022-06-20 10:35 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit tests - chargelostitem (3.63 KB, patch)
2022-06-20 10:35 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add default AV and Syspref values (2.62 KB, patch)
2022-06-20 10:35 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Translations fixes (15.10 KB, patch)
2022-06-20 10:35 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Rename column configuration to barcode (824 bytes, patch)
2022-06-20 10:35 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Move preferences to "Item bundles" (2.85 KB, patch)
2022-06-20 10:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Fix typo in templates and test plan (1.96 KB, patch)
2022-06-24 14:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Improve error for item not found (2.23 KB, patch)
2022-06-24 15:52 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items (1.31 KB, patch)
2022-06-24 15:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.03 KB, patch)
2022-06-27 15:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.78 KB, patch)
2022-06-27 15:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.88 KB, patch)
2022-06-27 15:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.79 KB, patch)
2022-06-27 15:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2022-06-27 15:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.92 KB, patch)
2022-06-27 15:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.18 KB, patch)
2022-06-27 15:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.68 KB, patch)
2022-06-27 15:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.19 KB, patch)
2022-06-27 15:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.76 KB, patch)
2022-06-27 15:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.74 KB, patch)
2022-06-27 15:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.01 KB, patch)
2022-06-27 15:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.17 KB, patch)
2022-06-27 15:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.23 KB, patch)
2022-06-27 15:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.71 KB, patch)
2022-06-27 15:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.32 KB, patch)
2022-06-27 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.47 KB, patch)
2022-06-27 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.26 KB, patch)
2022-06-27 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.54 KB, patch)
2022-06-27 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (3.82 KB, patch)
2022-06-27 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 (913 bytes, patch)
2022-06-27 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for Koha::Item additions (8.43 KB, patch)
2022-06-27 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for AddReturn addition (1.50 KB, patch)
2022-06-27 15:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit tests - chargelostitem (3.62 KB, patch)
2022-06-27 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add default AV and Syspref values (2.62 KB, patch)
2022-06-27 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Translations fixes (15.10 KB, patch)
2022-06-27 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Rename column configuration to barcode (824 bytes, patch)
2022-06-27 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Move preferences to "Item bundles" (2.85 KB, patch)
2022-06-27 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Fix typo in templates and test plan (1.96 KB, patch)
2022-06-27 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Improve error for item not found (2.23 KB, patch)
2022-06-27 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items (1.31 KB, patch)
2022-06-27 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Disable bundle editing for checked out (5.09 KB, patch)
2022-06-27 15:43 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link bundle items to thier biblios (5.23 KB, patch)
2022-06-27 15:43 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore last seen date formatting (1.63 KB, patch)
2022-06-27 15:43 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Expand itemtype [WIP] (3.99 KB, patch)
2022-06-27 15:43 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add bundle item status to manage button (2.04 KB, patch)
2022-06-27 15:43 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' (2.20 KB, patch)
2022-06-27 15:43 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore block styling on bundled span (1.13 KB, patch)
2022-06-27 15:43 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link to 'In bundle' on OPAC (2.02 KB, patch)
2022-06-27 15:43 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add handling for part_numbers/names (5.43 KB, patch)
2022-06-27 15:44 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Prevent stringification of null in return claims (1.84 KB, patch)
2022-06-27 16:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Reload return claims table on resolve (1.51 KB, patch)
2022-06-27 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Add missing TT filters (1.13 KB, patch)
2022-07-01 11:38 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Database update (4.03 KB, patch)
2022-07-01 12:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.78 KB, patch)
2022-07-01 12:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.88 KB, patch)
2022-07-01 12:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.79 KB, patch)
2022-07-01 12:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.73 KB, patch)
2022-07-01 12:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.92 KB, patch)
2022-07-01 12:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.18 KB, patch)
2022-07-01 12:07 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.68 KB, patch)
2022-07-01 12:07 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.19 KB, patch)
2022-07-01 12:07 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.76 KB, patch)
2022-07-01 12:07 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.74 KB, patch)
2022-07-01 12:07 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.01 KB, patch)
2022-07-01 12:07 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.17 KB, patch)
2022-07-01 12:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.23 KB, patch)
2022-07-01 12:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.71 KB, patch)
2022-07-01 12:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.32 KB, patch)
2022-07-01 12:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.47 KB, patch)
2022-07-01 12:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.26 KB, patch)
2022-07-01 12:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.54 KB, patch)
2022-07-01 12:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (3.82 KB, patch)
2022-07-01 12:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 (913 bytes, patch)
2022-07-01 12:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for Koha::Item additions (8.43 KB, patch)
2022-07-01 12:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for AddReturn addition (1.50 KB, patch)
2022-07-01 12:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit tests - chargelostitem (3.62 KB, patch)
2022-07-01 12:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add default AV and Syspref values (2.62 KB, patch)
2022-07-01 12:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Translations fixes (15.10 KB, patch)
2022-07-01 12:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Rename column configuration to barcode (824 bytes, patch)
2022-07-01 12:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Move preferences to "Item bundles" (2.85 KB, patch)
2022-07-01 12:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Fix typo in templates and test plan (1.96 KB, patch)
2022-07-01 12:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Improve error for item not found (2.23 KB, patch)
2022-07-01 12:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items (1.31 KB, patch)
2022-07-01 12:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Disable bundle editing for checked out (5.09 KB, patch)
2022-07-01 12:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link bundle items to thier biblios (5.23 KB, patch)
2022-07-01 12:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore last seen date formatting (1.63 KB, patch)
2022-07-01 12:10 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add bundle item status to manage button (2.04 KB, patch)
2022-07-01 12:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' (2.20 KB, patch)
2022-07-01 12:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore block styling on bundled span (1.13 KB, patch)
2022-07-01 12:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link to 'In bundle' on OPAC (2.02 KB, patch)
2022-07-01 12:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add handling for part_numbers/names (5.46 KB, patch)
2022-07-01 12:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Prevent stringification of null in return claims (1.84 KB, patch)
2022-07-01 12:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Reload return claims table on resolve (1.51 KB, patch)
2022-07-01 12:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Add missing TT filters (1.13 KB, patch)
2022-07-01 12:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Remove fields from from bundle items (2.79 KB, patch)
2022-07-01 12:12 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.09 KB, patch)
2022-07-01 13:49 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.84 KB, patch)
2022-07-01 13:49 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.94 KB, patch)
2022-07-01 13:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.85 KB, patch)
2022-07-01 13:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.78 KB, patch)
2022-07-01 13:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.98 KB, patch)
2022-07-01 13:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.24 KB, patch)
2022-07-01 13:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.74 KB, patch)
2022-07-01 13:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.24 KB, patch)
2022-07-01 13:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.82 KB, patch)
2022-07-01 13:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.80 KB, patch)
2022-07-01 13:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.07 KB, patch)
2022-07-01 13:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.23 KB, patch)
2022-07-01 13:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.29 KB, patch)
2022-07-01 13:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.76 KB, patch)
2022-07-01 13:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.38 KB, patch)
2022-07-01 13:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.53 KB, patch)
2022-07-01 13:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.32 KB, patch)
2022-07-01 13:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.59 KB, patch)
2022-07-01 13:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (3.88 KB, patch)
2022-07-01 13:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 (970 bytes, patch)
2022-07-01 13:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Unit test for Koha::Item additions (8.49 KB, patch)
2022-07-01 13:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Unit test for AddReturn addition (1.56 KB, patch)
2022-07-01 13:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Unit tests - chargelostitem (3.68 KB, patch)
2022-07-01 13:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: Add default AV and Syspref values (2.68 KB, patch)
2022-07-01 13:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Translations fixes (15.16 KB, patch)
2022-07-01 13:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Rename column configuration to barcode (882 bytes, patch)
2022-07-01 13:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Move preferences to "Item bundles" (2.90 KB, patch)
2022-07-01 13:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Fix typo in templates and test plan (2.02 KB, patch)
2022-07-01 13:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Improve error for item not found (2.29 KB, patch)
2022-07-01 13:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items (1.36 KB, patch)
2022-07-01 13:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Disable bundle editing for checked out (5.15 KB, patch)
2022-07-01 13:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link bundle items to thier biblios (5.29 KB, patch)
2022-07-01 13:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore last seen date formatting (1.69 KB, patch)
2022-07-01 13:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add bundle item status to manage button (2.10 KB, patch)
2022-07-01 13:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' (2.26 KB, patch)
2022-07-01 13:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore block styling on bundled span (1.19 KB, patch)
2022-07-01 13:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link to 'In bundle' on OPAC (2.08 KB, patch)
2022-07-01 13:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add handling for part_numbers/names (5.51 KB, patch)
2022-07-01 13:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Prevent stringification of null in return claims (1.89 KB, patch)
2022-07-01 13:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Reload return claims table on resolve (1.57 KB, patch)
2022-07-01 13:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Add missing TT filters (1.19 KB, patch)
2022-07-01 13:56 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Remove fields from from bundle items (2.85 KB, patch)
2022-07-01 13:56 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28854: (follow-up) Prevent bundles from being nested (4.82 KB, patch)
2022-07-01 14:17 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.09 KB, patch)
2022-07-01 14:52 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.84 KB, patch)
2022-07-01 14:52 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.94 KB, patch)
2022-07-01 14:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.85 KB, patch)
2022-07-01 14:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.78 KB, patch)
2022-07-01 14:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.98 KB, patch)
2022-07-01 14:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.24 KB, patch)
2022-07-01 14:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.74 KB, patch)
2022-07-01 14:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.24 KB, patch)
2022-07-01 14:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.82 KB, patch)
2022-07-01 14:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.80 KB, patch)
2022-07-01 14:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.07 KB, patch)
2022-07-01 14:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.23 KB, patch)
2022-07-01 14:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.29 KB, patch)
2022-07-01 14:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.76 KB, patch)
2022-07-01 14:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.38 KB, patch)
2022-07-01 14:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.53 KB, patch)
2022-07-01 14:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.32 KB, patch)
2022-07-01 14:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.59 KB, patch)
2022-07-01 14:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (3.88 KB, patch)
2022-07-01 14:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 (970 bytes, patch)
2022-07-01 14:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for Koha::Item additions (8.49 KB, patch)
2022-07-01 14:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for AddReturn addition (1.56 KB, patch)
2022-07-01 14:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit tests - chargelostitem (3.68 KB, patch)
2022-07-01 14:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add default AV and Syspref values (2.68 KB, patch)
2022-07-01 14:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Translations fixes (15.16 KB, patch)
2022-07-01 14:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Rename column configuration to barcode (882 bytes, patch)
2022-07-01 14:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Move preferences to "Item bundles" (2.90 KB, patch)
2022-07-01 14:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Fix typo in templates and test plan (2.02 KB, patch)
2022-07-01 14:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Improve error for item not found (2.29 KB, patch)
2022-07-01 14:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items (1.36 KB, patch)
2022-07-01 14:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Disable bundle editing for checked out (5.15 KB, patch)
2022-07-01 14:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link bundle items to thier biblios (5.29 KB, patch)
2022-07-01 14:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore last seen date formatting (1.69 KB, patch)
2022-07-01 14:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add bundle item status to manage button (2.10 KB, patch)
2022-07-01 14:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' (2.26 KB, patch)
2022-07-01 14:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore block styling on bundled span (1.19 KB, patch)
2022-07-01 14:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link to 'In bundle' on OPAC (2.08 KB, patch)
2022-07-01 14:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add handling for part_numbers/names (5.51 KB, patch)
2022-07-01 14:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Add missing TT filters (1.19 KB, patch)
2022-07-01 14:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Remove fields from from bundle items (2.85 KB, patch)
2022-07-01 14:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.09 KB, patch)
2022-07-11 07:00 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.39 KB, patch)
2022-07-11 07:00 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (36.95 KB, patch)
2022-07-11 07:00 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.85 KB, patch)
2022-07-11 07:00 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.78 KB, patch)
2022-07-11 07:00 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (1.98 KB, patch)
2022-07-11 07:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.24 KB, patch)
2022-07-11 07:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.70 KB, patch)
2022-07-11 07:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.24 KB, patch)
2022-07-11 07:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.82 KB, patch)
2022-07-11 07:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.80 KB, patch)
2022-07-11 07:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.07 KB, patch)
2022-07-11 07:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.23 KB, patch)
2022-07-11 07:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.29 KB, patch)
2022-07-11 07:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.76 KB, patch)
2022-07-11 07:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.37 KB, patch)
2022-07-11 07:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.53 KB, patch)
2022-07-11 07:02 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.32 KB, patch)
2022-07-11 07:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.59 KB, patch)
2022-07-11 07:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (3.88 KB, patch)
2022-07-11 07:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 (970 bytes, patch)
2022-07-11 07:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for Koha::Item additions (8.49 KB, patch)
2022-07-11 07:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit test for AddReturn addition (1.56 KB, patch)
2022-07-11 07:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Unit tests - chargelostitem (3.68 KB, patch)
2022-07-11 07:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Add default AV and Syspref values (2.68 KB, patch)
2022-07-11 07:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Translations fixes (15.16 KB, patch)
2022-07-11 07:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Rename column configuration to barcode (882 bytes, patch)
2022-07-11 07:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Move preferences to "Item bundles" (2.90 KB, patch)
2022-07-11 07:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Fix typo in templates and test plan (1.59 KB, patch)
2022-07-11 07:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Improve error for item not found (2.29 KB, patch)
2022-07-11 07:05 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items (1.36 KB, patch)
2022-07-11 07:05 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Disable bundle editing for checked out (5.15 KB, patch)
2022-07-11 07:05 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link bundle items to thier biblios (5.29 KB, patch)
2022-07-11 07:05 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore last seen date formatting (1.69 KB, patch)
2022-07-11 07:05 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add bundle item status to manage button (2.10 KB, patch)
2022-07-11 07:05 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' (2.26 KB, patch)
2022-07-11 07:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore block styling on bundled span (1.19 KB, patch)
2022-07-11 07:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link to 'In bundle' on OPAC (2.08 KB, patch)
2022-07-11 07:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add handling for part_numbers/names (5.51 KB, patch)
2022-07-11 07:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Add missing TT filters (1.19 KB, patch)
2022-07-11 07:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Remove fields from from bundle items (2.85 KB, patch)
2022-07-11 07:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Squashed Patch Set for Reading (116.45 KB, patch)
2022-07-11 11:17 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) (664 bytes, patch)
2022-07-11 12:31 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Remove duplicate key test (2.11 KB, patch)
2022-07-11 15:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix DB revision for AV's above 10 (1.65 KB, patch)
2022-07-11 15:19 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: Database update (4.15 KB, patch)
2022-07-11 15:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: DBIC Schema Updates (3.45 KB, patch)
2022-07-11 15:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Expose functionality to attach items to bundles (37.02 KB, patch)
2022-07-11 15:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Update circulation functionality for bundles (23.92 KB, patch)
2022-07-11 15:55 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Highlight bundle rows to clarify UI (1.84 KB, patch)
2022-07-11 15:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Drop unique index on issue_id in return claims (2.04 KB, patch)
2022-07-11 15:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: DBIC Update ReturnClaim Schema (1.29 KB, patch)
2022-07-11 15:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Record and display who lost the item (16.77 KB, patch)
2022-07-11 15:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Simplified status handling for bundle inventory check (6.30 KB, patch)
2022-07-11 15:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Add option to print content list after verification (1.88 KB, patch)
2022-07-11 15:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Add ordering to checkin validation modal (1.86 KB, patch)
2022-07-11 15:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Improve lost details display for bundle items (6.13 KB, patch)
2022-07-11 15:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Enable claims return view when BundleLostValue is set (3.29 KB, patch)
2022-07-11 15:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Highlight when a scanned item is unexpected (3.34 KB, patch)
2022-07-11 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Add count of scanned items to verification modal (2.82 KB, patch)
2022-07-11 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Add 'Remove from bundle' dialogue to details display (12.43 KB, patch)
2022-07-11 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Add modal after checkin to print missing items list (7.59 KB, patch)
2022-07-11 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Only count rows in the body (1.37 KB, patch)
2022-07-11 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Make barcode comparison case insensative (1.65 KB, patch)
2022-07-11 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix QA tool complaints (3.94 KB, patch)
2022-07-11 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 (1.00 KB, patch)
2022-07-11 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Unit test for Koha::Item additions (8.55 KB, patch)
2022-07-11 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Unit test for AddReturn addition (1.61 KB, patch)
2022-07-11 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Unit tests - chargelostitem (3.74 KB, patch)
2022-07-11 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: Add default AV and Syspref values (2.74 KB, patch)
2022-07-11 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Translations fixes (15.22 KB, patch)
2022-07-11 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Rename column configuration to barcode (940 bytes, patch)
2022-07-11 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Move preferences to "Item bundles" (2.96 KB, patch)
2022-07-11 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Fix typo in templates and test plan (1.65 KB, patch)
2022-07-11 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Improve error for item not found (2.35 KB, patch)
2022-07-11 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items (1.42 KB, patch)
2022-07-11 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Disable bundle editing for checked out (5.20 KB, patch)
2022-07-11 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link bundle items to thier biblios (5.34 KB, patch)
2022-07-11 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore last seen date formatting (1.75 KB, patch)
2022-07-11 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add bundle item status to manage button (2.16 KB, patch)
2022-07-11 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' (2.32 KB, patch)
2022-07-11 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Restore block styling on bundled span (1.24 KB, patch)
2022-07-11 16:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Link to 'In bundle' on OPAC (2.14 KB, patch)
2022-07-11 16:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Add handling for part_numbers/names (5.57 KB, patch)
2022-07-11 16:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Add missing TT filters (1.25 KB, patch)
2022-07-11 16:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Remove fields from from bundle items (2.91 KB, patch)
2022-07-11 16:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) (719 bytes, patch)
2022-07-11 16:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Remove duplicate key test (2.17 KB, patch)
2022-07-11 16:03 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (QA follow-up) Fix DB revision for AV's above 10 (1.71 KB, patch)
2022-07-11 16:03 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28854: (follow-up) Replace unique constraint in return claims (2.25 KB, patch)
2022-07-13 17:17 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Replace unique constraint in return claims (2.42 KB, patch)
2022-07-13 17:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28854: (follow-up) Remove errant warning (1.03 KB, patch)
2022-08-18 08:45 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2021-08-13 09:41:34 UTC
+++ This bug was initially created as a clone of Bug #24023 +++

This bug started as a rebase of bug 24023, but as time went on and I tested that bug I found bits of it lacking and felt enough time had passed that we could try a more modern approach.

To keep the work distinct, I created this bug to encompass my alternative approach.

This new feature will add the ability to bundle existing items together into loanable sets linked to a new collection bibliographic record.  Items will be withdrawn from their original bib and take on the circulation rules of the collection record.

We update the display for items attached to a collection to show what collection they are linked to and we added the ability to expand a collection item to list it's content items.
Comment 1 Martin Renvoize 2021-08-17 16:06:06 UTC
See branch for work in progress: https://gitlab.com/mrenvoize/Koha/-/commits/bug_28854
Comment 2 Martin Renvoize 2021-09-01 10:54:49 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2021-09-01 10:56:28 UTC
I wanted to start getting feedback for this so have uploaded a patch for testing.

It includes a basic test plan, but I'm sure I've missed some area's :( so would appreciate feedback.

I also realise it still needs unit tests adding for the various object methods introduced before it'll go through QA.
Comment 4 Martin Renvoize 2021-09-03 15:50:40 UTC Comment hidden (obsolete)
Comment 5 Martin Renvoize 2021-09-07 14:21:12 UTC
Created attachment 124616 [details] [review]
Bug 28854: Add ability to create and circulate item bundles

This patch adds the ability to attach item bundles to biblio records. Item
bundles can then be circulated as with normal items.

Upon attaching an item to one of these item bundles, the item is automatically
marked as not for loan at it's original host biblio record.

When returning a bundle, the list of items that are part of this bundle
will be displayed, and a verification form is exposed requireing the
librarian to scan item barcodes to verify their presence. Should a bundle
be found to have items missing they will be marked as lost.

Bundles can also be used in the inventory tool as a filter.

Test plan:
0.  Apply the patch, run updatedatabase + update_dbix_class_files
1.  Create a new bundle record.
1a. Create a biblio record with leader position 7 set to 'c' for collection.
1b. Create an item for this biblio record.
1c. You should now see a new 'Bundle' button next to the item in the holdings
    table.
    Test: Verify that this 'Bundle' button only appears for biblio's where leader
    position 7 is not 'c' for collection
1d. Use the new 'Bundle' button to trigger a modal allowing you to attach items
    to the bundle.
    Test: Enter a non-existant barcode, submit and confirm you recieve an error message.
    Test: Enter an existing barcode, submit and note the success message.
    Test: Enter the same barcode as above, submit and note the warning message.
    Test: Add a second item to the bib and try bundling one of the above
    items into this second item, note the error message.
2.  Open a new tab and look at the holdings data for one of the items you attached
    to a bundle in step 1.
    Test: Verify that the holdings status displays 'Not for loan'.
    Test: Verify that the holdings status show which bundle the item has been
    attached to.
3.  Perform a checkout on the first bundle item.
    Test: Checkout should proceed as normal, obeying the circulation
    rules for the item type you chose to convert into a bundle.
4.  Perform a checkin on the first bundle item.
    Test: You should be presented with a modal that contains a list of items
    contained in the bundle and a test box for entering item barcodes.
    Test: Enter some of the barcodes for items in the bundle into the box and submit.
    The bundle item should have been marked as returned, you should also
    have been notified of missing items and have the ability to print an
    updated contents list.
    Test: Verify that the items you did not enter barcodes for are now
    marked as lost.
Comment 6 Julian Maurice 2021-09-20 09:15:08 UTC
Looking good so far :)
I've followed the test plan and everything works as expected.

There are some things that are in bug 24023 that are missing here, but they can be re-added on top of it later.

The big difference between both bugs is that, in bug 24023 the biblio record is the bundle (its item is only there for circulation), whereas in bug 28854 the item record is the bundle.
It means that you can do completely different bundles under the same name (the biblio title). Is that intended ?

About the UI, I find the "tables in table" idea confusing. There are just too much table controls in there :)
What do you think of moving the list of bundled items inside the popup that opens when you click on the "Bundle" button ?

qa tool reports a weird error:

 FAIL   Koha/Item/Bundle.pm                                                                                                                                                                                    
   FAIL   valid                                                                                                                                                                                                  
                Inconsistent hierarchy during C3 merge of class 'Koha::Item::Bundle':                                                                                                         
                        current merge results [                                                                                                                                                   
                                Koha::Item::Bundle,                                                                                                                                                   
                        ]                                                                        
                        merging failed on 'Koha::Item'
   
but it doesn't break koha, which is even more weird :)
Comment 7 Martin Renvoize 2021-09-23 14:40:14 UTC Comment hidden (obsolete)
Comment 8 Martin Renvoize 2021-09-23 14:40:19 UTC Comment hidden (obsolete)
Comment 9 Martin Renvoize 2021-09-23 14:40:24 UTC Comment hidden (obsolete)
Comment 10 Martin Renvoize 2021-09-23 14:40:28 UTC Comment hidden (obsolete)
Comment 11 Martin Renvoize 2021-09-23 14:40:35 UTC Comment hidden (obsolete)
Comment 12 Martin Renvoize 2021-09-23 14:40:42 UTC Comment hidden (obsolete)
Comment 13 Martin Renvoize 2021-09-23 14:40:47 UTC Comment hidden (obsolete)
Comment 14 Martin Renvoize 2021-09-30 07:09:41 UTC
(In reply to Julian Maurice from comment #6)
> Looking good so far :)
> I've followed the test plan and everything works as expected.

Thanks for testing and your comments Julian, very helpful.

In reverse order... 
* Weird, I didn't see that QA failure, but will look into it.. C3 Merge always confuses me when I see it.
* UI, I was thinking similar thoughts. I'm not sure whether to move it into the modal, or just try to somehow highlight the dropdown row background more to distinguish between the tables.  The customer I have suggested they would like to be able to expand multiple rows so they can see two bundles together.. but I do agree at the moment it's a bit confusing.
* Regarding the different level, I was also a bit confused by this. They are certainly keen to have it at the item level but I had thought it would be 'pick list at the biblio level' and then create bundles from that pick list at the item level.  The didn't want the pick list at all?!  I still temped to make that an option, allowing bib->bib constructs at the bib level and then when adding a bundle at the item level displaying the pick list of linked bibs for one to go and build the bundle up from the shelves.  The main thing that I struggled with was finding a sensible marc field.
* I'm aware the inventory side of this is missing and intend to do that in the next bug (It was already getting big here so I was trying to be pragmatic.. are there any other functions I've missed.. more than happy to accommodate them).
Comment 15 Martin Renvoize 2021-10-12 15:51:21 UTC Comment hidden (obsolete)
Comment 16 Martin Renvoize 2021-10-12 15:51:26 UTC Comment hidden (obsolete)
Comment 17 Martin Renvoize 2021-10-12 15:51:31 UTC Comment hidden (obsolete)
Comment 18 Martin Renvoize 2021-10-12 15:51:36 UTC Comment hidden (obsolete)
Comment 19 Martin Renvoize 2021-10-12 15:51:41 UTC Comment hidden (obsolete)
Comment 20 Martin Renvoize 2021-10-12 15:51:47 UTC Comment hidden (obsolete)
Comment 21 Martin Renvoize 2021-10-12 15:51:52 UTC Comment hidden (obsolete)
Comment 22 Martin Renvoize 2021-10-12 15:51:58 UTC Comment hidden (obsolete)
Comment 23 Martin Renvoize 2021-10-13 08:51:06 UTC Comment hidden (obsolete)
Comment 24 Martin Renvoize 2021-10-13 08:51:11 UTC Comment hidden (obsolete)
Comment 25 Martin Renvoize 2021-10-13 08:51:16 UTC Comment hidden (obsolete)
Comment 26 Martin Renvoize 2021-10-13 08:51:20 UTC Comment hidden (obsolete)
Comment 27 Martin Renvoize 2021-10-13 08:51:25 UTC Comment hidden (obsolete)
Comment 28 Martin Renvoize 2021-10-13 08:51:32 UTC Comment hidden (obsolete)
Comment 29 Martin Renvoize 2021-10-13 08:51:40 UTC Comment hidden (obsolete)
Comment 30 Martin Renvoize 2021-10-13 08:51:46 UTC Comment hidden (obsolete)
Comment 31 Martin Renvoize 2021-10-13 09:55:55 UTC Comment hidden (obsolete)
Comment 32 Martin Renvoize 2021-10-13 09:56:00 UTC Comment hidden (obsolete)
Comment 33 Martin Renvoize 2021-10-13 09:56:06 UTC Comment hidden (obsolete)
Comment 34 Martin Renvoize 2021-10-13 09:56:11 UTC Comment hidden (obsolete)
Comment 35 Martin Renvoize 2021-10-13 09:56:16 UTC Comment hidden (obsolete)
Comment 36 Martin Renvoize 2021-10-13 09:56:23 UTC Comment hidden (obsolete)
Comment 37 Martin Renvoize 2021-10-13 09:56:29 UTC Comment hidden (obsolete)
Comment 38 Martin Renvoize 2021-10-13 09:56:35 UTC Comment hidden (obsolete)
Comment 39 Martin Renvoize 2021-11-10 08:55:10 UTC Comment hidden (obsolete)
Comment 40 Martin Renvoize 2021-11-10 08:55:16 UTC Comment hidden (obsolete)
Comment 41 Martin Renvoize 2021-11-10 08:55:21 UTC Comment hidden (obsolete)
Comment 42 Martin Renvoize 2021-11-10 08:55:26 UTC Comment hidden (obsolete)
Comment 43 Martin Renvoize 2021-11-10 08:55:31 UTC Comment hidden (obsolete)
Comment 44 Martin Renvoize 2021-11-10 08:55:36 UTC Comment hidden (obsolete)
Comment 45 Martin Renvoize 2021-11-10 08:55:40 UTC Comment hidden (obsolete)
Comment 46 Martin Renvoize 2021-11-10 08:55:45 UTC Comment hidden (obsolete)
Comment 47 Martin Renvoize 2021-11-15 16:45:27 UTC Comment hidden (obsolete)
Comment 48 Martin Renvoize 2021-11-15 16:45:32 UTC Comment hidden (obsolete)
Comment 49 Martin Renvoize 2021-11-15 16:45:37 UTC Comment hidden (obsolete)
Comment 50 Martin Renvoize 2021-11-15 16:45:42 UTC Comment hidden (obsolete)
Comment 51 Martin Renvoize 2021-11-15 16:45:47 UTC Comment hidden (obsolete)
Comment 52 Martin Renvoize 2021-11-15 16:45:52 UTC Comment hidden (obsolete)
Comment 53 Martin Renvoize 2021-11-15 16:45:57 UTC Comment hidden (obsolete)
Comment 54 Martin Renvoize 2021-11-15 16:46:02 UTC Comment hidden (obsolete)
Comment 55 Martin Renvoize 2021-11-15 16:47:55 UTC
Just another rebase
Comment 56 Martin Renvoize 2021-11-19 08:01:50 UTC Comment hidden (obsolete)
Comment 57 Martin Renvoize 2021-11-19 08:01:55 UTC Comment hidden (obsolete)
Comment 58 Martin Renvoize 2021-11-19 08:02:00 UTC Comment hidden (obsolete)
Comment 59 Martin Renvoize 2021-11-19 08:02:05 UTC Comment hidden (obsolete)
Comment 60 Martin Renvoize 2021-11-19 08:02:10 UTC Comment hidden (obsolete)
Comment 61 Martin Renvoize 2021-11-19 08:02:15 UTC Comment hidden (obsolete)
Comment 62 Martin Renvoize 2021-11-19 08:02:20 UTC Comment hidden (obsolete)
Comment 63 Martin Renvoize 2021-11-19 08:02:25 UTC Comment hidden (obsolete)
Comment 64 Martin Renvoize 2021-11-19 08:02:30 UTC Comment hidden (obsolete)
Comment 65 Martin Renvoize 2021-11-19 08:02:34 UTC Comment hidden (obsolete)
Comment 66 Martin Renvoize 2021-11-25 14:49:03 UTC
Please see the linked branch/merge request on gitlab for the patchset.. uploading rebases here was getting a bit obscene.
Comment 67 Martin Renvoize 2022-02-08 16:52:38 UTC
Created attachment 130313 [details] [review]
Bug 28854: Database update
Comment 68 Martin Renvoize 2022-02-08 16:52:44 UTC
Created attachment 130314 [details] [review]
Bug 28854: DBIC Schema Updates
Comment 69 Martin Renvoize 2022-02-08 16:52:51 UTC
Created attachment 130315 [details] [review]
Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point and run the database update
1) Configuration: `BundleNotLoanValue` should have been set by the
   database update and point to a newly added AV value.
2) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
3) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
4) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.
5) The bundles feature can be disabled by unsetting the
   `BundleNotLoanValue` system preference.

TODO: Add Object Tests + API Tests
Comment 70 Martin Renvoize 2022-02-08 16:52:57 UTC
Created attachment 130316 [details] [review]
Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.
Comment 71 Martin Renvoize 2022-02-08 16:53:07 UTC
Created attachment 130317 [details] [review]
Bug 28854: Highlight bundle rows to clarify UI
Comment 72 Martin Renvoize 2022-02-08 16:53:16 UTC
Created attachment 130318 [details] [review]
Bug 28854: Drop unique index on issue_id in return claims

With the introduction of circulating items within a bundle set, we can
now loose multiple items from the bundle from the same issue.
Comment 73 Martin Renvoize 2022-02-08 16:53:22 UTC
Created attachment 130319 [details] [review]
Bug 28854: DBIC Update ReturnClaim Schema
Comment 74 Martin Renvoize 2022-02-08 16:53:28 UTC
Created attachment 130320 [details] [review]
Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that it is marked
   as lost.
4) Navigate to the biblio for the collection and expand the collection
   item that contains the lost item. Note the item is marked as lost and
   checkout details are listed.
5) Checkin the lost item
   * The item should be marked as found and the return_claims line should
   be marked as resolved.
Comment 75 Martin Renvoize 2022-02-08 16:53:34 UTC
Created attachment 130321 [details] [review]
Bug 28854: Simplified status handling for bundle inventory check
Comment 76 Martin Renvoize 2022-02-08 16:53:41 UTC
Created attachment 130322 [details] [review]
Bug 28854: Add option to print content list after verification

We already allowed the user to view and print an updated content list
after a varification showed that items were missing from the bundle.
This patch adds the option to view and print the list even if the
content has been varified to have not changed.
Comment 77 Martin Renvoize 2022-02-08 16:53:50 UTC
Created attachment 130323 [details] [review]
Bug 28854: Add ordering to checkin validation modal

This enhancement adds simple dataTable ordering to the verification
modal table at bundle checkin time.
Comment 78 Martin Renvoize 2022-02-08 16:53:59 UTC
Created attachment 130324 [details] [review]
Bug 28854: Improve lost details display for bundle items

This patch adds the return claim details to the bundle item status
display on the catalogue details page.

Test plan
Comment 79 Martin Renvoize 2022-02-08 16:54:05 UTC
Created attachment 130325 [details] [review]
Bug 28854: Enable claims return view when BundleLostValue is set

This patch adds the alternation of BundleLostValue to enable the return
claims functionality when Bundles are enbled.
Comment 80 Martin Renvoize 2022-02-08 16:54:11 UTC
Created attachment 130326 [details] [review]
Bug 28854: Highlight when a scanned item is unexpected
Comment 81 Martin Renvoize 2022-02-08 16:54:17 UTC
Created attachment 130327 [details] [review]
Bug 28854: Add count of scanned items to verification modal
Comment 82 Martin Renvoize 2022-02-08 16:54:23 UTC
Created attachment 130328 [details] [review]
Bug 28854: Add 'Remove from bundle' dialogue to details display

This patch adds the counterpart of the 'Add to bundle' modal prompt for
adding items to bundles from the catalogue details display.  It allows
for scanning barcodes to remove them from a bundle.
Comment 83 Martin Renvoize 2022-02-08 16:54:28 UTC
Created attachment 130329 [details] [review]
Bug 28854: Add modal after checkin to print missing items list

This patch adds a further modal to the post checkin alert to allow the
user to print a view and print a list of items that went missing at this
checkin to allow for replacements to be picked.
Comment 84 Martin Renvoize 2022-02-08 16:54:34 UTC
Created attachment 130330 [details] [review]
Bug 28854: (follow-up) Only count rows in the body

This patch fixes the count to only include table rows in the body, i.e.
skip the header row.
Comment 85 Martin Renvoize 2022-02-08 16:54:40 UTC
Created attachment 130331 [details] [review]
Bug 28854: Make barcode comparison case insensative
Comment 86 Martin Renvoize 2022-02-08 16:54:46 UTC
Created attachment 130332 [details] [review]
Bug 28854: (follow-up) Fix rebase re-indroduction of .json

The API schema's all changed to .yaml but a rebase here re-introduced
the .json links
Comment 87 Martin Renvoize 2022-02-08 17:09:43 UTC
We wrote some documentation for this, but bugzilla doesn't want to allow me to attach it..
Comment 88 Martin Renvoize 2022-02-10 16:50:11 UTC
Created attachment 130456 [details]
Documentation
Comment 89 David Nind 2022-02-10 17:43:05 UTC
Thanks Martin for creating the documentation!

I will have a go at testing over the weekend, unless someone beats me to it!
Comment 90 Julian Maurice 2022-03-31 12:06:21 UTC Comment hidden (obsolete)
Comment 91 Julian Maurice 2022-03-31 12:06:40 UTC Comment hidden (obsolete)
Comment 92 Julian Maurice 2022-03-31 12:06:51 UTC Comment hidden (obsolete)
Comment 93 Julian Maurice 2022-03-31 12:07:14 UTC Comment hidden (obsolete)
Comment 94 Julian Maurice 2022-03-31 12:07:30 UTC Comment hidden (obsolete)
Comment 95 Julian Maurice 2022-03-31 12:07:37 UTC Comment hidden (obsolete)
Comment 96 Julian Maurice 2022-03-31 12:07:50 UTC Comment hidden (obsolete)
Comment 97 Julian Maurice 2022-03-31 12:08:00 UTC Comment hidden (obsolete)
Comment 98 Julian Maurice 2022-03-31 12:08:09 UTC Comment hidden (obsolete)
Comment 99 Julian Maurice 2022-03-31 12:08:19 UTC Comment hidden (obsolete)
Comment 100 Julian Maurice 2022-03-31 12:08:31 UTC Comment hidden (obsolete)
Comment 101 Julian Maurice 2022-03-31 12:08:47 UTC Comment hidden (obsolete)
Comment 102 Julian Maurice 2022-03-31 12:09:01 UTC Comment hidden (obsolete)
Comment 103 Julian Maurice 2022-03-31 12:09:11 UTC Comment hidden (obsolete)
Comment 104 Julian Maurice 2022-03-31 12:09:25 UTC Comment hidden (obsolete)
Comment 105 Julian Maurice 2022-03-31 12:09:37 UTC Comment hidden (obsolete)
Comment 106 Julian Maurice 2022-03-31 12:09:54 UTC Comment hidden (obsolete)
Comment 107 Julian Maurice 2022-03-31 12:10:00 UTC Comment hidden (obsolete)
Comment 108 Julian Maurice 2022-03-31 12:10:11 UTC Comment hidden (obsolete)
Comment 109 Julian Maurice 2022-03-31 12:10:21 UTC Comment hidden (obsolete)
Comment 110 Julian Maurice 2022-03-31 12:10:35 UTC Comment hidden (obsolete)
Comment 111 Julian Maurice 2022-03-31 12:28:52 UTC
All patches rebased on master + a tiny fix for the name of the atomicupdate file
Comment 112 Martin Renvoize 2022-05-16 14:22:21 UTC Comment hidden (obsolete)
Comment 113 Martin Renvoize 2022-05-16 14:22:28 UTC Comment hidden (obsolete)
Comment 114 Martin Renvoize 2022-05-16 14:22:35 UTC Comment hidden (obsolete)
Comment 115 Martin Renvoize 2022-05-16 14:22:42 UTC Comment hidden (obsolete)
Comment 116 Martin Renvoize 2022-05-16 14:22:50 UTC Comment hidden (obsolete)
Comment 117 Martin Renvoize 2022-05-16 14:22:56 UTC Comment hidden (obsolete)
Comment 118 Martin Renvoize 2022-05-16 14:23:04 UTC Comment hidden (obsolete)
Comment 119 Martin Renvoize 2022-05-16 14:23:11 UTC Comment hidden (obsolete)
Comment 120 Martin Renvoize 2022-05-16 14:23:18 UTC Comment hidden (obsolete)
Comment 121 Martin Renvoize 2022-05-16 14:23:25 UTC Comment hidden (obsolete)
Comment 122 Martin Renvoize 2022-05-16 14:23:34 UTC Comment hidden (obsolete)
Comment 123 Martin Renvoize 2022-05-16 14:23:42 UTC Comment hidden (obsolete)
Comment 124 Martin Renvoize 2022-05-16 14:23:52 UTC Comment hidden (obsolete)
Comment 125 Martin Renvoize 2022-05-16 14:24:05 UTC Comment hidden (obsolete)
Comment 126 Martin Renvoize 2022-05-16 14:24:12 UTC Comment hidden (obsolete)
Comment 127 Martin Renvoize 2022-05-16 14:24:21 UTC Comment hidden (obsolete)
Comment 128 Martin Renvoize 2022-05-16 14:24:29 UTC Comment hidden (obsolete)
Comment 129 Martin Renvoize 2022-05-16 14:24:38 UTC Comment hidden (obsolete)
Comment 130 Martin Renvoize 2022-05-16 14:24:46 UTC Comment hidden (obsolete)
Comment 131 Martin Renvoize 2022-05-16 14:27:23 UTC
Another rebase after testing and finding some subtle issues with the last rebase.

All seems to be working as expected now for me... ready for testing.

I've squashed Julians two follow-ups, and my own rebase fixes all into the original patchset.. it was getting hard to track it all ;)
Comment 132 Martin Renvoize 2022-05-16 14:28:46 UTC Comment hidden (obsolete)
Comment 133 Owen Leonard 2022-05-20 21:16:23 UTC
This looks like it's working pretty well in the staff interface. Is there a plan to make the contents of bundles visible in the OPAC?
Comment 134 Martin Renvoize 2022-05-21 06:08:34 UTC
Good question Owen, the original sponsor for this has moved in now, but they weren't sure how they wanted things to display in the OPAC so in the end I dropped those patches from here.

Biblibre used MARC linking in their original implementation and there's a bug followup submitted on this tree that allows for that too, optionally; That would allow for the display of a contents list at the bib level in effect then the box items just appear as usual.. so you get the contents list from the bib rather than having the specifics of each box (this obviously assumes each box attached to the bib is intended to include the same set of materials )

Alternatively my original implementation gave the same row expansion type display as the staff client, but without the management options.  The original sponsor decided that felt confusing for the end user.

I'm happy to be guided and submit something either here or as another follow-up bug like I have for the Marc linking option. Do you have any thoughts?
Comment 135 Martin Renvoize 2022-06-17 08:46:32 UTC Comment hidden (obsolete)
Comment 136 Martin Renvoize 2022-06-17 08:46:37 UTC Comment hidden (obsolete)
Comment 137 Martin Renvoize 2022-06-17 08:46:43 UTC Comment hidden (obsolete)
Comment 138 Martin Renvoize 2022-06-17 08:46:50 UTC Comment hidden (obsolete)
Comment 139 Martin Renvoize 2022-06-17 08:46:55 UTC Comment hidden (obsolete)
Comment 140 Martin Renvoize 2022-06-17 08:47:01 UTC Comment hidden (obsolete)
Comment 141 Martin Renvoize 2022-06-17 08:47:07 UTC Comment hidden (obsolete)
Comment 142 Martin Renvoize 2022-06-17 08:47:14 UTC Comment hidden (obsolete)
Comment 143 Martin Renvoize 2022-06-17 08:47:24 UTC Comment hidden (obsolete)
Comment 144 Martin Renvoize 2022-06-17 08:47:30 UTC Comment hidden (obsolete)
Comment 145 Martin Renvoize 2022-06-17 08:47:36 UTC Comment hidden (obsolete)
Comment 146 Martin Renvoize 2022-06-17 08:47:42 UTC Comment hidden (obsolete)
Comment 147 Martin Renvoize 2022-06-17 08:47:48 UTC Comment hidden (obsolete)
Comment 148 Martin Renvoize 2022-06-17 08:47:54 UTC Comment hidden (obsolete)
Comment 149 Martin Renvoize 2022-06-17 08:48:00 UTC Comment hidden (obsolete)
Comment 150 Martin Renvoize 2022-06-17 08:48:06 UTC Comment hidden (obsolete)
Comment 151 Martin Renvoize 2022-06-17 08:48:12 UTC Comment hidden (obsolete)
Comment 152 Martin Renvoize 2022-06-17 08:48:18 UTC Comment hidden (obsolete)
Comment 153 Martin Renvoize 2022-06-17 08:48:24 UTC Comment hidden (obsolete)
Comment 154 Katrin Fischer 2022-06-17 09:34:00 UTC Comment hidden (obsolete)
Comment 155 Katrin Fischer 2022-06-17 10:03:34 UTC
Working on this one :)
Comment 156 Martin Renvoize 2022-06-17 11:20:43 UTC Comment hidden (obsolete)
Comment 157 Martin Renvoize 2022-06-17 11:25:23 UTC Comment hidden (obsolete)
Comment 158 Martin Renvoize 2022-06-17 13:39:57 UTC Comment hidden (obsolete)
Comment 159 Martin Renvoize 2022-06-17 13:40:05 UTC Comment hidden (obsolete)
Comment 160 Martin Renvoize 2022-06-17 13:40:12 UTC Comment hidden (obsolete)
Comment 161 Martin Renvoize 2022-06-17 13:40:19 UTC Comment hidden (obsolete)
Comment 162 Martin Renvoize 2022-06-17 13:40:26 UTC Comment hidden (obsolete)
Comment 163 Martin Renvoize 2022-06-17 13:40:32 UTC Comment hidden (obsolete)
Comment 164 Martin Renvoize 2022-06-17 13:40:39 UTC Comment hidden (obsolete)
Comment 165 Martin Renvoize 2022-06-17 13:40:45 UTC Comment hidden (obsolete)
Comment 166 Martin Renvoize 2022-06-17 13:40:52 UTC Comment hidden (obsolete)
Comment 167 Martin Renvoize 2022-06-17 13:40:58 UTC Comment hidden (obsolete)
Comment 168 Martin Renvoize 2022-06-17 13:41:05 UTC Comment hidden (obsolete)
Comment 169 Martin Renvoize 2022-06-17 13:41:11 UTC Comment hidden (obsolete)
Comment 170 Martin Renvoize 2022-06-17 13:41:18 UTC Comment hidden (obsolete)
Comment 171 Martin Renvoize 2022-06-17 13:41:24 UTC Comment hidden (obsolete)
Comment 172 Martin Renvoize 2022-06-17 13:41:31 UTC Comment hidden (obsolete)
Comment 173 Martin Renvoize 2022-06-17 13:41:37 UTC Comment hidden (obsolete)
Comment 174 Martin Renvoize 2022-06-17 13:41:44 UTC Comment hidden (obsolete)
Comment 175 Martin Renvoize 2022-06-17 13:41:50 UTC Comment hidden (obsolete)
Comment 176 Martin Renvoize 2022-06-17 13:41:57 UTC Comment hidden (obsolete)
Comment 177 Martin Renvoize 2022-06-17 13:42:04 UTC Comment hidden (obsolete)
Comment 178 Martin Renvoize 2022-06-17 13:42:10 UTC Comment hidden (obsolete)
Comment 179 Martin Renvoize 2022-06-17 13:42:17 UTC Comment hidden (obsolete)
Comment 180 Martin Renvoize 2022-06-17 14:05:17 UTC Comment hidden (obsolete)
Comment 181 Katrin Fischer 2022-06-17 15:36:11 UTC
0) Documentation

Read the documentation, really helpful! (comment :) )

1) Unit tests (question)

Unit tests pass. Changes marked with . have new unit tests added, but we might be missing some for the changes to checkout and holds? Hope I didn't miss them:

Koha/Item 
  checkout
.  return_claims (new)
.  return_claim (new)
  holds
.  bundle_items (new)
.  is_bundle (new)
.  bundle_host (new)
.  in_bundle (new)
.  add_to_bundle (new)
.  remove_from_bundle (new)
C4/Circulation 
.  AddReturn 


2) Database update, installer

a) The new table has the columns host and item, I was wondering if they should not have _id added to match conventions on the API etc. (question)

b) I like the 'trick' on adding the LOST and NOT_LOAN values. (comment)

c) installer/data/mysql/en/optional/auth_val.yml requires updating for the new system preference values (blocker)

d) Changes to sysprefs.sql are missing. We can use the values from d) to pre-set the preferences for new installations correctly. (blocker)


3) Translatability, spelling, terminology

a) detail.pl - buttons and other text in js (blocker)

bundle_toolbar.append('<a class="btn btn-default" data-toggle="modal" data-target="#addToBundleModal" data-item="' + itemnumber + '"><i class="fa fa-plus"></i> Add to bundle</a>');

bundle_toolbar.append('<a class="btn btn-default" data-toggle="modal" data-target="#removeFromBundleModal" data-item="' + itemnumber + '"><i class="fa fa-minus"></i> Remove from bundle</a>');

$('#addResult').replaceWith('<div id="addResult" class="alert alert-success">Success: Added '+barcode+'</div>');

$('#addResult').replaceWith('<div id="addResult" class="alert alert-warning">Warning: Item '+barcode+' already attached</div>');
} else {
$('#addResult').replaceWith('<div id="addResult" class="alert alert-danger">Failure: Item '+barcode+' belongs to another bundle</div>');
}
} else {
$('#addResult').replaceWith('<div id="addResult" class="alert alert-danger">Failure: Check the logs for details</div>');

b) detail.pl - JSON titles, this and following (blocker):
{
"data": "biblio.author",
"title": "Author",
"searchable": true,
"orderable": true,
},

c) detail.pl - Capitalization (blocker)
"title": "Item Type",

d) detail.pl - Terminology (blocker)
"title": "Collection code", should be just Collection

e) circ/returns.tt: Why the use of i18n here? (question)
<th>[% t('Title') | html %]</th> 
Isn't it the same as:
<th>Title</th> ?

Same here, .tt file with text inside a div element, should have been parsed the same without using t().
[% t('Scan all barcodes of items found in the items bundle. If any items are missing, they will be marked as lost') | html %]

And here:
<button type="submit" class="btn btn-default"><i class="fa fa-check"></i> [% t('Confirm checkin and mark missing items as lost') | html %]</button>


4) GUI - Configuration

a) In table configuration, there is one option named external_id - while this makes sense to the API, I think it's hard on users. Why not update to barcode instead? (normal)

b) The system preferences are currently spread on 2 different tabs (circulation and cataloguing). I think we should add a new sub heading 'Item bundles' to group them on the circulation tab instead. It will make setup smoother and I can imagine the section might grow in the future. (normal)


5) Permissions

a) Who should be able to create item bundles? At the moment anyone with catalogue permission should be able to. (question)


5) GUI - Functionality

a) As barcodes are unique, how could this happen? Should the message maybe be adjusted? (question)

$('#removeResult').replaceWith('<div id="removeResult" class="alert alert-danger">'+_("Failed: Barcode matched more than one item ")+barcode+'</div>');

More functionality testing to come.
Comment 182 Katrin Fischer 2022-06-17 15:44:12 UTC
1) Unit tests 

Update: we are only missing chargelostitem! (blocker)

Koha/Item 
.  return_claims (new)
.  return_claim (new)
.  holds (only a comment change)
.  bundle_items (new)
.  is_bundle (new)
.  bundle_host (new)
.  in_bundle (new)
.  add_to_bundle (new)
.  remove_from_bundle (new)
C4/Circulation 
.  AddReturn 
C4/Accounts 
  chargelostitem
Comment 183 Martin Renvoize 2022-06-20 09:07:43 UTC
Created attachment 136340 [details] [review]
Bug 28854: Unit tests - chargelostitem

This patch adds unit tests for the changes to chargelositem to ensure
bundle charging works as expected setting the correct issue_id.
Comment 184 Martin Renvoize 2022-06-20 09:20:00 UTC
(In reply to Katrin Fischer from comment #182)
> 1) Unit tests 
> 
> Update: we are only missing chargelostitem! (blocker)

Done and attached :)
Comment 185 Martin Renvoize 2022-06-20 09:20:22 UTC
Created attachment 136341 [details] [review]
Bug 28854: Add default AV and Syspref values

This patch adds the new AV and System Preferences to the installer.
Comment 186 Martin Renvoize 2022-06-20 09:21:28 UTC
(In reply to Katrin Fischer from comment #181)
> c) installer/data/mysql/en/optional/auth_val.yml requires updating for the
> new system preference values (blocker)
> 
> d) Changes to sysprefs.sql are missing. We can use the values from d) to
> pre-set the preferences for new installations correctly. (blocker)

Done and attached :)
Comment 187 Martin Renvoize 2022-06-20 10:16:12 UTC
Created attachment 136342 [details] [review]
Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.
Comment 188 Martin Renvoize 2022-06-20 10:17:36 UTC
(In reply to Katrin Fischer from comment #181)
> 3) Translatability, spelling, terminology

Done and attached :)
Comment 189 Martin Renvoize 2022-06-20 10:27:49 UTC
Created attachment 136343 [details] [review]
Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.
Comment 190 Martin Renvoize 2022-06-20 10:32:36 UTC Comment hidden (obsolete)
Comment 191 Martin Renvoize 2022-06-20 10:32:44 UTC Comment hidden (obsolete)
Comment 192 Martin Renvoize 2022-06-20 10:32:51 UTC Comment hidden (obsolete)
Comment 193 Martin Renvoize 2022-06-20 10:32:58 UTC Comment hidden (obsolete)
Comment 194 Martin Renvoize 2022-06-20 10:33:05 UTC Comment hidden (obsolete)
Comment 195 Martin Renvoize 2022-06-20 10:33:12 UTC Comment hidden (obsolete)
Comment 196 Martin Renvoize 2022-06-20 10:33:18 UTC Comment hidden (obsolete)
Comment 197 Martin Renvoize 2022-06-20 10:33:25 UTC Comment hidden (obsolete)
Comment 198 Martin Renvoize 2022-06-20 10:33:32 UTC Comment hidden (obsolete)
Comment 199 Martin Renvoize 2022-06-20 10:33:38 UTC Comment hidden (obsolete)
Comment 200 Martin Renvoize 2022-06-20 10:33:45 UTC Comment hidden (obsolete)
Comment 201 Martin Renvoize 2022-06-20 10:33:52 UTC Comment hidden (obsolete)
Comment 202 Martin Renvoize 2022-06-20 10:33:59 UTC Comment hidden (obsolete)
Comment 203 Martin Renvoize 2022-06-20 10:34:07 UTC Comment hidden (obsolete)
Comment 204 Martin Renvoize 2022-06-20 10:34:14 UTC Comment hidden (obsolete)
Comment 205 Martin Renvoize 2022-06-20 10:34:20 UTC Comment hidden (obsolete)
Comment 206 Martin Renvoize 2022-06-20 10:34:27 UTC Comment hidden (obsolete)
Comment 207 Martin Renvoize 2022-06-20 10:34:34 UTC Comment hidden (obsolete)
Comment 208 Martin Renvoize 2022-06-20 10:34:41 UTC Comment hidden (obsolete)
Comment 209 Martin Renvoize 2022-06-20 10:34:47 UTC Comment hidden (obsolete)
Comment 210 Martin Renvoize 2022-06-20 10:34:54 UTC Comment hidden (obsolete)
Comment 211 Martin Renvoize 2022-06-20 10:35:01 UTC Comment hidden (obsolete)
Comment 212 Martin Renvoize 2022-06-20 10:35:09 UTC Comment hidden (obsolete)
Comment 213 Martin Renvoize 2022-06-20 10:35:16 UTC Comment hidden (obsolete)
Comment 214 Martin Renvoize 2022-06-20 10:35:23 UTC Comment hidden (obsolete)
Comment 215 Martin Renvoize 2022-06-20 10:35:30 UTC Comment hidden (obsolete)
Comment 216 Martin Renvoize 2022-06-20 10:35:38 UTC Comment hidden (obsolete)
Comment 217 Martin Renvoize 2022-06-20 10:38:41 UTC
Something moved.. yet another rebase was required.
Comment 218 Martin Renvoize 2022-06-20 10:39:25 UTC
(In reply to Katrin Fischer from comment #181)
> 4) GUI - Configuration
> 
> a) In table configuration, there is one option named external_id - while
> this makes sense to the API, I think it's hard on users. Why not update to
> barcode instead? (normal)

Done and attached :)
Comment 219 Martin Renvoize 2022-06-20 10:45:08 UTC
Created attachment 136371 [details] [review]
Bug 28854: (follow-up) Move preferences to "Item bundles"

Move the preferences into a section under 'Circulation' called 'Item
bundles'
Comment 220 Martin Renvoize 2022-06-20 10:46:10 UTC
(In reply to Katrin Fischer from comment #181)
> 4) GUI - Configuration
> 
> . . .
> 
> b) The system preferences are currently spread on 2 different tabs
> (circulation and cataloguing). I think we should add a new sub heading 'Item
> bundles' to group them on the circulation tab instead. It will make setup
> smoother and I can imagine the section might grow in the future. (normal)

Done and attached, :)
Comment 221 Martin Renvoize 2022-06-20 10:47:27 UTC
(In reply to Katrin Fischer from comment #181)
> 5) Permissions
> 
> a) Who should be able to create item bundles? At the moment anyone with
> catalogue permission should be able to. (question)

I think Cataloguers should be able to, but maybe those with circulation permission too?
Comment 222 Martin Renvoize 2022-06-20 10:48:41 UTC
(In reply to Katrin Fischer from comment #181)
> 6) GUI - Functionality
> 
> a) As barcodes are unique, how could this happen? Should the message maybe
> be adjusted? (question)
> 
> $('#removeResult').replaceWith('<div id="removeResult" class="alert
> alert-danger">'+_("Failed: Barcode matched more than one item
> ")+barcode+'</div>');

Fair question.. I think I was just being cautious.
Comment 223 Katrin Fischer 2022-06-24 14:21:21 UTC
Created attachment 136498 [details] [review]
Bug 28854: (follow-up) Fix typo in templates and test plan

* aready > already
* 61 > 62
Comment 224 Katrin Fischer 2022-06-24 15:39:04 UTC
Taking things for a test run now :)

1) Adding to bundle and removing from bundle

a) When adding a non-existing barcode like "eee", I get an unspecific error message: Failure: Check the logs for details (blocker)

b) The contrast is not really good on those errors I feel, maybe black text would be better on the colored background if that is an easy option. The light red background + red font is a little hard to read. (Accessibility)

c) If you have a leading space in front of the barcode, it won't be recognized. This can happen easily if you copy and paste when forming the bundle and we deal with it in other places - I think we should do it here too for consistency (see also bug 30409) (normal)

d) Should we be able to change contents of a bundle while it is checked out? At the moment it's possible. Maybe a 'safety question'? (question/suggestion)

2) Detail view of bundle 

Staff:

a) From the bundle, there is no way to access the record that holds the bundled item. It would be nice if the Title could be linked in the table to allow for that. (suggestion)

b) Collection is not resolved into the description in the table. (blocker)

c) The item type column is empty, although the bundled item has an itemtype (blocker)

d) If an item is lost, the date is formatted 'database' style. DateFormat is not applied: Last seen: 2022-06-24. DateFormat was set to DD.MM.YYYY. (blocker)

e) As all items on collections now show the "Manage bundle" button, there is no way to see which item actually has bundled items. An idea here would be to add the number of bundled items to the button text. (strong suggestion?)
* Empty: Manage bundle
* 3 items bundled in: Manage bundle (3)

f) If you have 2 items on a bundle record and "Manage bundle" the first, the button appearance changes and looks a bit 'pushed'. 
Now push the second "Manage bundle link". Both bundles are open now, but only the second button appears 'pushed'.
Close the first bundle - the button looks pushed now... close the second, now you have a detail page with the second button looking pushed. 
This seems a bit of a confusing UI message. Maybe it was supposed to close the first when the second was opened? (question)

3) Detail view of bundled items

a) Staff - bundled: I like the link from the status to the record there, although it makes the column quite wide for a longer one. It all has nice class mark-up, so would be easy to play with if needed. (comment)

b) OPAC - bundled: We show "Added to bundle" but there is no way for the OPAC user to figure out "how to get it". I'd really like to see a way to navigate this here. Maybe we could link the status on the detail page to the bundle? (normal)

4) Checkout - nothing found there :)

5) Checkin - nothing to complain about here either. I like the new modal and its functionality.

6) Lost/return claims

Checked in a bundle of 3 items, but one was 'lost'. 

a) Details tab: The return claim was created and in the patron account it shows Claims ( 0 1 ) on the tab. But when I click on the tab, there is nothing below. (blocker)

b) Checkouts tab: The claim shows here, but also shows a little issue: In the notes column, it shows the text 'null'. And when I edit the note the text is there as well.

c) When trying to resolve the checkout claim to "(Not lost)", I see an "Uncaught ReferenceError" in the console and the display of the claims table is not refreshed. When I reload the page, I can see that the claim was actually resolved. (blocker?)

d) When the claim return is resolved to another lost status, like "Lost", the bundle view will show: Lost: 1. It should resolve to the description instead. (blocker)

7) Inventory on checkin feature - no complaints

8) Wish/suggestion list

a) Some items are really similar if you don't see the subtitle, part_name and part_number. The bundle display and the modals in circulation only show title. I think it would make a lot of sense to add the other fields here to display as well. The use case here would be language materials for us. They often match on title ($a) and the important bit is in the other fields (work book, DVD, etc.9. They would also lend themselves to be 'bundled up'.
Comment 225 Martin Renvoize 2022-06-24 15:52:29 UTC Comment hidden (obsolete)
Comment 226 Martin Renvoize 2022-06-24 15:56:39 UTC Comment hidden (obsolete)
Comment 227 Martin Renvoize 2022-06-24 16:00:15 UTC
(In reply to Katrin Fischer from comment #224)
> 1) Adding to bundle and removing from bundle
> 
> a) When adding a non-existing barcode like "eee", I get an unspecific error
> message: Failure: Check the logs for details (blocker)

Fixed in follow-up attached

> b) The contrast is not really good on those errors I feel, maybe black text
> would be better on the colored background if that is an easy option. The
> light red background + red font is a little hard to read. (Accessibility)

I stick to the bookstrap standard alerts here, I'll defer to Owen for guidance.. it's an area I've felt we're really inconsistent all over the place for ages and aught to improve... but I'd rather do a consistent job everywhere in a distinct bug.
 
> c) If you have a leading space in front of the barcode, it won't be
> recognized. This can happen easily if you copy and paste when forming the
> bundle and we deal with it in other places - I think we should do it here
> too for consistency (see also bug 30409) (normal)

Fixed in a follow-up attached.. but it felt a bit wrong to use barcodedecode here.. we should perhaps use JS instead on input.

> d) Should we be able to change contents of a bundle while it is checked out?
> At the moment it's possible. Maybe a 'safety question'? (question/suggestion)

Really good point.. I think it probably shouldn't be possible.. I'll have a go at that next week and then continue with your review.
Comment 228 Katrin Fischer 2022-06-24 21:26:31 UTC
(In reply to Martin Renvoize from comment #227)
> (In reply to Katrin Fischer from comment #224)
> > 1) Adding to bundle and removing from bundle
> > 
> > a) When adding a non-existing barcode like "eee", I get an unspecific error
> > message: Failure: Check the logs for details (blocker)
> 
> Fixed in follow-up attached

Will test later when you have gone through that pile of comments :)


> > b) The contrast is not really good on those errors I feel, maybe black text
> > would be better on the colored background if that is an easy option. The
> > light red background + red font is a little hard to read. (Accessibility)
> 
> I stick to the bookstrap standard alerts here, I'll defer to Owen for
> guidance.. it's an area I've felt we're really inconsistent all over the
> place for ages and aught to improve... but I'd rather do a consistent job
> everywhere in a distinct bug.

That's fair, not a blocker for me.


> > c) If you have a leading space in front of the barcode, it won't be
> > recognized. This can happen easily if you copy and paste when forming the
> > bundle and we deal with it in other places - I think we should do it here
> > too for consistency (see also bug 30409) (normal)
> 
> Fixed in a follow-up attached.. but it felt a bit wrong to use barcodedecode
> here.. we should perhaps use JS instead on input.

I am not stuck on a specific technical solution, just wanted to show that we try to make this behaviour consistent as an argument why we should ignore spaces here too :)

> > d) Should we be able to change contents of a bundle while it is checked out?
> > At the moment it's possible. Maybe a 'safety question'? (question/suggestion)
> 
> Really good point.. I think it probably shouldn't be possible.. I'll have a
> go at that next week and then continue with your review.
Comment 229 Martin Renvoize 2022-06-27 15:38:55 UTC Comment hidden (obsolete)
Comment 230 Martin Renvoize 2022-06-27 15:39:03 UTC Comment hidden (obsolete)
Comment 231 Martin Renvoize 2022-06-27 15:39:11 UTC Comment hidden (obsolete)
Comment 232 Martin Renvoize 2022-06-27 15:39:19 UTC Comment hidden (obsolete)
Comment 233 Martin Renvoize 2022-06-27 15:39:26 UTC Comment hidden (obsolete)
Comment 234 Martin Renvoize 2022-06-27 15:39:34 UTC Comment hidden (obsolete)
Comment 235 Martin Renvoize 2022-06-27 15:39:43 UTC Comment hidden (obsolete)
Comment 236 Martin Renvoize 2022-06-27 15:39:51 UTC Comment hidden (obsolete)
Comment 237 Martin Renvoize 2022-06-27 15:40:03 UTC Comment hidden (obsolete)
Comment 238 Martin Renvoize 2022-06-27 15:40:11 UTC Comment hidden (obsolete)
Comment 239 Martin Renvoize 2022-06-27 15:40:20 UTC Comment hidden (obsolete)
Comment 240 Martin Renvoize 2022-06-27 15:40:31 UTC Comment hidden (obsolete)
Comment 241 Martin Renvoize 2022-06-27 15:40:40 UTC Comment hidden (obsolete)
Comment 242 Martin Renvoize 2022-06-27 15:40:48 UTC Comment hidden (obsolete)
Comment 243 Martin Renvoize 2022-06-27 15:40:56 UTC Comment hidden (obsolete)
Comment 244 Martin Renvoize 2022-06-27 15:41:03 UTC Comment hidden (obsolete)
Comment 245 Martin Renvoize 2022-06-27 15:41:11 UTC Comment hidden (obsolete)
Comment 246 Martin Renvoize 2022-06-27 15:41:18 UTC Comment hidden (obsolete)
Comment 247 Martin Renvoize 2022-06-27 15:41:25 UTC Comment hidden (obsolete)
Comment 248 Martin Renvoize 2022-06-27 15:41:32 UTC Comment hidden (obsolete)
Comment 249 Martin Renvoize 2022-06-27 15:41:40 UTC Comment hidden (obsolete)
Comment 250 Martin Renvoize 2022-06-27 15:41:47 UTC Comment hidden (obsolete)
Comment 251 Martin Renvoize 2022-06-27 15:41:54 UTC Comment hidden (obsolete)
Comment 252 Martin Renvoize 2022-06-27 15:42:02 UTC Comment hidden (obsolete)
Comment 253 Martin Renvoize 2022-06-27 15:42:09 UTC Comment hidden (obsolete)
Comment 254 Martin Renvoize 2022-06-27 15:42:17 UTC Comment hidden (obsolete)
Comment 255 Martin Renvoize 2022-06-27 15:42:25 UTC Comment hidden (obsolete)
Comment 256 Martin Renvoize 2022-06-27 15:42:33 UTC Comment hidden (obsolete)
Comment 257 Martin Renvoize 2022-06-27 15:42:41 UTC Comment hidden (obsolete)
Comment 258 Martin Renvoize 2022-06-27 15:42:49 UTC Comment hidden (obsolete)
Comment 259 Martin Renvoize 2022-06-27 15:42:56 UTC Comment hidden (obsolete)
Comment 260 Martin Renvoize 2022-06-27 15:43:04 UTC Comment hidden (obsolete)
Comment 261 Martin Renvoize 2022-06-27 15:43:11 UTC Comment hidden (obsolete)
Comment 262 Martin Renvoize 2022-06-27 15:43:19 UTC Comment hidden (obsolete)
Comment 263 Martin Renvoize 2022-06-27 15:43:26 UTC Comment hidden (obsolete)
Comment 264 Martin Renvoize 2022-06-27 15:43:34 UTC Comment hidden (obsolete)
Comment 265 Martin Renvoize 2022-06-27 15:43:42 UTC Comment hidden (obsolete)
Comment 266 Martin Renvoize 2022-06-27 15:43:50 UTC Comment hidden (obsolete)
Comment 267 Martin Renvoize 2022-06-27 15:43:58 UTC Comment hidden (obsolete)
Comment 268 Martin Renvoize 2022-06-27 15:44:06 UTC Comment hidden (obsolete)
Comment 269 Martin Renvoize 2022-06-27 16:01:37 UTC
(In reply to Katrin Fischer from comment #224)
> Taking things for a test run now :)
> 
> c) If you have a leading space in front of the barcode, it won't be
> recognized. This can happen easily if you copy and paste when forming the
> bundle and we deal with it in other places - I think we should do it here
> too for consistency (see also bug 30409) (normal)

Decided to stick with barcodedecode as it does more than just whitespace depending on some koha settings.
 
> d) Should we be able to change contents of a bundle while it is checked out?
> At the moment it's possible. Maybe a 'safety question'? (question/suggestion)

Fixed in follow-up.

> 2) Detail view of bundle 
> 
> Staff:
> 
> a) From the bundle, there is no way to access the record that holds the
> bundled item. It would be nice if the Title could be linked in the table to
> allow for that. (suggestion)

Fixed in follow-up

> b) Collection is not resolved into the description in the table. (blocker)

I'm tempted to drop this column from the display entirely.. is it useful?  Pulling through descriptions is not yet easily supported on the API and there's ongoing discussions around it.
 
> c) The item type column is empty, although the bundled item has an itemtype
> (blocker)

As above; However, I felt this one probably was a more useful field.. I started (see WIP patch) but decided perhaps it should be done as it's own bug as it really involves adding a whole new set of API routes and js handling.

> d) If an item is lost, the date is formatted 'database' style. DateFormat is
> not applied: Last seen: 2022-06-24. DateFormat was set to DD.MM.YYYY.
> (blocker)

Restored in a follow-up.. it got lost somewhere during rebases.

> e) As all items on collections now show the "Manage bundle" button, there is
> no way to see which item actually has bundled items. An idea here would be
> to add the number of bundled items to the button text. (strong suggestion?)
> * Empty: Manage bundle
> * 3 items bundled in: Manage bundle (3)

Fixed in follow-up. Opted to go for (X|Y) where 'X' is "Present items attached" and Y is "Lost items attached".  Might seem Owens thoughts on how this displays inside a button, I'm not entirely sure about the approach of using plain text.

> f) If you have 2 items on a bundle record and "Manage bundle" the first, the
> button appearance changes and looks a bit 'pushed'. 
> Now push the second "Manage bundle link". Both bundles are open now, but
> only the second button appears 'pushed'.
> Close the first bundle - the button looks pushed now... close the second,
> now you have a detail page with the second button looking pushed. 
> This seems a bit of a confusing UI message. Maybe it was supposed to close
> the first when the second was opened? (question)

Enhanced in follow-up.. I wasn't actually doing anything to the button but perhaps your browser was.. I've not assigned an 'active' class to the button when the management UI is expanded and then remove it again if we collapse.

> 3) Detail view of bundled items
> 
> a) Staff - bundled: I like the link from the status to the record there,
> although it makes the column quite wide for a longer one. It all has nice
> class mark-up, so would be easy to play with if needed. (comment)

Restored styling that was lost in rebases again.. we use 'block' display to make it go directly underneath the not for loan status.

> b) OPAC - bundled: We show "Added to bundle" but there is no way for the
> OPAC user to figure out "how to get it". I'd really like to see a way to
> navigate this here. Maybe we could link the status on the detail page to the
> bundle? (normal)

This wasn't at all trivial given how our item status include is written.. I took the simple approach in the end of embedding the data in the controller.. but this is unlikely to work everwhere the include is called.  I think we should take this as-is now and work together with NatFi and Tomas to make status's work via the API's.

> 4) Checkout - nothing found there :)

Awesome.

> 5) Checkin - nothing to complain about here either. I like the new modal and
> its functionality.

Awesome.

> 6) Lost/return claims
> 
> Checked in a bundle of 3 items, but one was 'lost'. 
> 
> a) Details tab: The return claim was created and in the patron account it
> shows Claims ( 0 1 ) on the tab. But when I click on the tab, there is
> nothing below. (blocker)

I couldn't replicate this, but will have another go sometime this week with cleared-down data.

> b) Checkouts tab: The claim shows here, but also shows a little issue: In
> the notes column, it shows the text 'null'. And when I edit the note the
> text is there as well.

Hmm, not sure where the 'null' text is coming from yet.. still working on this one.

> c) When trying to resolve the checkout claim to "(Not lost)", I see an
> "Uncaught ReferenceError" in the console and the display of the claims table
> is not refreshed. When I reload the page, I can see that the claim was
> actually resolved. (blocker?)

Oop.. missed this one whilst working through the comments.. will have to revisit as above.

> d) When the claim return is resolved to another lost status, like "Lost",
> the bundle view will show: Lost: 1. It should resolve to the description
> instead. (blocker)

As above.

> 7) Inventory on checkin feature - no complaints

Awesome.

> 8) Wish/suggestion list
> 
> a) Some items are really similar if you don't see the subtitle, part_name
> and part_number. The bundle display and the modals in circulation only show
> title. I think it would make a lot of sense to add the other fields here to
> display as well. The use case here would be language materials for us. They
> often match on title ($a) and the important bit is in the other fields (work
> book, DVD, etc.9. They would also lend themselves to be 'bundled up'.

We use the standard biblio-title.inc include for the check-in modal so that should already contain all the details you mention.

I've added a follow-up to include handling for part numbers and part names in the manage bundle UI now.

Thanks for reviewing!
Comment 270 Martin Renvoize 2022-06-27 16:22:28 UTC Comment hidden (obsolete)
Comment 271 Martin Renvoize 2022-06-27 16:24:38 UTC
(In reply to Martin Renvoize from comment #269)
> (In reply to Katrin Fischer from comment #224)
> > 6) Lost/return claims
> > 
> > Checked in a bundle of 3 items, but one was 'lost'. 
> > 
> > b) Checkouts tab: The claim shows here, but also shows a little issue: In
> > the notes column, it shows the text 'null'. And when I edit the note the
> > text is there as well.
> 
> Hmm, not sure where the 'null' text is coming from yet.. still working on
> this one.

This was a pre-existing bug in recalls.. I've fixed it in a follow-up attached.. but perhaps it should be on it's own bug report really..  Feel free to grab the patch and submit it distinctly.
Comment 272 Martin Renvoize 2022-06-27 16:54:39 UTC Comment hidden (obsolete)
Comment 273 Martin Renvoize 2022-06-27 16:59:08 UTC
(In reply to Martin Renvoize from comment #269)
> (In reply to Katrin Fischer from comment #224)
> > c) When trying to resolve the checkout claim to "(Not lost)", I see an
> > "Uncaught ReferenceError" in the console and the display of the claims table
> > is not refreshed. When I reload the page, I can see that the claim was
> > actually resolved. (blocker?)
> 
> Oop.. missed this one whilst working through the comments.. will have to
> revisit as above.

Another pre-existing bug in return claims.  Fixed in a follow-up here, but may be better served moved to another bug.. I'm reluctant as I don't really want to hold this one up any further...
Comment 274 Katrin Fischer 2022-07-01 11:38:59 UTC Comment hidden (obsolete)
Comment 275 Martin Renvoize 2022-07-01 12:06:05 UTC Comment hidden (obsolete)
Comment 276 Martin Renvoize 2022-07-01 12:06:14 UTC Comment hidden (obsolete)
Comment 277 Martin Renvoize 2022-07-01 12:06:24 UTC Comment hidden (obsolete)
Comment 278 Martin Renvoize 2022-07-01 12:06:33 UTC Comment hidden (obsolete)
Comment 279 Martin Renvoize 2022-07-01 12:06:43 UTC Comment hidden (obsolete)
Comment 280 Martin Renvoize 2022-07-01 12:06:54 UTC Comment hidden (obsolete)
Comment 281 Martin Renvoize 2022-07-01 12:07:03 UTC Comment hidden (obsolete)
Comment 282 Martin Renvoize 2022-07-01 12:07:13 UTC Comment hidden (obsolete)
Comment 283 Martin Renvoize 2022-07-01 12:07:28 UTC Comment hidden (obsolete)
Comment 284 Martin Renvoize 2022-07-01 12:07:37 UTC Comment hidden (obsolete)
Comment 285 Martin Renvoize 2022-07-01 12:07:47 UTC Comment hidden (obsolete)
Comment 286 Martin Renvoize 2022-07-01 12:07:56 UTC Comment hidden (obsolete)
Comment 287 Martin Renvoize 2022-07-01 12:08:05 UTC Comment hidden (obsolete)
Comment 288 Martin Renvoize 2022-07-01 12:08:16 UTC Comment hidden (obsolete)
Comment 289 Martin Renvoize 2022-07-01 12:08:24 UTC Comment hidden (obsolete)
Comment 290 Martin Renvoize 2022-07-01 12:08:32 UTC Comment hidden (obsolete)
Comment 291 Martin Renvoize 2022-07-01 12:08:39 UTC Comment hidden (obsolete)
Comment 292 Martin Renvoize 2022-07-01 12:08:46 UTC Comment hidden (obsolete)
Comment 293 Martin Renvoize 2022-07-01 12:08:55 UTC Comment hidden (obsolete)
Comment 294 Martin Renvoize 2022-07-01 12:09:03 UTC Comment hidden (obsolete)
Comment 295 Martin Renvoize 2022-07-01 12:09:11 UTC Comment hidden (obsolete)
Comment 296 Martin Renvoize 2022-07-01 12:09:20 UTC Comment hidden (obsolete)
Comment 297 Martin Renvoize 2022-07-01 12:09:28 UTC Comment hidden (obsolete)
Comment 298 Martin Renvoize 2022-07-01 12:09:35 UTC Comment hidden (obsolete)
Comment 299 Martin Renvoize 2022-07-01 12:09:44 UTC Comment hidden (obsolete)
Comment 300 Martin Renvoize 2022-07-01 12:09:54 UTC Comment hidden (obsolete)
Comment 301 Martin Renvoize 2022-07-01 12:10:02 UTC Comment hidden (obsolete)
Comment 302 Martin Renvoize 2022-07-01 12:10:10 UTC Comment hidden (obsolete)
Comment 303 Martin Renvoize 2022-07-01 12:10:17 UTC Comment hidden (obsolete)
Comment 304 Martin Renvoize 2022-07-01 12:10:25 UTC Comment hidden (obsolete)
Comment 305 Martin Renvoize 2022-07-01 12:10:33 UTC Comment hidden (obsolete)
Comment 306 Martin Renvoize 2022-07-01 12:10:42 UTC Comment hidden (obsolete)
Comment 307 Martin Renvoize 2022-07-01 12:10:51 UTC Comment hidden (obsolete)
Comment 308 Martin Renvoize 2022-07-01 12:10:58 UTC Comment hidden (obsolete)
Comment 309 Martin Renvoize 2022-07-01 12:11:08 UTC Comment hidden (obsolete)
Comment 310 Martin Renvoize 2022-07-01 12:11:15 UTC Comment hidden (obsolete)
Comment 311 Martin Renvoize 2022-07-01 12:11:23 UTC Comment hidden (obsolete)
Comment 312 Martin Renvoize 2022-07-01 12:11:31 UTC Comment hidden (obsolete)
Comment 313 Martin Renvoize 2022-07-01 12:11:39 UTC Comment hidden (obsolete)
Comment 314 Martin Renvoize 2022-07-01 12:11:51 UTC Comment hidden (obsolete)
Comment 315 Martin Renvoize 2022-07-01 12:12:00 UTC Comment hidden (obsolete)
Comment 316 Martin Renvoize 2022-07-01 12:12:09 UTC Comment hidden (obsolete)
Comment 317 Martin Renvoize 2022-07-01 12:12:16 UTC Comment hidden (obsolete)
Comment 318 Katrin Fischer 2022-07-01 13:49:47 UTC Comment hidden (obsolete)
Comment 319 Katrin Fischer 2022-07-01 13:49:55 UTC Comment hidden (obsolete)
Comment 320 Katrin Fischer 2022-07-01 13:50:06 UTC Comment hidden (obsolete)
Comment 321 Katrin Fischer 2022-07-01 13:50:16 UTC Comment hidden (obsolete)
Comment 322 Katrin Fischer 2022-07-01 13:50:25 UTC Comment hidden (obsolete)
Comment 323 Katrin Fischer 2022-07-01 13:50:33 UTC Comment hidden (obsolete)
Comment 324 Katrin Fischer 2022-07-01 13:50:42 UTC Comment hidden (obsolete)
Comment 325 Katrin Fischer 2022-07-01 13:50:51 UTC Comment hidden (obsolete)
Comment 326 Katrin Fischer 2022-07-01 13:51:00 UTC Comment hidden (obsolete)
Comment 327 Katrin Fischer 2022-07-01 13:51:08 UTC Comment hidden (obsolete)
Comment 328 Katrin Fischer 2022-07-01 13:51:17 UTC Comment hidden (obsolete)
Comment 329 Katrin Fischer 2022-07-01 13:51:25 UTC Comment hidden (obsolete)
Comment 330 Katrin Fischer 2022-07-01 13:51:36 UTC Comment hidden (obsolete)
Comment 331 Katrin Fischer 2022-07-01 13:51:44 UTC Comment hidden (obsolete)
Comment 332 Katrin Fischer 2022-07-01 13:51:53 UTC Comment hidden (obsolete)
Comment 333 Katrin Fischer 2022-07-01 13:52:02 UTC Comment hidden (obsolete)
Comment 334 Katrin Fischer 2022-07-01 13:52:11 UTC Comment hidden (obsolete)
Comment 335 Katrin Fischer 2022-07-01 13:52:20 UTC Comment hidden (obsolete)
Comment 336 Katrin Fischer 2022-07-01 13:52:28 UTC Comment hidden (obsolete)
Comment 337 Katrin Fischer 2022-07-01 13:52:36 UTC Comment hidden (obsolete)
Comment 338 Katrin Fischer 2022-07-01 13:52:46 UTC Comment hidden (obsolete)
Comment 339 Katrin Fischer 2022-07-01 13:52:54 UTC Comment hidden (obsolete)
Comment 340 Katrin Fischer 2022-07-01 13:53:02 UTC Comment hidden (obsolete)
Comment 341 Katrin Fischer 2022-07-01 13:53:11 UTC Comment hidden (obsolete)
Comment 342 Katrin Fischer 2022-07-01 13:53:19 UTC Comment hidden (obsolete)
Comment 343 Katrin Fischer 2022-07-01 13:53:27 UTC Comment hidden (obsolete)
Comment 344 Katrin Fischer 2022-07-01 13:53:36 UTC Comment hidden (obsolete)
Comment 345 Katrin Fischer 2022-07-01 13:53:46 UTC Comment hidden (obsolete)
Comment 346 Katrin Fischer 2022-07-01 13:53:54 UTC Comment hidden (obsolete)
Comment 347 Katrin Fischer 2022-07-01 13:54:03 UTC Comment hidden (obsolete)
Comment 348 Katrin Fischer 2022-07-01 13:54:11 UTC Comment hidden (obsolete)
Comment 349 Katrin Fischer 2022-07-01 13:54:20 UTC Comment hidden (obsolete)
Comment 350 Katrin Fischer 2022-07-01 13:54:28 UTC Comment hidden (obsolete)
Comment 351 Katrin Fischer 2022-07-01 13:54:37 UTC Comment hidden (obsolete)
Comment 352 Katrin Fischer 2022-07-01 13:54:47 UTC Comment hidden (obsolete)
Comment 353 Katrin Fischer 2022-07-01 13:54:57 UTC Comment hidden (obsolete)
Comment 354 Katrin Fischer 2022-07-01 13:55:07 UTC Comment hidden (obsolete)
Comment 355 Katrin Fischer 2022-07-01 13:55:16 UTC Comment hidden (obsolete)
Comment 356 Katrin Fischer 2022-07-01 13:55:25 UTC Comment hidden (obsolete)
Comment 357 Katrin Fischer 2022-07-01 13:55:34 UTC Comment hidden (obsolete)
Comment 358 Katrin Fischer 2022-07-01 13:55:47 UTC Comment hidden (obsolete)
Comment 359 Katrin Fischer 2022-07-01 13:56:00 UTC Comment hidden (obsolete)
Comment 360 Katrin Fischer 2022-07-01 13:56:09 UTC Comment hidden (obsolete)
Comment 361 Katrin Fischer 2022-07-01 13:57:06 UTC
I am quite happy with this now with this at 43 commits :) 

I have filed separate bugs for some of the enhancement ideas remaining that I don't consider blocker so we can track those. No need to grow this further. They are all bite-size things that should be easy to test later on, but no need to grow this further.
Comment 362 Martin Renvoize 2022-07-01 14:17:42 UTC Comment hidden (obsolete)
Comment 363 Martin Renvoize 2022-07-01 14:52:42 UTC Comment hidden (obsolete)
Comment 364 Martin Renvoize 2022-07-01 14:52:51 UTC Comment hidden (obsolete)
Comment 365 Martin Renvoize 2022-07-01 14:53:00 UTC Comment hidden (obsolete)
Comment 366 Martin Renvoize 2022-07-01 14:53:09 UTC Comment hidden (obsolete)
Comment 367 Martin Renvoize 2022-07-01 14:53:18 UTC Comment hidden (obsolete)
Comment 368 Martin Renvoize 2022-07-01 14:53:26 UTC Comment hidden (obsolete)
Comment 369 Martin Renvoize 2022-07-01 14:53:35 UTC Comment hidden (obsolete)
Comment 370 Martin Renvoize 2022-07-01 14:53:46 UTC Comment hidden (obsolete)
Comment 371 Martin Renvoize 2022-07-01 14:53:54 UTC Comment hidden (obsolete)
Comment 372 Martin Renvoize 2022-07-01 14:54:05 UTC Comment hidden (obsolete)
Comment 373 Martin Renvoize 2022-07-01 14:54:14 UTC Comment hidden (obsolete)
Comment 374 Martin Renvoize 2022-07-01 14:54:23 UTC Comment hidden (obsolete)
Comment 375 Martin Renvoize 2022-07-01 14:54:33 UTC Comment hidden (obsolete)
Comment 376 Martin Renvoize 2022-07-01 14:54:43 UTC Comment hidden (obsolete)
Comment 377 Martin Renvoize 2022-07-01 14:54:51 UTC Comment hidden (obsolete)
Comment 378 Martin Renvoize 2022-07-01 14:55:00 UTC Comment hidden (obsolete)
Comment 379 Martin Renvoize 2022-07-01 14:55:11 UTC Comment hidden (obsolete)
Comment 380 Martin Renvoize 2022-07-01 14:55:23 UTC Comment hidden (obsolete)
Comment 381 Martin Renvoize 2022-07-01 14:55:32 UTC Comment hidden (obsolete)
Comment 382 Martin Renvoize 2022-07-01 14:55:40 UTC Comment hidden (obsolete)
Comment 383 Martin Renvoize 2022-07-01 14:55:50 UTC Comment hidden (obsolete)
Comment 384 Martin Renvoize 2022-07-01 14:55:58 UTC Comment hidden (obsolete)
Comment 385 Martin Renvoize 2022-07-01 14:56:09 UTC Comment hidden (obsolete)
Comment 386 Martin Renvoize 2022-07-01 14:56:17 UTC Comment hidden (obsolete)
Comment 387 Martin Renvoize 2022-07-01 14:56:25 UTC Comment hidden (obsolete)
Comment 388 Martin Renvoize 2022-07-01 14:56:33 UTC Comment hidden (obsolete)
Comment 389 Martin Renvoize 2022-07-01 14:56:42 UTC Comment hidden (obsolete)
Comment 390 Martin Renvoize 2022-07-01 14:56:54 UTC Comment hidden (obsolete)
Comment 391 Martin Renvoize 2022-07-01 14:57:02 UTC Comment hidden (obsolete)
Comment 392 Martin Renvoize 2022-07-01 14:57:11 UTC Comment hidden (obsolete)
Comment 393 Martin Renvoize 2022-07-01 14:57:20 UTC Comment hidden (obsolete)
Comment 394 Martin Renvoize 2022-07-01 14:57:29 UTC Comment hidden (obsolete)
Comment 395 Martin Renvoize 2022-07-01 14:57:38 UTC Comment hidden (obsolete)
Comment 396 Martin Renvoize 2022-07-01 14:57:48 UTC Comment hidden (obsolete)
Comment 397 Martin Renvoize 2022-07-01 14:57:59 UTC Comment hidden (obsolete)
Comment 398 Martin Renvoize 2022-07-01 14:58:08 UTC Comment hidden (obsolete)
Comment 399 Martin Renvoize 2022-07-01 14:58:18 UTC Comment hidden (obsolete)
Comment 400 Martin Renvoize 2022-07-01 14:58:27 UTC Comment hidden (obsolete)
Comment 401 Martin Renvoize 2022-07-01 14:58:36 UTC Comment hidden (obsolete)
Comment 402 Martin Renvoize 2022-07-01 14:58:45 UTC Comment hidden (obsolete)
Comment 403 Martin Renvoize 2022-07-01 14:58:54 UTC Comment hidden (obsolete)
Comment 404 Martin Renvoize 2022-07-01 15:01:31 UTC
Final rebase done and commits we agreed to split out into their own bugs have now been split out and added to the bugzilla tree.

All ready for a final QA run.

Thanks so much for the thorough and vigilent testing Katrin.. it's been really helpful putting this new feature through it's paces and I think we've come out with a much more polished piece overall.
Comment 405 Martin Renvoize 2022-07-11 07:00:17 UTC Comment hidden (obsolete)
Comment 406 Martin Renvoize 2022-07-11 07:00:28 UTC Comment hidden (obsolete)
Comment 407 Martin Renvoize 2022-07-11 07:00:38 UTC Comment hidden (obsolete)
Comment 408 Martin Renvoize 2022-07-11 07:00:48 UTC Comment hidden (obsolete)
Comment 409 Martin Renvoize 2022-07-11 07:00:59 UTC Comment hidden (obsolete)
Comment 410 Martin Renvoize 2022-07-11 07:01:10 UTC Comment hidden (obsolete)
Comment 411 Martin Renvoize 2022-07-11 07:01:20 UTC Comment hidden (obsolete)
Comment 412 Martin Renvoize 2022-07-11 07:01:29 UTC Comment hidden (obsolete)
Comment 413 Martin Renvoize 2022-07-11 07:01:38 UTC Comment hidden (obsolete)
Comment 414 Martin Renvoize 2022-07-11 07:01:49 UTC Comment hidden (obsolete)
Comment 415 Martin Renvoize 2022-07-11 07:01:58 UTC Comment hidden (obsolete)
Comment 416 Martin Renvoize 2022-07-11 07:02:08 UTC Comment hidden (obsolete)
Comment 417 Martin Renvoize 2022-07-11 07:02:17 UTC Comment hidden (obsolete)
Comment 418 Martin Renvoize 2022-07-11 07:02:26 UTC Comment hidden (obsolete)
Comment 419 Martin Renvoize 2022-07-11 07:02:36 UTC Comment hidden (obsolete)
Comment 420 Martin Renvoize 2022-07-11 07:02:45 UTC Comment hidden (obsolete)
Comment 421 Martin Renvoize 2022-07-11 07:02:54 UTC Comment hidden (obsolete)
Comment 422 Martin Renvoize 2022-07-11 07:03:06 UTC Comment hidden (obsolete)
Comment 423 Martin Renvoize 2022-07-11 07:03:15 UTC Comment hidden (obsolete)
Comment 424 Martin Renvoize 2022-07-11 07:03:24 UTC Comment hidden (obsolete)
Comment 425 Martin Renvoize 2022-07-11 07:03:33 UTC Comment hidden (obsolete)
Comment 426 Martin Renvoize 2022-07-11 07:03:44 UTC Comment hidden (obsolete)
Comment 427 Martin Renvoize 2022-07-11 07:03:53 UTC Comment hidden (obsolete)
Comment 428 Martin Renvoize 2022-07-11 07:04:05 UTC Comment hidden (obsolete)
Comment 429 Martin Renvoize 2022-07-11 07:04:14 UTC Comment hidden (obsolete)
Comment 430 Martin Renvoize 2022-07-11 07:04:23 UTC Comment hidden (obsolete)
Comment 431 Martin Renvoize 2022-07-11 07:04:32 UTC Comment hidden (obsolete)
Comment 432 Martin Renvoize 2022-07-11 07:04:41 UTC Comment hidden (obsolete)
Comment 433 Martin Renvoize 2022-07-11 07:04:52 UTC Comment hidden (obsolete)
Comment 434 Martin Renvoize 2022-07-11 07:05:01 UTC Comment hidden (obsolete)
Comment 435 Martin Renvoize 2022-07-11 07:05:11 UTC Comment hidden (obsolete)
Comment 436 Martin Renvoize 2022-07-11 07:05:21 UTC Comment hidden (obsolete)
Comment 437 Martin Renvoize 2022-07-11 07:05:31 UTC Comment hidden (obsolete)
Comment 438 Martin Renvoize 2022-07-11 07:05:40 UTC Comment hidden (obsolete)
Comment 439 Martin Renvoize 2022-07-11 07:05:50 UTC Comment hidden (obsolete)
Comment 440 Martin Renvoize 2022-07-11 07:06:02 UTC Comment hidden (obsolete)
Comment 441 Martin Renvoize 2022-07-11 07:06:13 UTC Comment hidden (obsolete)
Comment 442 Martin Renvoize 2022-07-11 07:06:21 UTC Comment hidden (obsolete)
Comment 443 Martin Renvoize 2022-07-11 07:06:30 UTC Comment hidden (obsolete)
Comment 444 Martin Renvoize 2022-07-11 07:06:39 UTC Comment hidden (obsolete)
Comment 445 Martin Renvoize 2022-07-11 07:06:49 UTC Comment hidden (obsolete)
Comment 446 Martin Renvoize 2022-07-11 07:08:10 UTC
Another rebase, now that itemgroups is in.. I was worried these features might clash more, but the rebase was fairly trivial and they seem to compliment each other nicely in the UI so far in my testing.

Ready for QA :)
Comment 447 Kyle M Hall 2022-07-11 11:17:30 UTC
Created attachment 137503 [details] [review]
Bug 28854: Squashed Patch Set for Reading

Bug 28854: Database update

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: DBIC Schema Updates

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point and run the database update
1) Configuration: `BundleNotLoanValue` should have been set by the
   database update and point to a newly added AV value.
2) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
3) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
4) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.
5) The bundles feature can be disabled by unsetting the
   `BundleNotLoanValue` system preference.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Highlight bundle rows to clarify UI

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Drop unique index on issue_id in return claims

With the introduction of circulating items within a bundle set, we can
now loose multiple items from the bundle from the same issue.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: DBIC Update ReturnClaim Schema

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that it is marked
   as lost.
4) Navigate to the biblio for the collection and expand the collection
   item that contains the lost item. Note the item is marked as lost and
   checkout details are listed.
5) Checkin the lost item
   * The item should be marked as found and the return_claims line should
   be marked as resolved.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Simplified status handling for bundle inventory check

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Add option to print content list after verification

We already allowed the user to view and print an updated content list
after a varification showed that items were missing from the bundle.
This patch adds the option to view and print the list even if the
content has been varified to have not changed.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Add ordering to checkin validation modal

This enhancement adds simple dataTable ordering to the verification
modal table at bundle checkin time.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Improve lost details display for bundle items

This patch adds the return claim details to the bundle item status
display on the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Enable claims return view when BundleLostValue is set

This patch adds the alternation of BundleLostValue to enable the return
claims functionality when Bundles are enbled.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Highlight when a scanned item is unexpected

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Add count of scanned items to verification modal

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Add 'Remove from bundle' dialogue to details display

This patch adds the counterpart of the 'Add to bundle' modal prompt for
adding items to bundles from the catalogue details display.  It allows
for scanning barcodes to remove them from a bundle.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Add modal after checkin to print missing items list

This patch adds a further modal to the post checkin alert to allow the
user to print a view and print a list of items that went missing at this
checkin to allow for replacements to be picked.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Only count rows in the body

This patch fixes the count to only include table rows in the body, i.e.
skip the header row.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Make barcode comparison case insensative

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (QA follow-up) Fix QA tool complaints

* Typo in code comment
* Permissions on atomicupdate
* Missing TT filter in template
* Spelling in template

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Unit test for Koha::Item additions

This patch adds unit tests for the new methods added to Koha::Item
including:

* return_claim
* return_claims
* is_bundle
* in_bundle
* bundle_host
* bundle_items
* add_to_bundle
* remove_from_bundle

Test plan
1) Run t/db_dependent/Koha/Item.t

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Unit test for AddReturn addition

This patch adds tests for the AddReturn change that adds an 'InBundle' message
to the return.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Unit tests - chargelostitem

This patch adds unit tests for the changes to chargelositem to ensure
bundle charging works as expected setting the correct issue_id.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: Add default AV and Syspref values

This patch adds the new AV and System Preferences to the installer.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Rename column configuration to barcode

This patch updates the column configuration from 'external_id' to
'barcode'

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Move preferences to "Item bundles"

Move the preferences into a section under 'Circulation' called 'Item
bundles'

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Fix typo in templates and test plan

* aready > already
* 61 > 62

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Improve error for item not found

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items

This removes any leading or trailing whitespace from the external id
passed

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Disable bundle editing for checked out

This patch disables the add and remove options under bundle management
when the bundled item in question is checked out.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Link bundle items to thier biblios

This patch splits out the title formatting from the bundle item title
display into it's own new js-biblio-format include file and adds biblio
linking options.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Restore last seen date formatting

We lost the date formatting somewhere along the line with rebases, this
patch restores the call to $date for last seen date.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Add bundle item status to manage button

This patch adds the item counts (Present|Lost) to the 'Manage bundle'
button in the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle'

This patch adds and removes the 'active' class to the 'Manage bundle'
button such that it correctly reflects whether the manage area is
expanded or not for the bundle item.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Restore block styling on bundled span

This patch restores a css rule that we lost during rebases that makes
the 'bundled' span that appears for bundled items on their respective
details pages so that the 'In bundle: ' text in the status field of the
table appears beneath the 'Not for loan (Added to bundle)' text.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Link to 'In bundle' on OPAC

This patch adds the 'In bundle: Link' to the OPAC to mirror what we have
on the staff client.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Add handling for part_numbers/names

This patch adds part number/name handling to the new biblio-format js
include. This will add such details to bundle management tables.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (QA follow-up) Add missing TT filters

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Bug 28854: (follow-up) Remove fields from from bundle items

This patch removes the itemtype and collection code fields from the
bundle items table.

We will add the itemtype back in at a later date with a new bug as the
display code needs some careful consideration and we felt that doing
that work inline here would be an unrequired blocker.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 448 Kyle M Hall 2022-07-11 12:29:14 UTC
Comment on attachment 137503 [details] [review]
Bug 28854: Squashed Patch Set for Reading

Review of attachment 137503 [details] [review]:
-----------------------------------------------------------------

::: C4/Accounts.pm
@@ +70,5 @@
>  sub chargelostitem {
>      my $dbh = C4::Context->dbh();
>      my ($borrowernumber, $itemnumber, $amount, $description) = @_;
> +    my $item  = Koha::Items->find($itemnumber);
> +    my $itype = $item->itemtype;

Why the switch from effective_itemtype() to itemtype()?

::: Koha/Item.pm
@@ +1611,5 @@
> +            }
> +            elsif ( $_->{msg} =~
> +/Incorrect (?<type>\w+) value: '(?<value>.*)' for column \W?(?<property>\S+)/
> +              )
> +            {    # The optional \W in the regex might be a quote or backtick

There is no \W in the regex. Wish it changed, or maybe the W should be lower case?
Comment 449 Kyle M Hall 2022-07-11 12:31:55 UTC
Created attachment 137506 [details] [review]
Bug 28854: (QA follow-up)
Comment 450 Kyle M Hall 2022-07-11 13:56:05 UTC
I'm getting failures from t/db_dependent/Koha/Checkouts/ReturnClaim.t
In addition, can you address the two small things from my splinter review?
Comment 451 Martin Renvoize 2022-07-11 14:18:33 UTC
(In reply to Kyle M Hall from comment #448)
> Comment on attachment 137503 [details] [review] [review]
> Bug 28854: Squashed Patch Set for Reading
> 
> Review of attachment 137503 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Accounts.pm
> @@ +70,5 @@
> >  sub chargelostitem {
> >      my $dbh = C4::Context->dbh();
> >      my ($borrowernumber, $itemnumber, $amount, $description) = @_;
> > +    my $item  = Koha::Items->find($itemnumber);
> > +    my $itype = $item->itemtype;
> 
> Why the switch from effective_itemtype() to itemtype()?

So.. the change here is actually so we can have access to the Item object lower down in the function.. the switch from finding the itemtype object directly to using the Koha::Item level accessor method means we get back the effective_itemtype object directly via the accessor.  See Koha::Item->itemtype ;P

> 
> ::: Koha/Item.pm
> @@ +1611,5 @@
> > +            }
> > +            elsif ( $_->{msg} =~
> > +/Incorrect (?<type>\w+) value: '(?<value>.*)' for column \W?(?<property>\S+)/
> > +              )
> > +            {    # The optional \W in the regex might be a quote or backtick
> 
> There is no \W in the regex. Wish it changed, or maybe the W should be lower
> case?

Huh.. this is a copy/paste from Koha::Object::store (Yes, I'd like to move it into DBIC at some point, but didn't feel it was appropriate here).. the `\W?` is there.. just after `for column` in the regex.. not sure I follow your question here I'm afraid.
Comment 452 Martin Renvoize 2022-07-11 14:21:18 UTC
(In reply to Kyle M Hall from comment #450)
> I'm getting failures from t/db_dependent/Koha/Checkouts/ReturnClaim.t
> In addition, can you address the two small things from my splinter review?

Hmm.. I can't seem to get the test to fail.. did you run the DB update/get any errors when you ran the DB update?
Comment 453 Kyle M Hall 2022-07-11 14:35:58 UTC
> > Why the switch from effective_itemtype() to itemtype()?
> 
> So.. the change here is actually so we can have access to the Item object
> lower down in the function.. the switch from finding the itemtype object
> directly to using the Koha::Item level accessor method means we get back the
> effective_itemtype object directly via the accessor.  See
> Koha::Item->itemtype ;P

Thanks! I see now! I missed that subroutine when I was looking for it!


> Huh.. this is a copy/paste from Koha::Object::store (Yes, I'd like to move
> it into DBIC at some point, but didn't feel it was appropriate here).. the
> `\W?` is there.. just after `for column` in the regex.. not sure I follow
> your question here I'm afraid.

I missed where the \W was by focusing only on the patch and not the surrounding code.
Comment 454 Martin Renvoize 2022-07-11 15:09:26 UTC
Created attachment 137524 [details] [review]
Bug 28854: (QA follow-up) Remove duplicate key test

We now allow duplication of issue_id accross the return claims table (to
allow for the case where a bundle item has been loaned and thus multiple
claims can result from the same checkout.
Comment 455 Martin Renvoize 2022-07-11 15:19:55 UTC
Created attachment 137525 [details] [review]
Bug 28854: (QA follow-up) Fix DB revision for AV's above 10

The authorised_value field is a varchar and so 'MAX' will sort '9' above
'10' and cause issues if you have more than 9 AV values already for LOST
or NOT_LOAN.

This patch adds a 'CAST' to the field so we can use MAX correctly.
Comment 456 Kyle M Hall 2022-07-11 15:55:05 UTC
Created attachment 137527 [details] [review]
Bug 28854: Database update

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 457 Kyle M Hall 2022-07-11 15:55:30 UTC
Created attachment 137528 [details] [review]
Bug 28854: DBIC Schema Updates

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 458 Kyle M Hall 2022-07-11 15:55:39 UTC
Created attachment 137529 [details] [review]
Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point and run the database update
1) Configuration: `BundleNotLoanValue` should have been set by the
   database update and point to a newly added AV value.
2) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
3) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
4) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.
5) The bundles feature can be disabled by unsetting the
   `BundleNotLoanValue` system preference.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 459 Kyle M Hall 2022-07-11 15:55:48 UTC
Created attachment 137530 [details] [review]
Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 460 Kyle M Hall 2022-07-11 15:56:03 UTC
Created attachment 137531 [details] [review]
Bug 28854: Highlight bundle rows to clarify UI

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 461 Kyle M Hall 2022-07-11 15:56:12 UTC
Created attachment 137532 [details] [review]
Bug 28854: Drop unique index on issue_id in return claims

With the introduction of circulating items within a bundle set, we can
now loose multiple items from the bundle from the same issue.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 462 Kyle M Hall 2022-07-11 15:56:21 UTC
Created attachment 137533 [details] [review]
Bug 28854: DBIC Update ReturnClaim Schema

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 463 Kyle M Hall 2022-07-11 15:56:33 UTC
Created attachment 137534 [details] [review]
Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that it is marked
   as lost.
4) Navigate to the biblio for the collection and expand the collection
   item that contains the lost item. Note the item is marked as lost and
   checkout details are listed.
5) Checkin the lost item
   * The item should be marked as found and the return_claims line should
   be marked as resolved.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 464 Kyle M Hall 2022-07-11 15:56:42 UTC
Created attachment 137535 [details] [review]
Bug 28854: Simplified status handling for bundle inventory check

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 465 Kyle M Hall 2022-07-11 15:56:54 UTC
Created attachment 137536 [details] [review]
Bug 28854: Add option to print content list after verification

We already allowed the user to view and print an updated content list
after a varification showed that items were missing from the bundle.
This patch adds the option to view and print the list even if the
content has been varified to have not changed.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 466 Kyle M Hall 2022-07-11 15:57:23 UTC
Created attachment 137537 [details] [review]
Bug 28854: Add ordering to checkin validation modal

This enhancement adds simple dataTable ordering to the verification
modal table at bundle checkin time.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 467 Kyle M Hall 2022-07-11 15:57:34 UTC
Created attachment 137538 [details] [review]
Bug 28854: Improve lost details display for bundle items

This patch adds the return claim details to the bundle item status
display on the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 468 Kyle M Hall 2022-07-11 15:57:46 UTC
Created attachment 137540 [details] [review]
Bug 28854: Enable claims return view when BundleLostValue is set

This patch adds the alternation of BundleLostValue to enable the return
claims functionality when Bundles are enbled.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 469 Kyle M Hall 2022-07-11 15:58:04 UTC
Created attachment 137541 [details] [review]
Bug 28854: Highlight when a scanned item is unexpected

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 470 Kyle M Hall 2022-07-11 15:58:25 UTC
Created attachment 137542 [details] [review]
Bug 28854: Add count of scanned items to verification modal

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 471 Kyle M Hall 2022-07-11 15:58:34 UTC
Created attachment 137543 [details] [review]
Bug 28854: Add 'Remove from bundle' dialogue to details display

This patch adds the counterpart of the 'Add to bundle' modal prompt for
adding items to bundles from the catalogue details display.  It allows
for scanning barcodes to remove them from a bundle.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 472 Kyle M Hall 2022-07-11 15:58:44 UTC
Created attachment 137544 [details] [review]
Bug 28854: Add modal after checkin to print missing items list

This patch adds a further modal to the post checkin alert to allow the
user to print a view and print a list of items that went missing at this
checkin to allow for replacements to be picked.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 473 Kyle M Hall 2022-07-11 15:58:54 UTC
Created attachment 137545 [details] [review]
Bug 28854: (follow-up) Only count rows in the body

This patch fixes the count to only include table rows in the body, i.e.
skip the header row.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 474 Kyle M Hall 2022-07-11 15:59:03 UTC
Created attachment 137546 [details] [review]
Bug 28854: Make barcode comparison case insensative

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 475 Kyle M Hall 2022-07-11 15:59:12 UTC
Created attachment 137547 [details] [review]
Bug 28854: (QA follow-up) Fix QA tool complaints

* Typo in code comment
* Permissions on atomicupdate
* Missing TT filter in template
* Spelling in template

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 476 Kyle M Hall 2022-07-11 15:59:21 UTC
Created attachment 137548 [details] [review]
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 477 Kyle M Hall 2022-07-11 15:59:29 UTC
Created attachment 137549 [details] [review]
Bug 28854: Unit test for Koha::Item additions

This patch adds unit tests for the new methods added to Koha::Item
including:

* return_claim
* return_claims
* is_bundle
* in_bundle
* bundle_host
* bundle_items
* add_to_bundle
* remove_from_bundle

Test plan
1) Run t/db_dependent/Koha/Item.t

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 478 Kyle M Hall 2022-07-11 15:59:38 UTC
Created attachment 137550 [details] [review]
Bug 28854: Unit test for AddReturn addition

This patch adds tests for the AddReturn change that adds an 'InBundle' message
to the return.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 479 Kyle M Hall 2022-07-11 15:59:49 UTC
Created attachment 137551 [details] [review]
Bug 28854: Unit tests - chargelostitem

This patch adds unit tests for the changes to chargelositem to ensure
bundle charging works as expected setting the correct issue_id.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 480 Kyle M Hall 2022-07-11 15:59:58 UTC
Created attachment 137552 [details] [review]
Bug 28854: Add default AV and Syspref values

This patch adds the new AV and System Preferences to the installer.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 481 Kyle M Hall 2022-07-11 16:00:09 UTC
Created attachment 137553 [details] [review]
Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 482 Kyle M Hall 2022-07-11 16:00:22 UTC
Created attachment 137554 [details] [review]
Bug 28854: (follow-up) Rename column configuration to barcode

This patch updates the column configuration from 'external_id' to
'barcode'

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 483 Kyle M Hall 2022-07-11 16:00:33 UTC
Created attachment 137555 [details] [review]
Bug 28854: (follow-up) Move preferences to "Item bundles"

Move the preferences into a section under 'Circulation' called 'Item
bundles'

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 484 Kyle M Hall 2022-07-11 16:00:44 UTC
Created attachment 137556 [details] [review]
Bug 28854: (follow-up) Fix typo in templates and test plan

* aready > already
* 61 > 62

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 485 Kyle M Hall 2022-07-11 16:00:57 UTC
Created attachment 137557 [details] [review]
Bug 28854: (follow-up) Improve error for item not found

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 486 Kyle M Hall 2022-07-11 16:01:08 UTC
Created attachment 137558 [details] [review]
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items

This removes any leading or trailing whitespace from the external id
passed

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 487 Kyle M Hall 2022-07-11 16:01:17 UTC
Created attachment 137559 [details] [review]
Bug 28854: (follow-up) Disable bundle editing for checked out

This patch disables the add and remove options under bundle management
when the bundled item in question is checked out.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 488 Kyle M Hall 2022-07-11 16:01:28 UTC
Created attachment 137560 [details] [review]
Bug 28854: (follow-up) Link bundle items to thier biblios

This patch splits out the title formatting from the bundle item title
display into it's own new js-biblio-format include file and adds biblio
linking options.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 489 Kyle M Hall 2022-07-11 16:01:37 UTC
Created attachment 137561 [details] [review]
Bug 28854: (follow-up) Restore last seen date formatting

We lost the date formatting somewhere along the line with rebases, this
patch restores the call to $date for last seen date.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 490 Kyle M Hall 2022-07-11 16:01:45 UTC
Created attachment 137562 [details] [review]
Bug 28854: (follow-up) Add bundle item status to manage button

This patch adds the item counts (Present|Lost) to the 'Manage bundle'
button in the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 491 Kyle M Hall 2022-07-11 16:01:54 UTC
Created attachment 137563 [details] [review]
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle'

This patch adds and removes the 'active' class to the 'Manage bundle'
button such that it correctly reflects whether the manage area is
expanded or not for the bundle item.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 492 Kyle M Hall 2022-07-11 16:02:04 UTC
Created attachment 137564 [details] [review]
Bug 28854: (follow-up) Restore block styling on bundled span

This patch restores a css rule that we lost during rebases that makes
the 'bundled' span that appears for bundled items on their respective
details pages so that the 'In bundle: ' text in the status field of the
table appears beneath the 'Not for loan (Added to bundle)' text.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 493 Kyle M Hall 2022-07-11 16:02:13 UTC
Created attachment 137565 [details] [review]
Bug 28854: (follow-up) Link to 'In bundle' on OPAC

This patch adds the 'In bundle: Link' to the OPAC to mirror what we have
on the staff client.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 494 Kyle M Hall 2022-07-11 16:02:23 UTC
Created attachment 137566 [details] [review]
Bug 28854: (follow-up) Add handling for part_numbers/names

This patch adds part number/name handling to the new biblio-format js
include. This will add such details to bundle management tables.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 495 Kyle M Hall 2022-07-11 16:02:35 UTC
Created attachment 137567 [details] [review]
Bug 28854: (QA follow-up) Add missing TT filters

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 496 Kyle M Hall 2022-07-11 16:02:46 UTC
Created attachment 137568 [details] [review]
Bug 28854: (follow-up) Remove fields from from bundle items

This patch removes the itemtype and collection code fields from the
bundle items table.

We will add the itemtype back in at a later date with a new bug as the
display code needs some careful consideration and we felt that doing
that work inline here would be an unrequired blocker.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 497 Kyle M Hall 2022-07-11 16:02:59 UTC
Created attachment 137569 [details] [review]
Bug 28854: (QA follow-up)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 498 Kyle M Hall 2022-07-11 16:03:09 UTC
Created attachment 137570 [details] [review]
Bug 28854: (QA follow-up) Remove duplicate key test

We now allow duplication of issue_id accross the return claims table (to
allow for the case where a bundle item has been loaned and thus multiple
claims can result from the same checkout.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 499 Kyle M Hall 2022-07-11 16:03:19 UTC
Created attachment 137571 [details] [review]
Bug 28854: (QA follow-up) Fix DB revision for AV's above 10

The authorised_value field is a varchar and so 'MAX' will sort '9' above
'10' and cause issues if you have more than 9 AV values already for LOST
or NOT_LOAN.

This patch adds a 'CAST' to the field so we can use MAX correctly.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 500 Tomás Cohen Arazi 2022-07-13 15:23:02 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 501 Martin Renvoize 2022-07-13 17:17:03 UTC Comment hidden (obsolete)
Comment 502 Martin Renvoize 2022-07-13 17:19:13 UTC
Follow-up attached to fix the failing introduced here on master.

Not sure why I didn't think about this constraint replacement in the first place, it's a nice improvement over the simple removal I did before and shouldn't have any negative side effects on the feature introduced here.

The follow-up includes an atomic update and the kohaschema change but does not include the dbic schema build ;P
Comment 503 Martin Renvoize 2022-07-13 17:24:27 UTC Comment hidden (obsolete)
Comment 504 Jonathan Druart 2022-07-25 08:07:09 UTC
New error/warning in test output

t/db_dependent/Koha/Item.t .. 5/25 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '987-988' for key 'PRIMARY' at /kohadevbox/koha/Koha/Item.pm line 1601
Comment 505 Martin Renvoize 2022-08-18 08:28:35 UTC
Oops, I'll work on this today.. apologies I missed it.
Comment 506 Martin Renvoize 2022-08-18 08:45:35 UTC
Created attachment 139347 [details] [review]
Bug 28854: (follow-up) Remove errant warning

Oops, I left in a bare warn from debugging.. this simply removes it; it
is unrequired.
Comment 507 Tomás Cohen Arazi 2022-08-18 12:02:48 UTC
Follow-up pushed to master. Thanks for addressing it promptly, Martin!
Comment 508 Katrin Fischer 2022-10-02 09:59:41 UTC
I notice a lot of nice additions to this are hiding in the 'Blocks' list here!
Comment 509 Martin Renvoize 2022-11-08 14:07:24 UTC
Documentation converted from google doc and merged.
Comment 510 Jonathan Druart 2023-02-02 13:19:44 UTC
All that bundle JS code in detail.tt could have been moved to a dedicated js file to keep the template under 2k lines :D
Comment 511 Martin Renvoize 2023-02-02 13:43:36 UTC
(In reply to Jonathan Druart from comment #510)
> All that bundle JS code in detail.tt could have been moved to a dedicated js
> file to keep the template under 2k lines :D

True.. it grew and grew and grew.  I'll create a follow-up bug and handle that
Comment 512 Martin Renvoize 2023-02-02 16:49:55 UTC
Bug 32802
Comment 513 Marcel de Rooy 2023-03-17 09:57:56 UTC
CREATE TABLE `item_bundles` (
  `item` int(11) NOT NULL,

Why didnt we call that itemnumber?
And why not an autoincrement id here too btw?
Comment 514 Marcel de Rooy 2023-03-22 14:06:06 UTC
Few observations while testing a dependent report:

[1] When I have a bundle with 2 items, checkout and checkin (only one barcode), I see the following on opac-detail for the missing item:

Missing from bundle 
Added to bundle 
In bundle: Learning Perl /

This message is not very clear (at the least). Should we replace this by Missing from bundle X ?


[2] Similarly, the other item says:

Added to bundle 
In bundle: Learning Perl / 

Could it be clearer to say just the latter here (In bundle X) ?


[3] Furthermore, I note that the parent biblo record that contains the host item, does not show that this item is a bundle. Should we somehow indicate that ?


[4] Things can get even more confusing when we add two host items to one parent record. If those two items contain various items, they are all referenced by the same name (biblio title of parent record). But these are different bundles.

[5] Elaborating on point 5: If you have two bundles on same biblio record, the normal display on intranet of the biblio record crashes on the second bundle:
GET /api/v1/items/2525/bundled_items: unhandled exception (Mojo::Exception)<<Can't call method "to_api" on an undefined value at /usr/share/koha/Koha/Biblio.pm line 1209.>>
NOTE: This was the case with the patches of 29099 but also WITHOUT !


I have the impression that this area needs more attention still.
Comment 515 Jonathan Druart 2023-05-24 11:14:09 UTC
(In reply to Martin Renvoize from comment #269)
> (In reply to Katrin Fischer from comment #224)
> > d) Should we be able to change contents of a bundle while it is checked out?
> > At the moment it's possible. Maybe a 'safety question'? (question/suggestion)
> 
> Fixed in follow-up.

This is not working, there is some code in the template to disable the buttons but it does not work. I have a patch to fix it, but I am wondering if it is correct to disable the edition of a bundle item that is checked out.

There is no code server-side to prevent that (and so it's currently possible).

Should we fix or remove this restriction?
Comment 516 Jonathan Druart 2023-05-24 11:15:17 UTC
(In reply to Jonathan Druart from comment #515)
> (In reply to Martin Renvoize from comment #269)
> > (In reply to Katrin Fischer from comment #224)
> > > d) Should we be able to change contents of a bundle while it is checked out?
> > > At the moment it's possible. Maybe a 'safety question'? (question/suggestion)
> > 
> > Fixed in follow-up.
> 
> This is not working, there is some code in the template to disable the
> buttons but it does not work. I have a patch to fix it, but I am wondering
> if it is correct to disable the edition of a bundle item that is checked out.
> 
> There is no code server-side to prevent that (and so it's currently
> possible).
> 
> Should we fix or remove this restriction?

See bug 33817.
Comment 517 Katrin Fischer 2023-07-01 11:30:24 UTC
*** Bug 28602 has been marked as a duplicate of this bug. ***
Comment 518 Marcel de Rooy 2023-09-22 07:06:16 UTC
Martin, should the dbrev be changed as follows:

diff --git a/installer/data/mysql/db_revs/220600015.pl b/installer/data/mysql/db_revs/220600015.pl
index 89dc2d628b..11298b6860 100755
--- a/installer/data/mysql/db_revs/220600015.pl
+++ b/installer/data/mysql/db_revs/220600015.pl
@@ -26,7 +26,7 @@ return {
         $lost_val++;

         $dbh->do(qq{
-           INSERT INTO authorised_values (category,authorised_value,lib) VALUES ('LOST',$lost_val,'Missing from bundle')
+           INSERT IGNORE INTO authorised_values (category,authorised_value,lib) VALUES ('LOST',$lost_val,'Missing from bundle')
         });
         say $out "Missing from bundle LOST AV added";

@@ -34,7 +34,7 @@ return {
         $nfl_val++;

         $dbh->do(qq{
-           INSERT INTO authorised_values (category,authorised_value,lib) VALUES ('NOT_LOAN',$nfl_val,'Added to bundle')
+           INSERT IGNORE INTO authorised_values (category,authorised_value,lib) VALUES ('NOT_LOAN',$nfl_val,'Added to bundle')
         });
         say $out "Added to bundle NOT_LOAN AV added";


The dbrev crashes on a FK constraint when run twice in the context of bug 34683
Comment 519 Jonathan Druart 2023-09-22 08:04:04 UTC
(In reply to Marcel de Rooy from comment #518)
> Martin, should the dbrev be changed as follows:
> 
> diff --git a/installer/data/mysql/db_revs/220600015.pl
> b/installer/data/mysql/db_revs/220600015.pl
> index 89dc2d628b..11298b6860 100755
> --- a/installer/data/mysql/db_revs/220600015.pl
> +++ b/installer/data/mysql/db_revs/220600015.pl
> @@ -26,7 +26,7 @@ return {
>          $lost_val++;
> 
>          $dbh->do(qq{
> -           INSERT INTO authorised_values (category,authorised_value,lib)
> VALUES ('LOST',$lost_val,'Missing from bundle')
> +           INSERT IGNORE INTO authorised_values
> (category,authorised_value,lib) VALUES ('LOST',$lost_val,'Missing from
> bundle')
>          });
>          say $out "Missing from bundle LOST AV added";
> 
> @@ -34,7 +34,7 @@ return {
>          $nfl_val++;
> 
>          $dbh->do(qq{
> -           INSERT INTO authorised_values (category,authorised_value,lib)
> VALUES ('NOT_LOAN',$nfl_val,'Added to bundle')
> +           INSERT IGNORE INTO authorised_values
> (category,authorised_value,lib) VALUES ('NOT_LOAN',$nfl_val,'Added to
> bundle')
>          });
>          say $out "Added to bundle NOT_LOAN AV added";
> 
> 
> The dbrev crashes on a FK constraint when run twice in the context of bug
> 34683

Note that's not the problem. We should not add the AV if one exists for "Missing from bundle", the IGNORE won't work here, and we will keep add one other "Missing from bundle".
Comment 520 Marcel de Rooy 2023-09-22 08:18:55 UTC
(In reply to Jonathan Druart from comment #519)
> Note that's not the problem. We should not add the AV if one exists for
> "Missing from bundle", the IGNORE won't work here, and we will keep add one
> other "Missing from bundle".

Agreed. IGNORE just ignores :) We could do better.
Comment 521 Martin Renvoize 2023-09-22 09:37:38 UTC
(In reply to Marcel de Rooy from comment #520)
> (In reply to Jonathan Druart from comment #519)
> > Note that's not the problem. We should not add the AV if one exists for
> > "Missing from bundle", the IGNORE won't work here, and we will keep add one
> > other "Missing from bundle".
> 
> Agreed. IGNORE just ignores :) We could do better.

Bug 34881