Bugzilla – Attachment 137055 Details for
Bug 31083
Part name (245$p) breaks item bundle detail view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31083: Fix part_name handling in js-biblio-format
Bug-31083-Fix-partname-handling-in-js-biblio-forma.patch (text/plain), 2.24 KB, created by
Martin Renvoize (ashimema)
on 2022-07-04 10:51:51 UTC
(
hide
)
Description:
Bug 31083: Fix part_name handling in js-biblio-format
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-07-04 10:51:51 UTC
Size:
2.24 KB
patch
obsolete
>From 4397dbff5782b6aebbf010d7bdc9bb09512946c5 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 4 Jul 2022 11:49:00 +0100 >Subject: [PATCH] Bug 31083: Fix part_name handling in js-biblio-format > >This patch corrects the typo introduced in bug 28854 for part_name >handling in the js-biblio-format include. We also introduce proper >whitespace addition when concatenating subtitle, medium and parts to the >title string. >--- > .../intranet-tmpl/prog/en/includes/js-biblio-format.inc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc >index fe43954c22..f953337856 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc >@@ -23,7 +23,7 @@ > > // add subtitle > if (biblio.subtitle != null && biblio.subtitle != '') { >- title += '<span class="biblio-subtitle">' + escape_str(biblio.subtitle) + '</span>'; >+ title += ' <span class="biblio-subtitle">' + escape_str(biblio.subtitle) + '</span>'; > } > > // set title as link >@@ -41,7 +41,7 @@ > > // add medium > if (biblio.medium != null && biblio.medium != '') { >- title += '<span class="biblio-medium">' + escape_str(biblio.medium) + '</span>'; >+ title += ' <span class="biblio-medium">' + escape_str(biblio.medium) + '</span>'; > } > > // add part numbers/names >@@ -50,10 +50,10 @@ > let i = 0; > while (part_numbers[i] || part_names[i]) { > if (part_numbers[i]) { >- title += '<span class="part-number">' + escape_str(part_numbers[i]) + '</span>'; >+ title += ' <span class="part-number">' + escape_str(part_numbers[i]) + '</span>'; > } > if (part_names[i]) { >- title += '<span class="part-name">' + escape_str(part_name[i]) + '</span>'; >+ title += ' <span class="part-name">' + escape_str(part_names[i]) + '</span>'; > } > i++; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31083
:
137055
|
137402