When displaying the contents of an item bundle, it would be nice to have more complete item information including the subtitle, part_name and part_number field as this helps greatly in identifying records especially for such things as language materials.
So, for me this is already working in bug 28854.. I've tested against subtitles especially but the code is also there for part numbers/names.
I think it was an issue with the sample data. I've checked the mappings and updated records to make sure the fields are set in the database. It does work, but we are missing spaces between the fields: CSS :the definitive guide / Should be: CSS : the definitive guide / Also, when I add a part_name (245$p) the bundle manage view throws an error and sends the display into eternal processing: Uncaught ReferenceError: part_name is not defined My catalogued 245 was: 245 1 0 _aCSS : _bthe definitive guide / _cEric A. Meyer. _nnumber1 _ppart1 _nnumber2 _ppart2
Created attachment 137055 [details] [review] Bug 31083: Fix part_name handling in js-biblio-format This patch corrects the typo introduced in bug 28854 for part_name handling in the js-biblio-format include. We also introduce proper whitespace addition when concatenating subtitle, medium and parts to the title string.
Good catch.. I hadn't tested the part_name piece of this and had introduced a typo! I also add in some whitespace handling for the various title parts as prior to now the title and subtitle and other fields would all be concatenated without spaces between.
Created attachment 137402 [details] [review] Bug 31083: Fix part_name handling in js-biblio-format This patch corrects the typo introduced in bug 28854 for part_name handling in the js-biblio-format include. We also introduce proper whitespace addition when concatenating subtitle, medium and parts to the title string. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Missing dependencies for 22.05.x, no backport