Bugzilla – Attachment 138849 Details for
Bug 27779
Cashup summary 'refunds' should denote what the refund was actioned against
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27779: (QA follow-up) Better translatability
Bug-27779-QA-follow-up-Better-translatability.patch (text/plain), 2.81 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-08-08 18:42:00 UTC
(
hide
)
Description:
Bug 27779: (QA follow-up) Better translatability
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-08-08 18:42:00 UTC
Size:
2.81 KB
patch
obsolete
>From 7b4a2fd988bdbefe7f6ef4a7665b3f41e1379018 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 8 Aug 2022 15:41:36 -0300 >Subject: [PATCH] Bug 27779: (QA follow-up) Better translatability > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > koha-tmpl/intranet-tmpl/prog/js/cashup_modal.js | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cashup_modal.js b/koha-tmpl/intranet-tmpl/prog/js/cashup_modal.js >index 3cc7914c5e0..ad7bd6aa83b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cashup_modal.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cashup_modal.js >@@ -19,15 +19,15 @@ $(document).ready(function() { > var tbody = summary_modal.find('tbody') > tbody.empty(); > for (out of data.summary.payout_grouped) { >- if ( out.credit_type_code == 'REFUND' ) { >- tbody.append('<tr><td>' + out.credit_type.description + ' ' + __("against") + ' ' + out.related_debit.debit_type.description + '</td><td>- ' + out.total + '</td></tr>'); >+ if (out.credit_type_code == 'REFUND') { >+ tbody.append('<tr><td>' + __x('{credit_type_description} against {debit_type_description}', { 'credit_type_description': escape_str(out.credit_type.description), 'debit_type_description': escape_str(out.related_debit.debit_type.description) }) + '</td><td>- ' + out.total.format_price() + '</td></tr>'); > } else { >- tbody.append('<tr><td>' + out.credit_type.description + '</td><td>- ' + out.total + '</td></tr>'); >+ tbody.append('<tr><td>' + escape_str(out.credit_type.description) + '</td><td>- ' + out.total.format_price() + '</td></tr>'); > } > } > > for (income of data.summary.income_grouped) { >- tbody.append('<tr><td>' + income.debit_type.description + '</td><td>' + income.total.format_price() + '</td></tr>'); >+ tbody.append('<tr><td>' + escape_str(income.debit_type.description) + '</td><td>' + income.total.format_price() + '</td></tr>'); > } > > var tfoot = summary_modal.find('tfoot'); >@@ -35,7 +35,7 @@ $(document).ready(function() { > tfoot.append('<tr><td>Total</td><td>' + data.summary.total.format_price() + '</td></tr>'); > for (type of data.summary.total_grouped) { > if (type.total !== 0) { >- tfoot.append('<tr><td>' + type.payment_type + '</td><td>' + type.total.format_price() + '</td></tr>'); >+ tfoot.append('<tr><td>' + escape_str(type.payment_type) + '</td><td>' + type.total.format_price() + '</td></tr>'); > } > } > } >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27779
:
121218
|
121219
|
121224
|
121225
|
127552
|
127553
|
127554
|
130024
|
136491
|
136492
|
136493
|
136494
|
136495
|
137386
|
137387
|
137388
|
137389
|
137390
|
138809
|
138810
|
138811
|
138812
|
138813
|
138849
|
138883
|
138884