Bug 27779 - Cashup summary 'refunds' should denote what the refund was actioned against.
Summary: Cashup summary 'refunds' should denote what the refund was actioned against.
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 26272 26273
Blocks: 13985
  Show dependency treegraph
 
Reported: 2021-02-24 16:39 UTC by Martin Renvoize
Modified: 2021-05-20 07:52 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27779: Group payouts by type of debit they're applied against (5.22 KB, patch)
2021-05-20 07:50 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 27779: Update 'REFUND' description in the database (1.97 KB, patch)
2021-05-20 07:50 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 27779: Group payouts by type of debit they're applied against (5.22 KB, patch)
2021-05-20 07:50 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 27779: Update 'REFUND' description in the database (1.97 KB, patch)
2021-05-20 07:50 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2021-02-24 16:39:53 UTC
Currently, we group 'Refunds' together in one group. It would be preferable to group them by the type of transaction they're refunding.
Comment 1 Martin Renvoize 2021-05-20 07:50:02 UTC
Created attachment 121218 [details] [review]
Bug 27779: Group payouts by type of debit they're applied against

This patch adds additional grouping to the cashup summary output such
that payouts are additionally grouped by the types of debit they're
applied against.  The cashup sumary modal is adapted to expose the
descriptions at the grouping level too.

Test plan
1/ Add a various transactions using a cash register (Using Point of
Sale, Patron Accounts with payments etc).
2/ Refund some of the debts and pick the 'cash' option for payout.
(ensure you pick a variety of debit types)
3/ Add some credit to a patron account, (either refund a debt as
'credit' or add a 'manual credit')
4/ Payout the credit as 'cash' on the patron account
5/ Cashup the register
6/ Inspect the cashup summary for your cashup.
Comment 2 Martin Renvoize 2021-05-20 07:50:06 UTC
Created attachment 121219 [details] [review]
Bug 27779: Update 'REFUND' description in the database

This patch simplified the REFUND description from 'Refund applied
to a patrons fine' to simply 'Refund'.. this allows the description to
be combined with debit type descriptions simply to denote what it was
applied against instead of using the generic 'applied to a patrons fine'
Comment 3 Martin Renvoize 2021-05-20 07:50:43 UTC
Created attachment 121224 [details] [review]
Bug 27779: Group payouts by type of debit they're applied against

This patch adds additional grouping to the cashup summary output such
that payouts are additionally grouped by the types of debit they're
applied against.  The cashup sumary modal is adapted to expose the
descriptions at the grouping level too.

Test plan
1/ Add a various transactions using a cash register (Using Point of
Sale, Patron Accounts with payments etc).
2/ Refund some of the debts and pick the 'cash' option for payout.
(ensure you pick a variety of debit types)
3/ Add some credit to a patron account, (either refund a debt as
'credit' or add a 'manual credit')
4/ Payout the credit as 'cash' on the patron account
5/ Cashup the register
6/ Inspect the cashup summary for your cashup.
Comment 4 Martin Renvoize 2021-05-20 07:50:49 UTC
Created attachment 121225 [details] [review]
Bug 27779: Update 'REFUND' description in the database

This patch simplified the REFUND description from 'Refund applied
to a patrons fine' to simply 'Refund'.. this allows the description to
be combined with debit type descriptions simply to denote what it was
applied against instead of using the generic 'applied to a patrons fine'