Bugzilla – Attachment 138950 Details for
Bug 27342
Improve readability and improvement of C4::Auth::get_template_and_user
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27342: (QA follow-up) Remove dbh from new tests
Bug-27342-QA-follow-up-Remove-dbh-from-new-tests.patch (text/plain), 1.16 KB, created by
Martin Renvoize (ashimema)
on 2022-08-10 07:15:08 UTC
(
hide
)
Description:
Bug 27342: (QA follow-up) Remove dbh from new tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-08-10 07:15:08 UTC
Size:
1.16 KB
patch
obsolete
>From e2adcb88e58ba2a506f53e8c3457636b5ce0cf4c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 10 Aug 2022 08:12:53 +0100 >Subject: [PATCH] Bug 27342: (QA follow-up) Remove dbh from new tests > >--- > t/db_dependent/Auth.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t >index 8d68168f8f..ad7f9ddc03 100755 >--- a/t/db_dependent/Auth.t >+++ b/t/db_dependent/Auth.t >@@ -524,11 +524,11 @@ subtest 'Check value of login_attempts in checkpw' => sub { > my $patron = $builder->build_object({ class => 'Koha::Patrons' }); > $patron->set_password({ password => '123', skip_validation => 1 }); > >- my @test = checkpw( $dbh, $patron->userid, '123', undef, 'opac', 1 ); >+ my @test = checkpw( $patron->userid, '123', undef, 'opac', 1 ); > is( $test[0], 1, 'Patron authenticated correctly' ); > > $patron->password_expiration_date('2020-01-01')->store; >- @test = checkpw( $dbh, $patron->userid, '123', undef, 'opac', 1 ); >+ @test = checkpw( $patron->userid, '123', undef, 'opac', 1 ); > is( $test[0], -2, 'Patron returned as expired correctly' ); > > }; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27342
:
114874
|
114875
|
132024
|
132025
|
138948
|
138949
| 138950 |
139196
|
139294