Bug 27342 - Improve readability and improvement of C4::Auth::get_template_and_user
Summary: Improve readability and improvement of C4::Auth::get_template_and_user
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 27341
  Show dependency treegraph
 
Reported: 2021-01-05 13:49 UTC by Jonathan Druart
Modified: 2022-03-22 14:39 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27342: Improve test for OPAC (837 bytes, patch)
2021-01-05 14:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 27342: Remove dbh from C4::Auth (26.42 KB, patch)
2021-01-05 14:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 27342: Improve test for OPAC (839 bytes, patch)
2022-03-22 14:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 27342: Remove dbh from C4::Auth (25.55 KB, patch)
2022-03-22 14:17 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2021-01-05 13:49:34 UTC

    
Comment 1 Jonathan Druart 2021-01-05 14:16:28 UTC
Created attachment 114874 [details] [review]
Bug 27342: Improve test for OPAC

We don't need to build allowed_scripts_for_private_opac for staff
Comment 2 Jonathan Druart 2021-01-05 14:16:31 UTC
Created attachment 114875 [details] [review]
Bug 27342: Remove dbh from C4::Auth

We must not pass $dbh but retrieve it when needed instead
Comment 3 David Cook 2021-01-05 23:05:07 UTC
This looks like it will be tough to test although I think it's worth doing.
Comment 4 Martin Renvoize 2021-02-23 14:07:28 UTC
Nice little cleanup here.. clear to read and review..  are you continuing here Jonathan or is this a first bug where you intend to continue on other bugs?
Comment 5 Jonathan Druart 2022-03-22 14:17:28 UTC
Created attachment 132024 [details] [review]
Bug 27342: Improve test for OPAC

We don't need to build allowed_scripts_for_private_opac for staff
Comment 6 Jonathan Druart 2022-03-22 14:17:32 UTC
Created attachment 132025 [details] [review]
Bug 27342: Remove dbh from C4::Auth

We must not pass $dbh but retrieve it when needed instead
Comment 7 Jonathan Druart 2022-03-22 14:17:44 UTC
There is not much here but I think it can go anyway.