Bugzilla – Attachment 138952 Details for
Bug 29723
Add a "Configure table" button for KohaTable tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29723: (QA follow-up) Make button text translatable
Bug-29723-QA-follow-up-Make-button-text-translatab.patch (text/plain), 2.69 KB, created by
Martin Renvoize (ashimema)
on 2022-08-10 08:18:32 UTC
(
hide
)
Description:
Bug 29723: (QA follow-up) Make button text translatable
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-08-10 08:18:32 UTC
Size:
2.69 KB
patch
obsolete
>From c155d14bc83407cafa02bd79038b7768b744339c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 10 Aug 2022 08:36:18 +0100 >Subject: [PATCH] Bug 29723: (QA follow-up) Make button text translatable > >This patch makes the button text translatable. Whilst we're here I also added a wrench icon, >set the title attribute and added a class. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc | 4 +++- > koha-tmpl/intranet-tmpl/prog/js/datatables.js | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >index 27a7cbba69..f7aa0b6278 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >@@ -164,7 +164,9 @@ function KohaTable(id_selector, dt_parameters, table_settings, add_filters) { > if ( CAN_user_parameters_manage_column_config ) { > dt_parameters[ "buttons" ].push( > { >- text: 'Configure this table', >+ className: "dt_button_configure_table", >+ titleAttr: __("Configure this table"), >+ text: '<i class="fa fa-lg fa-wrench"></i> <span class="dt-button-text">' + _("Configure this table") + '</span>', > action: function() { > window.location = '/cgi-bin/koha/admin/columns_settings.pl?module=' + table_settings['module'] + '#' + table_settings['page'] + '#' + table_settings['table']; > }, >diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >index c5f346f60e..5db03da28c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >@@ -816,7 +816,9 @@ jQuery.fn.dataTable.ext.errMode = function(settings, note, message) { > if ( CAN_user_parameters_manage_column_config ) { > settings[ "buttons" ].push( > { >- text: 'Configure this table', >+ className: "dt_button_configure_table", >+ titleAttr: __("Configure this table"), >+ text: '<i class="fa fa-lg fa-wrench"></i> <span class="dt-button-text">' + __("Configure this table") + '</span>', > action: function() { > window.location = '/cgi-bin/koha/admin/columns_settings.pl?module=' + table_settings['module'] + '#' + table_settings['page'] + '#' + table_settings['table']; > }, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29723
:
128648
|
131874
|
133029
|
138951
|
138952
|
138972
|
138973
|
138974
|
138975
|
138985
|
138986
|
138987
|
138988
|
138989
|
138992
|
138993
|
138994
|
138995
|
138996
|
138997
|
138998
|
138999
|
139000
|
139002
|
139003
|
139004
|
139005
|
139006
|
139194