We could have a "Configure table" link/button on the table that are a "KohaTable" table that can be configurable in the administration area.
Created attachment 128648 [details] [review] Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin?
Owen, do you think we need this?
Created attachment 131874 [details] [review] Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I suspect the "Configure table" button would only appear if one had the correct permissions. I think it's a nice idea since it can be difficult to determine what you need to edit from columns_settings.pl. +1
Jonathan, The patch looks nice. The QA tool says you need a filter: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc FAIL filters missing_filter at line 28 (var CAN_user_parameters_manage_column_config = [% CAN_user_parameters_manage_column_config ? 1 : 0 %];)
Created attachment 133029 [details] [review] Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin?
(In reply to Lucas Gass from comment #5) > Jonathan, > > The patch looks nice. The QA tool says you need a filter: > > FAIL koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc > FAIL filters > missing_filter at line 28 (var CAN_user_parameters_manage_column_config = > [% CAN_user_parameters_manage_column_config ? 1 : 0 %];) Fixed, thanks Lucas!
> Note that the link is correct but the scrollbar is not adjusted at the > correct position. Maybe we could improve that switching to the bootstrap > accordion plugin? Is this because those <div>'s have ID's like: "detail#holdings_table" or "member#memberresultst". I suppose this is a valid ID but I think it gets messed up when we try to apply the in page anchor to the URL: "http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl?module=catalogue#detail#holdings_table" Maybe a separate bug?
Created attachment 138951 [details] [review] Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 138952 [details] [review] Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thought I'd have a go at rescuing this one.. it needs a bit of adaptation for bug 30494 now we're using bootstrap collapse as opposed to jQuery accordion. I feel like we should update the column settings page to add id's to each of the card expand headings that match the module names instead of using our current index approach.. then we can pass module from here to at least restore opening the right panel.. hopefully we can also come up with a solution to hit the right anchor on the page.
Indeed, this needs to be rethink.
Created attachment 138972 [details] [review] Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 138973 [details] [review] Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 138974 [details] [review] Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded.
Created attachment 138975 [details] [review] Bug 29723: Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration
OK, I'm happy this now works as one would expect.. However, I'd still love to refine it a little further.. I don't like that the query parameters I'm passing stay in the URL.. not sure how to resolve that. My scroll feels a little hacky to, but so far it's the best I could come up with.
It does not work from this table: /cgi-bin/koha/circ/pendingreserves.pl
Good catch.. anoying that we're not consistent with our panel name/id's vs module names.
Created attachment 138985 [details] [review] Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 138986 [details] [review] Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 138987 [details] [review] Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded.
Created attachment 138988 [details] [review] Bug 29723: (QA follow-up) Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration
Created attachment 138989 [details] [review] Bug 29723: (QA follow-up) Ensure ID's match Module names There was a disparity between module codes and how it was used to construct ID's for various elements.. this patch updates ID's to match codes for circulation and illrequests.
*** Bug 26863 has been marked as a duplicate of this bug. ***
Created attachment 138992 [details] [review] Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew <andrewfh@dubcolib.org>
Created attachment 138993 [details] [review] Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew <andrewfh@dubcolib.org>
Created attachment 138994 [details] [review] Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded. Signed-off-by: Andrew <andrewfh@dubcolib.org>
Created attachment 138995 [details] [review] Bug 29723: (QA follow-up) Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration Signed-off-by: Andrew <andrewfh@dubcolib.org>
Created attachment 138996 [details] [review] Bug 29723: (QA follow-up) Ensure ID's match Module names There was a disparity between module codes and how it was used to construct ID's for various elements.. this patch updates ID's to match codes for circulation and illrequests. Signed-off-by: Andrew <andrewfh@dubcolib.org>
Created attachment 138997 [details] [review] Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 138998 [details] [review] Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 138999 [details] [review] Bug 29723: (QA follow-up) Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 139000 [details] [review] Bug 29723: (QA follow-up) Ensure ID's match Module names There was a disparity between module codes and how it was used to construct ID's for various elements.. this patch updates ID's to match codes for circulation and illrequests. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thanks, Martin!
Created attachment 139002 [details] [review] Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew <andrewfh@dubcolib.org>
Created attachment 139003 [details] [review] Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 139004 [details] [review] Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded. Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 139005 [details] [review] Bug 29723: (QA follow-up) Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 139006 [details] [review] Bug 29723: (QA follow-up) Ensure ID's match Module names There was a disparity between module codes and how it was used to construct ID's for various elements.. this patch updates ID's to match codes for circulation and illrequests. Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I hadn't noticed we overlapped, Andrew. I've reattached the patches with your stamp!
(In reply to Jonathan Druart from comment #41) > I hadn't noticed we overlapped, Andrew. I've reattached the patches with > your stamp! No worries! The status was still Signed Off, so I wasn't sure if it needed another or not, but I was excited to see it in action :)
Thanks everyone, great to see this over the line.
Created attachment 139194 [details] [review] Bug 29723: (QA follow-up) _ vs __ Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Enhancement will not be backported to 22.05.x series
Documenting this now.