Bugzilla – Attachment 139129 Details for
Bug 30580
GetItemsAvailableToFillHoldRequestsForBib should get transfers during initial query
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30580: Unit test
Bug-30580-Unit-test.patch (text/plain), 1.62 KB, created by
Nick Clemens (kidclamp)
on 2022-08-15 13:53:16 UTC
(
hide
)
Description:
Bug 30580: Unit test
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-08-15 13:53:16 UTC
Size:
1.62 KB
patch
obsolete
>From 96d30a43dfb9d940bd761a7a61754e9803a8a8f4 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 15 Aug 2022 13:34:02 +0000 >Subject: [PATCH] Bug 30580: Unit test > >--- > t/db_dependent/HoldsQueue.t | 23 ++++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t >index 7067931c35..8b079be96e 100755 >--- a/t/db_dependent/HoldsQueue.t >+++ b/t/db_dependent/HoldsQueue.t >@@ -8,7 +8,7 @@ > > use Modern::Perl; > >-use Test::More tests => 58; >+use Test::More tests => 59; > use Data::Dumper; > > use C4::Calendar qw( new insert_single_holiday ); >@@ -1817,3 +1817,24 @@ subtest "GetHoldsQueueItems" => sub { > > $schema->storage->txn_rollback; > }; >+ >+subtest "GetItemsAvailableToFillHoldsRequestsForBib" => sub { >+ plan tests => 2; >+ >+ $schema->storage->txn_begin; >+ >+ my $item_1 = $builder->build_sample_item(); >+ my $item_2 = $builder->build_sample_item({ biblionumber => $item_1->biblionumber }); >+ my $item_3 = $builder->build_sample_item({ biblionumber => $item_1->biblionumber }); >+ >+ my $transfer = $builder->build_object({ class => 'Koha::Item::Transfers', value => { >+ itemnumber => $item_1->itemnumber, >+ datearrived => undef, >+ datecancelled => undef >+ }}); >+ >+ my $items = C4::HoldsQueue::GetItemsAvailableToFillHoldRequestsForBib( $item_1->biblionumber ); >+ is( scalar @$items, 2, "Two items without transfers correctly retrieved"); >+ is_deeply( [$items->[0]->{itemnumber},$items->[1]->{itemnumber}],[$item_2->itemnumber,$item_3->itemnumber],"Correct two items retrieved"); >+}; >+ >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30580
:
133560
|
136797
| 139129 |
139130