Currently we get the items, then loop over them checking for transfers - we can simply join to branch transfers in the initial query
Created attachment 133560 [details] [review] Bug 30580: Don't use GetTransfers in GetItemsAvailableToFillHoldRequestsForBib This patch simply moves the check for transfers into the initial query To test: 1 - Place some holds that show in the holds queue 2 - Add a manual transfer to one item 3 - Confirm it no longer hsows in the queue 4 - Apply patch 5 - Confirm item still does not appear in the queue
Created attachment 136797 [details] [review] Bug 30580: Don't use GetTransfers in GetItemsAvailableToFillHoldRequestsForBib This patch simply moves the check for transfers into the initial query Test result: Works as intended To test: 1 - Place some holds that show in the holds queue 2 - Add a manual transfer to one item 3 - Confirm it no longer hsows in the queue 4 - Apply patch 5 - Confirm item still does not appear in the queue Signed-off-by: Michal Urban <michalurban177@gmail.com>
Arf method GetItemsAvailableToFillHoldRequestsForBib does not have a unit test yet. Please create one. It will ensure this change is harmless.
Setting to Failed QA to make this show on Nick's radar :)
Created attachment 139129 [details] [review] Bug 30580: Unit test
Created attachment 139130 [details] [review] Bug 30580: Don't use GetTransfers in GetItemsAvailableToFillHoldRequestsForBib This patch simply moves the check for transfers into the initial query To test: 1 - Place some holds that show in the holds queue 2 - Add a manual transfer to one item 3 - Confirm it no longer hsows in the queue 4 - Apply patch 5 - Confirm item still does not appear in the queue
This appears to be duplicate of bug 24295. Nick, could you attach the unit test you made here to bug 24295 as it doesn't have it? A QA round would be nice as well, so we could get the patches pushed on the same go :) *** This bug has been marked as a duplicate of bug 24295 ***