Bugzilla – Attachment 139683 Details for
Bug 30483
Do not allow NULL in issues.borrowernumber and issues.itemnumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30483: (DBIx schema) Changes to Issue.pm
Bug-30483-DBIx-schema-Changes-to-Issuepm.patch (text/plain), 2.75 KB, created by
Martin Renvoize (ashimema)
on 2022-08-23 14:48:40 UTC
(
hide
)
Description:
Bug 30483: (DBIx schema) Changes to Issue.pm
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-08-23 14:48:40 UTC
Size:
2.75 KB
patch
obsolete
>From 81b34e90959b37e81c073418971294df5d589ca9 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 16 Aug 2022 13:40:59 +0000 >Subject: [PATCH] Bug 30483: (DBIx schema) Changes to Issue.pm > >Compare with results of update_dbix_class_files.pl. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Schema/Result/Issue.pm | 26 ++++++++------------------ > 1 file changed, 8 insertions(+), 18 deletions(-) > >diff --git a/Koha/Schema/Result/Issue.pm b/Koha/Schema/Result/Issue.pm >index 9b727a04cc..03a82dff63 100644 >--- a/Koha/Schema/Result/Issue.pm >+++ b/Koha/Schema/Result/Issue.pm >@@ -35,7 +35,7 @@ primary key for issues table > > data_type: 'integer' > is_foreign_key: 1 >- is_nullable: 1 >+ is_nullable: 0 > > foreign key, linking this to the borrowers table for the patron this item was checked out to > >@@ -51,7 +51,7 @@ foreign key, linking this to the borrowers table for the user who checked out th > > data_type: 'integer' > is_foreign_key: 1 >- is_nullable: 1 >+ is_nullable: 0 > > foreign key, linking this to the items table for the item that was checked out > >@@ -172,11 +172,11 @@ __PACKAGE__->add_columns( > "issue_id", > { data_type => "integer", is_auto_increment => 1, is_nullable => 0 }, > "borrowernumber", >- { data_type => "integer", is_foreign_key => 1, is_nullable => 1 }, >+ { data_type => "integer", is_foreign_key => 1, is_nullable => 0 }, > "issuer_id", > { data_type => "integer", is_foreign_key => 1, is_nullable => 1 }, > "itemnumber", >- { data_type => "integer", is_foreign_key => 1, is_nullable => 1 }, >+ { data_type => "integer", is_foreign_key => 1, is_nullable => 0 }, > "date_due", > { > data_type => "datetime", >@@ -272,12 +272,7 @@ __PACKAGE__->belongs_to( > "borrowernumber", > "Koha::Schema::Result::Borrower", > { borrowernumber => "borrowernumber" }, >- { >- is_deferrable => 1, >- join_type => "LEFT", >- on_delete => "RESTRICT", >- on_update => "CASCADE", >- }, >+ { is_deferrable => 1, on_delete => "RESTRICT", on_update => "CASCADE" }, > ); > > =head2 issuer >@@ -312,17 +307,12 @@ __PACKAGE__->belongs_to( > "itemnumber", > "Koha::Schema::Result::Item", > { itemnumber => "itemnumber" }, >- { >- is_deferrable => 1, >- join_type => "LEFT", >- on_delete => "RESTRICT", >- on_update => "CASCADE", >- }, >+ { is_deferrable => 1, on_delete => "RESTRICT", on_update => "CASCADE" }, > ); > > >-# Created by DBIx::Class::Schema::Loader v0.07049 @ 2022-03-11 15:10:14 >-# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:TERiBbm+B4jMEuNM2dVbfQ >+# Created by DBIx::Class::Schema::Loader v0.07049 @ 2022-08-16 13:40:46 >+# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:82k6dsQbnfsisYZSmpKyTg > > __PACKAGE__->add_columns( > '+auto_renew' => { is_boolean => 1 }, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30483
:
133079
|
133080
|
139195
|
139682
|
139683
|
139924
|
139925