Sync problem between structure and dbrevs.
For old prod databases only (that passed the 3.05 dbrevs)
Note that I did not expect such a difference in a vital table like issues !
update $DBversion = "3.05.00.009"; $dbh->do("ALTER TABLE issues MODIFY COLUMN borrowernumber int(11) NOT NULL"); $dbh->do("ALTER TABLE issues MODIFY COLUMN itemnumber int(11) NOT NULL");
Current structure allows them to be NULL.
I wonder if that is correct. An issue should have a borrower and an item, right?
Created attachment 133079 [details] [review]
Bug 30483: Make issues.borrowernumber and itemnumber NOT NULL
Note: This change does NOT apply to old_issues, where constraints
may result in nullifying these columns.
Try checkout, checkin.
Created attachment 133080 [details] [review]
Bug 30483: DBIx changes for issues table
Note: You may observe that DBIx drops the LEFT join_type here.
There is no reason to be worried about that. If a FK column
allows NULL values, DBIx sets it to LEFT. We remove the NULL
here and DBIx now defaults to INNER again.
No test plan.
Signed-off-by: Marcel de Rooy <firstname.lastname@example.org>