Attachment 1411 Details for Bug 3550 – Additional fix

[patch] Additional fix

0001-Improve-display-of-information-on-Transfers-to-your-.patch (text/plain), 5.65 KB, created by Chris Cormack on 2010-03-11 13:55:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2010-03-11 13:55:00 UTC

Size: 5.65 KB

patch

obsolete

>From 3b0f8537176b4af41a5eb00babdcac8a2d374f98 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 18 Feb 2010 09:44:51 -0500
>Subject: [PATCH] Improve display of information on Transfers to your library report
>
>- Use GetRecordValue() to show subtitle
>- Show author
>- Separate branch and call number display for better sorting
>- Correct teriminology (reserve -> hold)
>---
> circ/transferstoreceive.pl                         |    5 ++++-
> .../prog/en/modules/circ/transferstoreceive.tmpl   |   20 +++++++++++---------
> 2 files changed, 15 insertions(+), 10 deletions(-)
>
>diff --git a/circ/transferstoreceive.pl b/circ/transferstoreceive.pl
>index ddb7f4a..3073c0a 100755
>--- a/circ/transferstoreceive.pl
>+++ b/circ/transferstoreceive.pl
>@@ -91,10 +91,13 @@ foreach my $br ( keys %$branches ) {
> 
>             $getransf{'datetransfer'} = format_date( $num->{'datesent'} );
>             $getransf{'itemtype'} = $itemtypeinfo ->{'description'};
>-			foreach (qw(title biblionumber itemnumber barcode homebranch holdingbranch itemcallnumber)) {
>+			foreach (qw(title author biblionumber itemnumber barcode homebranch holdingbranch itemcallnumber)) {
>             	$getransf{$_} = $gettitle->{$_};
> 			}
> 
>+            my $record = GetMarcBiblio($gettitle->{'biblionumber'});
>+            $getransf{'subtitle'} = GetRecordValue('subtitle', $record, GetFrameworkCode($gettitle->{'biblionumber'}));
>+
>             # we check if we have a reserv for this transfer
>             my @checkreserv = GetReservesFromItemnumber($num->{'itemnumber'} );
>             if ( $checkreserv[0] ) {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tmpl
>index 8ee68eb..0a5010f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tmpl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tmpl
>@@ -15,8 +15,8 @@ $(document).ready(function() {
>     $.tablesorter.defaults.widgets = ['zebra'];
>     $("#transferst").tablesorter({
>         dateFormat: 'uk',
>-        sortList: [[1,0]],
>-        headers: { 1: { sorter: 'articles' },4:{sorter:false}}
>+        sortList: [[0,0]],
>+        headers: { 1: { sorter: 'articles' }}
>     });
>     
> });
>@@ -47,8 +47,9 @@ $(document).ready(function() {
>             <thead><tr>
>                 <th>Date of transfer</th>
>                 <th>Title</th>
>-                <th>Reserved by </th>
>-                <th>Location</th>
>+                <th>On hold for</th>
>+                <th>Home library</th>
>+                <th>Call no.</th>
>             </tr></thead>
>             <tbody>
>                 
>@@ -59,12 +60,12 @@ $(document).ready(function() {
>                     <td><p></p> <span class="error">Transfer is  days late</span></td>
>                     <td><span style="display:none;"></span>
>                         
>-<a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber="></a>
>+<a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=">  </a>
> 
>-<a href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber="></a>
>+<a href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=">  </a>
> 
>-<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=">  </a>
>-                            &nbsp; (<b></b>)
>+<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=">  </a> by 
>+                            &nbsp; (<b></b>)
>                             <br />Barcode: 
>                     </td>
>                     <td>
>@@ -81,7 +82,8 @@ $(document).ready(function() {
>                         <p>None</p>
>                     
>                     </td>
>-                    <td> </td>
>+                    <td></td>
>+                    <td></td>
>                 </tr>
>             </tbody>
>             </table>
>-- 
>1.6.3.3
>

Actions: View | Diff | Splinter Review

Attachments on bug 3550: 1408 | 1409 | 1410 | 1411 | 2967 | 3192