Bug 3550 - Use GetRecordValue to get the subtitle
Summary: Use GetRecordValue to get the subtitle
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on: 7074
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-25 09:52 UTC by Nahuel Angelinetti
Modified: 2013-12-05 20:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
bugfix (7.71 KB, patch)
2009-08-25 09:55 UTC, Chris Cormack
Details | Diff | Splinter Review
followup (4.17 KB, patch)
2009-08-26 11:58 UTC, Chris Cormack
Details | Diff | Splinter Review
Proposed additional fixes (18.56 KB, patch)
2010-02-12 14:54 UTC, Chris Cormack
Details | Diff | Splinter Review
Additional fix (5.65 KB, patch)
2010-03-11 13:55 UTC, Chris Cormack
Details | Diff | Splinter Review
Proposed fix for reserveratios.pl (3.45 KB, patch)
2011-01-07 20:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Supplementary patch (4.02 KB, patch)
2011-02-21 16:23 UTC, Colin Campbell
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:12:01 UTC


---- Reported by nahuel.angelinetti@biblibre.com 2009-08-25 09:52:52 ----

In koha, subtitle depends of each framework, so using the GetRecordValue made it to be more generic.
This patch add the use of GetRecordValue to retrieve the subtitle and show it.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-08-25 09:55:52 ----

Created an attachment
bugfix





---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-08-26 11:58:56 ----

Created an attachment
followup





---- Additional Comments From oleonard@myacpl.org 2010-02-12 14:54:31 ----

Created an attachment
Proposed additional fixes

Making changes to other areas where subtitle should be displayed.



---- Additional Comments From gmcharlt@gmail.com 2010-02-14 19:48:53 ----

Pushed Owen's patch.  Please test and close.



---- Additional Comments From oleonard@myacpl.org 2010-03-11 13:55:28 ----

Created an attachment
Additional fix

Showing subtitle on Transfers to your library report. Also: 
- Show author
- Separate branch and call number display for better sorting
- Correct terminology (reserve -> hold)



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:12 UTC  ---

This bug was previously known as _bug_ 3550 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3550
Imported an attachment (id=1408)
Imported an attachment (id=1409)
Imported an attachment (id=1410)
Imported an attachment (id=1411)

Actual time not defined. Setting to 0.0
The original submitter of attachment 1408 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1409 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1410 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1411 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Chris Cormack 2010-12-15 07:19:46 UTC
The last patch from Owen hasn't been pushed could someone please signoff on it.

(Addition fix attachment above)
Comment 2 Owen Leonard 2011-01-07 20:27:49 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2011-01-07 20:41:03 UTC
Signed off, would like to see some of the similar things on the 'holds to pull report'. I have added a 'see also' url to that other enhancement request.
Comment 4 Chris Cormack 2011-01-09 16:20:51 UTC
Pushed, please test
Comment 5 MJ Ray (software.coop) 2011-02-01 09:19:58 UTC
This bug is mentioned in:
Additional fix for Bug 3550,	Use GetRecordValue to get the subtitle http://lists.koha-community.org/pipermail/koha-patches/2011-January/013555.html
Additional fix for Bug 3550,	Use GetRecordValue to get the subtitle http://lists.koha-community.org/pipermail/koha-patches/2011-January/013554.html
Comment 6 Colin Campbell 2011-02-21 16:23:05 UTC Comment hidden (obsolete)
Comment 7 Chris Cormack 2011-02-21 19:47:24 UTC
Follow up patch pushed, please test and mark resolved
Comment 8 MJ Ray (software.coop) 2011-03-03 08:36:49 UTC
This bug is mentioned in:
Bug 3550 : Display changes needed in	opac-results-grouped too http://lists.koha-community.org/pipermail/koha-patches/2011-February/013907.html
Comment 9 Jared Camins-Esakov 2012-12-31 00:10:33 UTC
There have been no further reports of problems so I am marking this bug resolved.