Attachment 142094 Details for Bug 18556 – Bug 18556: Clarify lost and gonenoaddress messages

[patch] Bug 18556: Clarify lost and gonenoaddress messages

Bug-18556-Clarify-lost-and-gonenoaddress-messages.patch (text/plain), 2.86 KB, created by Katrin Fischer on 2022-10-18 20:13:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-10-18 20:13:05 UTC

Size: 2.86 KB

patch

obsolete

>From b05865a85b4ada073cb7674c3a3808bb3306bd60 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 14 Sep 2022 12:21:44 +0000
>Subject: [PATCH] Bug 18556: Clarify lost and gonenoaddress messages
>
>This patch alters the message for the patron flasg slightly, and adds
>a title to provide explicit info when hoevered
>
>To test:
>1 - Edit a patron and set gonenoaddress and lost flags
>2 - Note new info in the flags section
>3 - Go to 'Checkout' or 'Details' tab for patron
>4 - Confirm the messages make sense
>5 - Confirm you see a tool tip when hovering on messages
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc | 4 ++--
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>index 7d629a5534..db9c3430fc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>@@ -46,13 +46,13 @@
> 
> [% IF ( patron.gonenoaddress ) %]
> <li class="gonenoaddress blocker">
>- Address: Patron's address in doubt
>+ Address: Patron's address flagged as in doubt
> </li>
> [% END %]
> 
> [% IF ( patron.lost ) %]
> <li class="lost blocker">
>- Lost: Patron's card is lost
>+ Lost: Patron's card is flagged as lost
> </li>
> [% END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 12f5eef2e4..73262a8ba1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1330,6 +1330,7 @@ legend:hover {
> [% UNLESS ( opadd || opduplicate || ( nogonenoaddress && nolost ) ) %]
> <fieldset class="rows" id="memberentry_account_flags">
> <legend id="account_flags_lgd">Patron account flags</legend>
>+ Setting a value here will prevent patron from circulating materials and placing holds on the OPAC
> <ol class="radio">
> [% UNLESS nogonenoaddress %]
> <li>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 18556: 140627 | 140641 | 142094