Bug 18556 - Message "Patron's address in doubt" is confusing
Summary: Message "Patron's address in doubt" is confusing
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-08 15:06 UTC by Barton Chittenden
Modified: 2023-12-28 20:44 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15


Attachments
Bug 18556: Clarify lost and gonenoaddress messages (2.75 KB, patch)
2022-09-14 12:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18556: Clarify lost and gonenoaddress messages (2.77 KB, patch)
2022-09-14 18:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 18556: Clarify lost and gonenoaddress messages (2.86 KB, patch)
2022-10-18 20:13 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Barton Chittenden 2017-05-08 15:06:53 UTC
If a borrower has the patron account flag "Gone no address" set, the message "Patron's address in doubt" appears on the circulation check-out screen.

This is confusing -- the borrowers table has the following fields that could be interpreted as an 'address' field:

streetnumber
streettype
address
address2
city
state
zipcode
country
B_streetnumber
B_streettype
B_address
B_address2
B_city
B_state
B_zipcode
B_country
altcontactaddress1
altcontactaddress2
altcontactaddress3
altcontactstate
altcontactzipcode
altcontactcountry

... and it turns out that the message has *nothing* to do with any of these. I think that the message should read "Patron account flag 'Gone No Address' is set."
Comment 1 Katrin Fischer 2019-04-09 22:25:41 UTC
Maybe we should rename the flag too to make a bit easier to understand?

Wrong address
Wrong contact details
Wrong address information

... ?
Comment 2 Nick Clemens 2022-09-14 12:26:40 UTC
Created attachment 140627 [details] [review]
Bug 18556: Clarify lost and gonenoaddress messages

This patch alters the message for the patron flasg slightly, and adds
a title to provide explicit info when hoevered

To test:
1 - Edit a patron and set gonenoaddress and lost flags
2 - Note new info in the flags section
3 - Go to 'Checkout' or 'Details' tab for patron
4 - Confirm the messages make sense
5 - Confirm you see a tool tip when hovering on messages
Comment 3 David Nind 2022-09-14 18:09:39 UTC
Created attachment 140641 [details] [review]
Bug 18556: Clarify lost and gonenoaddress messages

This patch alters the message for the patron flasg slightly, and adds
a title to provide explicit info when hoevered

To test:
1 - Edit a patron and set gonenoaddress and lost flags
2 - Note new info in the flags section
3 - Go to 'Checkout' or 'Details' tab for patron
4 - Confirm the messages make sense
5 - Confirm you see a tool tip when hovering on messages

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2022-10-01 22:03:48 UTC
I like the change in wording, but I am in doubt about removing the circ-hlt class as it appears in the CSS and in other messages shown in the patron account, so it's something they have in common right now. Maybe we should keep it?

And something odd with and without the patch: If you go to a patron account and set both flags, only the first has the list > in the beginning.
Comment 5 Nick Clemens 2022-10-03 10:48:09 UTC
(In reply to Katrin Fischer from comment #4)
> I like the change in wording, but I am in doubt about removing the circ-hlt
> class as it appears in the CSS and in other messages shown in the patron
> account, so it's something they have in common right now. Maybe we should
> keep it?

I don't remove it, it remains, one level down

> And something odd with and without the patch: If you go to a patron account
> and set both flags, only the first has the list > in the beginning.

True before these patches too, something in the list markup maybe?
Comment 6 Katrin Fischer 2022-10-18 20:13:05 UTC
Created attachment 142094 [details] [review]
Bug 18556: Clarify lost and gonenoaddress messages

This patch alters the message for the patron flasg slightly, and adds
a title to provide explicit info when hoevered

To test:
1 - Edit a patron and set gonenoaddress and lost flags
2 - Note new info in the flags section
3 - Go to 'Checkout' or 'Details' tab for patron
4 - Confirm the messages make sense
5 - Confirm you see a tool tip when hovering on messages

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-10-18 20:20:38 UTC
(In reply to Nick Clemens from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > I like the change in wording, but I am in doubt about removing the circ-hlt
> > class as it appears in the CSS and in other messages shown in the patron
> > account, so it's something they have in common right now. Maybe we should
> > keep it?
> 
> I don't remove it, it remains, one level down
> 

This is correct.
Comment 8 Tomás Cohen Arazi 2022-10-24 14:45:35 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Lucas Gass 2022-12-05 21:44:48 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 10 Arthur Suzuki 2022-12-16 13:53:15 UTC
applied to 21.11 for 21.11.15
Comment 11 wainuiwitikapark 2023-03-15 01:01:22 UTC
Not backported to 21.05.x