Bugzilla – Attachment 142118 Details for
Bug 31692
Let librarians change item level holds to record level holds when possible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31692: (alternative look) Use select dropdown
Bug-31692-alternative-look-Use-select-dropdown.patch (text/plain), 4.59 KB, created by
Lari Taskula
on 2022-10-18 22:58:22 UTC
(
hide
)
Description:
Bug 31692: (alternative look) Use select dropdown
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2022-10-18 22:58:22 UTC
Size:
4.59 KB
patch
obsolete
>From c6f51d635ba60ff352e6a5355957c51a166db835 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Tue, 18 Oct 2022 22:38:36 +0000 >Subject: [PATCH] Bug 31692: (alternative look) Use select dropdown > >--- > .../prog/en/includes/holds_table.inc | 17 +++++++++++--- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 23 ------------------- > 2 files changed, 14 insertions(+), 26 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index ca59beeb2d..a379d41816 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -166,6 +166,7 @@ > [%- ELSE -%] > [%- IF ( hold.item_level_hold ) -%] > <em> >+ [%- IF ! hold.change_hold_type_allowed -%] > <span>Only item</span> > <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]"> > [%- IF ( hold.barcodenumber ) -%] >@@ -175,14 +176,24 @@ > <span>No barcode</span> > [%- END -%] > </a> >- [%- IF hold.change_hold_type_allowed -%] >+ [%- ELSE -%] >+ <select name="change_hold_type_[% hold.reserve_id | html %]"> >+ <option selected="selected" value="">Only item [%- IF ( hold.barcodenumber ) -%] >+ [%- hold.barcodenumber | html -%] >+ [%- ELSE -%] >+ No barcode >+ [%- END -%] >+ </option> >+ <option value="1">Next available</option> >+ </select> >+ [%- IF ( hold.barcodenumber ) -%] >+ <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" /> >+ [%- END -%] > [%- IF hold.itemtype -%] > <span style="display:none">Next available [% ItemTypes.GetDescription( hold.itemtype ) | html %] item</span> > [%- ELSE -%] > <span style="display:none">Next available</span> > [%- END -%] >- <a id="change_hold_type_icon" data-reserve-id="[% hold.reserve_id | html %]" href="#" class="clear_date fa fa-fw fa-chain-broken" title="Toggle hold type" aria-label="Toggle hold typem"></a> >- <input id="change_hold_type_[% hold.reserve_id | html %]" type="hidden" name="change_hold_type_[% hold.reserve_id | html %]" value="0"> > [%- END -%] > </em> > [%- ELSE -%] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index cc9036fb6d..58ecb622c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -441,27 +441,4 @@ $(document).ready(function() { > window.location.href='request.pl?action=toggleSuspend&reserve_id=' + reserve_id + '&biblionumber=' + biblionumber + '&suspend_until=' + suspend_until; > return false; > }); >- >- $("a#change_hold_type_icon").on('click', function(e) { >- e.preventDefault(); >- let reserve_id = $(this).data('reserve-id'); >- let change_type = $("input#change_hold_type_" + reserve_id).val(); >- let only_item = $(this).siblings("span:first"); >- let only_itemlink = $(this).siblings("a:first"); >- let next_available = $(this).siblings("span:last"); >- if (change_type==="1") { >- $("input#change_hold_type_" + reserve_id).val("0"); >- next_available.hide(); >- only_itemlink.show(); >- only_item.show(); >- $(this).removeClass("fa-chain").addClass("fa-chain-broken"); >- } else { >- $("input#change_hold_type_" + reserve_id).val("1"); >- only_itemlink.hide(); >- only_item.hide(); >- next_available.show(); >- $(this).removeClass("fa-chain-broken").addClass("fa-chain"); >- } >- return false; >- }); > }); >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31692
:
141388
|
141390
|
142102
|
142103
|
142104
|
142106
|
142107
|
142108
|
142109
|
142114
|
142115
|
142116
|
142117
|
142118
|
142586
|
142587
|
142595
|
142596
|
142818
|
142819
|
143151
|
143160
|
143161
|
143162
|
143614
|
143615
|
143616
|
143617
|
143618
|
143619
|
143627
|
143628
|
143629