Bugzilla – Attachment 142306 Details for
Bug 31848
Holds queue: Submit button for filters on the left is closer to nav than to its form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31848: Correct margin and padding on action fieldset in aside
Bug-31848-Correct-margin-and-padding-on-action-fie.patch (text/plain), 2.88 KB, created by
Martin Renvoize (ashimema)
on 2022-10-21 08:41:55 UTC
(
hide
)
Description:
Bug 31848: Correct margin and padding on action fieldset in aside
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-10-21 08:41:55 UTC
Size:
2.88 KB
patch
obsolete
>From fa0106e1e23368eca667651e5a64f717f18c5b30 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 18 Oct 2022 12:07:38 +0000 >Subject: [PATCH] Bug 31848: Correct margin and padding on action fieldset in > aside > >This patch makes a minor modification to the padding and margin of ><fieldset class="action"> nested in a .brief fieldset. This markup is >seen most often in sidebar filter form. The change allows the submit >button to line up better with other form fields. > >The patch also corrects and inconsistency by modifying the holds queue >template so that the .action fieldset is inside the .brief fieldset. > >To test, apply the patch and rebuild the staff interface CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) > >- If necessary, place one or more holds for pickup at your logged-in > library and rebuild the holds queue > (misc/cronjobs/holds/build_holds_queue.pl) >- Go to Circulation -> Holds queue. >- The form should look correct. >- Submit the form and check the form in the sidebar. It should look > correct as well, with the submit button aligned left with the other > form fields. >- Check pages with similar sidebar forms, e.g.: > - Administration -> Budgets -> Funds -> Planning > - Circulation -> Overdues > - Circulation -> Holds to pull > - Acquisitions -> Invoices -> Search results > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 3 ++- > .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 8 ++++---- > 2 files changed, 6 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index b9f4ec04ff..43aa6f43e8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -948,7 +948,8 @@ fieldset { > } > > .action { >- margin-left: 1em; >+ margin: 0; >+ padding: .4em 0; > } > } > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >index 4e54485f08..877db11838 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >@@ -283,10 +283,10 @@ > </select> > </li> > </ol> >- </fieldset> >- <fieldset class="action"> >- <input type="submit" value="Submit" /> >- <input type="hidden" name="run_report" value="1" /> >+ <fieldset class="action"> >+ <input type="submit" value="Submit" /> >+ <input type="hidden" name="run_report" value="1" /> >+ </fieldset> > </fieldset> > </form> > [% END %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31848
:
142053
|
142092
| 142306