On he holds queue page when you are looking at the holds, the submit button for the filters on the left is right about the navigation, but there is a big gap between the button and it's form. Maybe the button should be even inside the white area?
Created attachment 142053 [details] [review] Bug 31848: Correct margin and padding on action fieldset in aside This patch makes a minor modification to the padding and margin of <fieldset class="action"> nested in a .brief fieldset. This markup is seen most often in sidebar filter form. The change allows the submit button to line up better with other form fields. The patch also corrects and inconsistency by modifying the holds queue template so that the .action fieldset is inside the .brief fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - If necessary, place one or more holds for pickup at your logged-in library and rebuild the holds queue (misc/cronjobs/holds/build_holds_queue.pl) - Go to Circulation -> Holds queue. - The form should look correct. - Submit the form and check the form in the sidebar. It should look correct as well, with the submit button aligned left with the other form fields. - Check pages with similar sidebar forms, e.g.: - Administration -> Budgets -> Funds -> Planning - Circulation -> Overdues - Circulation -> Holds to pull - Acquisitions -> Invoices -> Search results
Created attachment 142092 [details] [review] Bug 31848: Correct margin and padding on action fieldset in aside This patch makes a minor modification to the padding and margin of <fieldset class="action"> nested in a .brief fieldset. This markup is seen most often in sidebar filter form. The change allows the submit button to line up better with other form fields. The patch also corrects and inconsistency by modifying the holds queue template so that the .action fieldset is inside the .brief fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - If necessary, place one or more holds for pickup at your logged-in library and rebuild the holds queue (misc/cronjobs/holds/build_holds_queue.pl) - Go to Circulation -> Holds queue. - The form should look correct. - Submit the form and check the form in the sidebar. It should look correct as well, with the submit button aligned left with the other form fields. - Check pages with similar sidebar forms, e.g.: - Administration -> Budgets -> Funds -> Planning - Circulation -> Overdues - Circulation -> Holds to pull - Acquisitions -> Invoices -> Search results Signed-off-by: David Nind <david@davidnind.com>
Created attachment 142306 [details] [review] Bug 31848: Correct margin and padding on action fieldset in aside This patch makes a minor modification to the padding and margin of <fieldset class="action"> nested in a .brief fieldset. This markup is seen most often in sidebar filter form. The change allows the submit button to line up better with other form fields. The patch also corrects and inconsistency by modifying the holds queue template so that the .action fieldset is inside the .brief fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - If necessary, place one or more holds for pickup at your logged-in library and rebuild the holds queue (misc/cronjobs/holds/build_holds_queue.pl) - Go to Circulation -> Holds queue. - The form should look correct. - Submit the form and check the form in the sidebar. It should look correct as well, with the submit button aligned left with the other form fields. - Check pages with similar sidebar forms, e.g.: - Administration -> Budgets -> Funds -> Planning - Circulation -> Overdues - Circulation -> Holds to pull - Acquisitions -> Invoices -> Search results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 22.11. Nice work everyone, thanks!