Attachment 142760 Details for Bug 31713 – Bug 31713: (QA follow-up) Add current date to slip

[patch] Bug 31713: (QA follow-up) Add current date to slip

Bug-31713-QA-follow-up-Add-current-date-to-slip.patch (text/plain), 2.59 KB, created by Marcel de Rooy on 2022-10-28 09:30:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-10-28 09:30:09 UTC

Size: 2.59 KB

patch

obsolete

>From 64952c6abece950d725f9f9a03395597fae7571c Mon Sep 17 00:00:00 2001
>From: Kyle Hall <kyle@bywatersolutions.com>
>Date: Fri, 21 Oct 2022 08:20:33 -0400
>Subject: [PATCH] Bug 31713: (QA follow-up) Add current date to slip
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>[EDIT] Reverting the KohaDates.now changes. We can simply use [% today %].
>---
> installer/data/mysql/atomicupdate/bug_31713.pl       | 5 +++--
> installer/data/mysql/en/mandatory/sample_notices.yml | 5 +++--
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_31713.pl b/installer/data/mysql/atomicupdate/bug_31713.pl
>index 9ab4132d89..ee1681ccb2 100644
>--- a/installer/data/mysql/atomicupdate/bug_31713.pl
>+++ b/installer/data/mysql/atomicupdate/bug_31713.pl
>@@ -8,8 +8,9 @@ return {
>         my ($dbh, $out) = @$args{qw(dbh out)};
> 
>         my $slip_content = <<~'END_CONTENT';
>-[% USE Koha %]
> [% USE Branches %]
>+[% USE Koha %]
>+[% USE KohaDates %]
> [% USE Price %]
> [% PROCESS 'accounts.inc' %]
> <table>
>@@ -85,7 +86,7 @@ return {
> 
>   <tfoot>
>     <tr>
>-      <td colspan='3'>Total outstanding dues as on date: </td>
>+      <td colspan='3'>Total outstanding dues as of [% today | $KohaDates  %]: </td>
>       [% IF ( borrower.account.balance <= 0 ) %]<td class='credit'>[% ELSE %]<td class='debit'>[% END %][% borrower.account.balance | $Price %]</td>
>     </tr>
>   </tfoot>
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index 436a1ecc6a..c2dd1a59c4 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -1292,8 +1292,9 @@ tables:
>           message_transport_type: print
>           lang: default
>           content:
>-            - "[% USE Koha %]"
>             - "[% USE Branches %]"
>+            - "[% USE Koha %]"
>+            - "[% USE KohaDates %]"
>             - "[% USE Price %]"
>             - "[% PROCESS 'accounts.inc' %]"
>             - "<table>"
>@@ -1369,7 +1370,7 @@ tables:
>             - ""
>             - "  <tfoot>"
>             - "    <tr>"
>-            - "      <td colspan='3'>Total outstanding dues as on date: </td>"
>+            - "      <td colspan='3'>Total outstanding dues as of [% today | $KohaDates %]: </td>"
>             - "      [% IF ( borrower.account.balance <= 0 ) %]<td class='credit'>[% ELSE %]<td class='debit'>[% END %][% borrower.account.balance | $Price %]</td>"
>             - "    </tr>"
>             - "  </tfoot>"
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31713: 141517 | 141572 | 141573 | 141574 | 141575 | 142340 | 142341 | 142342 | 142360 | 142760 | 142871 | 142872 | 142873 | 142874 | 142875 | 142876 | 142926 | 142927 | 142928 | 142929 | 142930 | 142931