Bug 31713 - Allow easy printing of patron's fines
Summary: Allow easy printing of patron's fines
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
: 12285 (view as bug list)
Depends on: 31714
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-07 15:26 UTC by Martin Renvoize
Modified: 2023-12-28 20:43 UTC (History)
18 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/669
Text to go in the release notes:
Adds the option to print an accounts summary from the print pull down in the patron's account in the staff interface. This uses the new notice ACCOUNTS_SUMMARY.
Version(s) released in:
22.11.00


Attachments
Bug 31713: Add FEE_SUMMARY print slip link (1.29 KB, patch)
2022-10-07 15:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY print slip link (1.29 KB, patch)
2022-10-10 11:20 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY slip template (7.81 KB, patch)
2022-10-10 11:20 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY slip template (7.84 KB, patch)
2022-10-10 11:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY slip template (7.84 KB, patch)
2022-10-10 11:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY print slip link (1.34 KB, patch)
2022-10-21 12:23 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY slip template (7.89 KB, patch)
2022-10-21 12:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31713: (QA follow-up) Add current date to slip (2.84 KB, patch)
2022-10-21 12:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31713: (QA follow-up) Add current date to slip (3.63 KB, patch)
2022-10-21 12:52 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31713: (QA follow-up) Add current date to slip (2.59 KB, patch)
2022-10-28 09:30 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY print slip link (1.41 KB, patch)
2022-11-01 14:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY slip template (7.95 KB, patch)
2022-11-01 14:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: (QA follow-up) Add current date to slip (2.61 KB, patch)
2022-11-01 14:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: (follow-up) Fix terminology (6.34 KB, patch)
2022-11-01 14:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: (follow-up) Display print option for any outstanding (1.49 KB, patch)
2022-11-01 14:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: (follow-up) Display print option for any outstanding (1.49 KB, patch)
2022-11-01 14:29 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY print slip link (1.46 KB, patch)
2022-11-02 11:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31713: Add FEE_SUMMARY slip template (8.01 KB, patch)
2022-11-02 11:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31713: (QA follow-up) Add current date to slip (2.67 KB, patch)
2022-11-02 11:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31713: (follow-up) Fix terminology (6.40 KB, patch)
2022-11-02 11:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31713: (follow-up) Display print option for any outstanding (1.54 KB, patch)
2022-11-02 11:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31713: (QA follow-up) Make credits positive (3.95 KB, patch)
2022-11-02 11:53 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-07 15:26:31 UTC
+++ This bug was initially created as a clone of Bug #12285 +++

There should be an easy way to print a slip of patron's fines.

---------------------------------------------------------------

Whilst QAing the above, I felt like there should really be a much simpler way to work on adding a notice like this.. I intend to do that with this bug.
Comment 1 Martin Renvoize 2022-10-07 15:34:28 UTC
Created attachment 141517 [details] [review]
Bug 31713: Add FEE_SUMMARY print slip link
Comment 2 Martin Renvoize 2022-10-10 11:20:21 UTC
Created attachment 141572 [details] [review]
Bug 31713: Add FEE_SUMMARY print slip link
Comment 3 Martin Renvoize 2022-10-10 11:20:28 UTC
Created attachment 141573 [details] [review]
Bug 31713: Add FEE_SUMMARY slip template

This patch adds the new FEE_SUMMARY print slip notice template to the
database.
Comment 4 Martin Renvoize 2022-10-10 11:36:12 UTC
Created attachment 141574 [details] [review]
Bug 31713: Add FEE_SUMMARY slip template

This patch adds the new FEE_SUMMARY print slip notice template to the
database.
Comment 5 Martin Renvoize 2022-10-10 11:38:21 UTC
Created attachment 141575 [details] [review]
Bug 31713: Add FEE_SUMMARY slip template

This patch adds the new FEE_SUMMARY print slip notice template to the
database.
Comment 6 Martin Renvoize 2022-10-10 11:40:18 UTC
To test:
1) Apply patches from bug 31714 and 31713
2) Check in tools > Notices & Slips that you have the new FINE_SUMMARY slip,
   and a print message there. If not, run updatedatabase.pl
3) Either create some fines for a patron, or look up a patron
   with existing fines.. Bonus points, also add some credits to the patron.
4) From that patron's detail page, and the Print-menu in
   the toolbar, select "Print fines slip"
5) You should get a slip of the patron's outstanding fines.
Comment 7 David Nind 2022-10-10 20:25:56 UTC
I've tested and have some feedback:

1. Things work as expected using the test plan (for step 2, FINE_SUMMARY should be FEE_SUMMARY).

2. For the print menu for the patron, this is labelled "Print fines slip": should these be "Print charges slip"? I thought we were heading in the direction of using charges rather than fines, but this it is not covered in the terminology list.

3. If I add a manual credit that is more than the outstanding balance (that is, overall the library owes the patron) but don't apply it, I can't print the slip. I assume that if this is the case, staff would know to apply the credit.

4. For the slip:
   . Should the title be "Outstanding charges"?
   . The phrase "Total outstanding dues as on date:" doesn't make much sense to me. Possibly "Total outstanding charges" or just "Total outstanding"?
   . Could the Amount and Outstanding columns be right aligned with the amounts?

This all works, so hope my feedback doesn't come across as too negative!

David
Comment 8 Kyle M Hall 2022-10-21 12:23:47 UTC
Created attachment 142340 [details] [review]
Bug 31713: Add FEE_SUMMARY print slip link

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Kyle M Hall 2022-10-21 12:24:01 UTC
Created attachment 142341 [details] [review]
Bug 31713: Add FEE_SUMMARY slip template

This patch adds the new FEE_SUMMARY print slip notice template to the
database.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall 2022-10-21 12:24:06 UTC
Created attachment 142342 [details] [review]
Bug 31713: (QA follow-up) Add current date to slip

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Kyle M Hall 2022-10-21 12:52:48 UTC
Created attachment 142360 [details] [review]
Bug 31713: (QA follow-up) Add current date to slip

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 12 Martin Renvoize 2022-10-21 13:47:08 UTC
These comments got me re-reading the notice.

(In reply to David Nind from comment #7)
> I've tested and have some feedback:
> 
> 1. Things work as expected using the test plan (for step 2, FINE_SUMMARY
> should be FEE_SUMMARY).

Oops.. it should probably be renamed again though given the below

> 2. For the print menu for the patron, this is labelled "Print fines slip":
> should these be "Print charges slip"? I thought we were heading in the
> direction of using charges rather than fines, but this it is not covered in
> the terminology list.

'Charges' isn't 100% correct either.. we actually allow printing of and 'outstanding' accounts.. credit or debt.

> 3. If I add a manual credit that is more than the outstanding balance (that
> is, overall the library owes the patron) but don't apply it, I can't print
> the slip. I assume that if this is the case, staff would know to apply the
> credit.

This feels like a bug.. One should be able to print if there are any outstanding accounts in either direction I think.

> 4. For the slip:
>    . Should the title be "Outstanding charges"?
>    . The phrase "Total outstanding dues as on date:" doesn't make much sense
> to me. Possibly "Total outstanding charges" or just "Total outstanding"?
>    . Could the Amount and Outstanding columns be right aligned with the
> amounts?

Given the above about the slip in theory printing both debts and credits outstanding, I'm not sure what to put in the overall title..


> This all works, so hope my feedback doesn't come across as too negative!

Not at all.. it's great to have feedback :)
Comment 13 Martin Renvoize 2022-10-28 08:59:53 UTC
We don't need the 'now' method added by Kyles follow-up.. though I'm not against it in the general case.. we have a 'today' variable in all notices that can be used for this.
Comment 14 Marcel de Rooy 2022-10-28 09:30:09 UTC
Created attachment 142760 [details] [review]
Bug 31713: (QA follow-up) Add current date to slip

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Reverting the KohaDates.now changes. We can simply use [% today %].
Comment 15 Marcel de Rooy 2022-10-28 09:32:29 UTC
I wont solve the issues from comment12 here. So I am moving it to FQA. Without a quick follow-up we should give the other report a chance?
Comment 16 Martin Renvoize 2022-11-01 11:05:51 UTC
How about:

`Print account balance` for the button name and `ACCOUNTS_SUMMARY` for the notice code...
Comment 17 David Nind 2022-11-01 12:29:59 UTC
(In reply to Martin Renvoize from comment #16)
> How about:
> 
> `Print account balance` for the button name and `ACCOUNTS_SUMMARY` for the
> notice code...

Sounds great to me!
Comment 18 Martin Renvoize 2022-11-01 14:25:19 UTC
Created attachment 142871 [details] [review]
Bug 31713: Add FEE_SUMMARY print slip link

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 19 Martin Renvoize 2022-11-01 14:25:25 UTC
Created attachment 142872 [details] [review]
Bug 31713: Add FEE_SUMMARY slip template

This patch adds the new FEE_SUMMARY print slip notice template to the
database.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 20 Martin Renvoize 2022-11-01 14:25:31 UTC
Created attachment 142873 [details] [review]
Bug 31713: (QA follow-up) Add current date to slip

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Reverting the KohaDates.now changes. We can simply use [% today %].
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 21 Martin Renvoize 2022-11-01 14:25:36 UTC
Created attachment 142874 [details] [review]
Bug 31713: (follow-up) Fix terminology

This patch fixes the terminology as proposed.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 22 Martin Renvoize 2022-11-01 14:25:42 UTC
Created attachment 142875 [details] [review]
Bug 31713: (follow-up) Display print option for any outstanding

Prior to this patch we only allowed printing if the balance was owed to
the library.. This patch exposes the option when the patron is owed too.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 23 Martin Renvoize 2022-11-01 14:29:34 UTC
Created attachment 142876 [details] [review]
Bug 31713: (follow-up) Display print option for any outstanding

Prior to this patch we only allowed printing if the balance was owed to
the library.. This patch exposes the option when the patron is owed too.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 24 Katrin Fischer 2022-11-02 11:53:08 UTC
Created attachment 142926 [details] [review]
Bug 31713: Add FEE_SUMMARY print slip link

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 25 Katrin Fischer 2022-11-02 11:53:15 UTC
Created attachment 142927 [details] [review]
Bug 31713: Add FEE_SUMMARY slip template

This patch adds the new FEE_SUMMARY print slip notice template to the
database.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 26 Katrin Fischer 2022-11-02 11:53:21 UTC
Created attachment 142928 [details] [review]
Bug 31713: (QA follow-up) Add current date to slip

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Reverting the KohaDates.now changes. We can simply use [% today %].
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 27 Katrin Fischer 2022-11-02 11:53:29 UTC
Created attachment 142929 [details] [review]
Bug 31713: (follow-up) Fix terminology

This patch fixes the terminology as proposed.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 28 Katrin Fischer 2022-11-02 11:53:37 UTC
Created attachment 142930 [details] [review]
Bug 31713: (follow-up) Display print option for any outstanding

Prior to this patch we only allowed printing if the balance was owed to
the library.. This patch exposes the option when the patron is owed too.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 29 Katrin Fischer 2022-11-02 11:53:44 UTC
Created attachment 142931 [details] [review]
Bug 31713: (QA follow-up) Make credits positive

* This makes amount and amountoutstanding for credits positive
* Adapts the total line to read credits instead of due when the
  balance is >0
Comment 30 Katrin Fischer 2022-11-02 12:06:16 UTC
Very low risk of side effects, dear RM, please consider :)
Comment 31 Tomás Cohen Arazi 2022-11-03 14:32:10 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 32 Katrin Fischer 2022-11-14 21:59:46 UTC
*** Bug 12285 has been marked as a duplicate of this bug. ***