+++ This bug was initially created as a clone of Bug #12285 +++ There should be an easy way to print a slip of patron's fines. --------------------------------------------------------------- Whilst QAing the above, I felt like there should really be a much simpler way to work on adding a notice like this.. I intend to do that with this bug.
Created attachment 141517 [details] [review] Bug 31713: Add FEE_SUMMARY print slip link
Created attachment 141572 [details] [review] Bug 31713: Add FEE_SUMMARY print slip link
Created attachment 141573 [details] [review] Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database.
Created attachment 141574 [details] [review] Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database.
Created attachment 141575 [details] [review] Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database.
To test: 1) Apply patches from bug 31714 and 31713 2) Check in tools > Notices & Slips that you have the new FINE_SUMMARY slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines.. Bonus points, also add some credits to the patron. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines slip" 5) You should get a slip of the patron's outstanding fines.
I've tested and have some feedback: 1. Things work as expected using the test plan (for step 2, FINE_SUMMARY should be FEE_SUMMARY). 2. For the print menu for the patron, this is labelled "Print fines slip": should these be "Print charges slip"? I thought we were heading in the direction of using charges rather than fines, but this it is not covered in the terminology list. 3. If I add a manual credit that is more than the outstanding balance (that is, overall the library owes the patron) but don't apply it, I can't print the slip. I assume that if this is the case, staff would know to apply the credit. 4. For the slip: . Should the title be "Outstanding charges"? . The phrase "Total outstanding dues as on date:" doesn't make much sense to me. Possibly "Total outstanding charges" or just "Total outstanding"? . Could the Amount and Outstanding columns be right aligned with the amounts? This all works, so hope my feedback doesn't come across as too negative! David
Created attachment 142340 [details] [review] Bug 31713: Add FEE_SUMMARY print slip link Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 142341 [details] [review] Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 142342 [details] [review] Bug 31713: (QA follow-up) Add current date to slip Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 142360 [details] [review] Bug 31713: (QA follow-up) Add current date to slip Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
These comments got me re-reading the notice. (In reply to David Nind from comment #7) > I've tested and have some feedback: > > 1. Things work as expected using the test plan (for step 2, FINE_SUMMARY > should be FEE_SUMMARY). Oops.. it should probably be renamed again though given the below > 2. For the print menu for the patron, this is labelled "Print fines slip": > should these be "Print charges slip"? I thought we were heading in the > direction of using charges rather than fines, but this it is not covered in > the terminology list. 'Charges' isn't 100% correct either.. we actually allow printing of and 'outstanding' accounts.. credit or debt. > 3. If I add a manual credit that is more than the outstanding balance (that > is, overall the library owes the patron) but don't apply it, I can't print > the slip. I assume that if this is the case, staff would know to apply the > credit. This feels like a bug.. One should be able to print if there are any outstanding accounts in either direction I think. > 4. For the slip: > . Should the title be "Outstanding charges"? > . The phrase "Total outstanding dues as on date:" doesn't make much sense > to me. Possibly "Total outstanding charges" or just "Total outstanding"? > . Could the Amount and Outstanding columns be right aligned with the > amounts? Given the above about the slip in theory printing both debts and credits outstanding, I'm not sure what to put in the overall title.. > This all works, so hope my feedback doesn't come across as too negative! Not at all.. it's great to have feedback :)
We don't need the 'now' method added by Kyles follow-up.. though I'm not against it in the general case.. we have a 'today' variable in all notices that can be used for this.
Created attachment 142760 [details] [review] Bug 31713: (QA follow-up) Add current date to slip Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Reverting the KohaDates.now changes. We can simply use [% today %].
I wont solve the issues from comment12 here. So I am moving it to FQA. Without a quick follow-up we should give the other report a chance?
How about: `Print account balance` for the button name and `ACCOUNTS_SUMMARY` for the notice code...
(In reply to Martin Renvoize from comment #16) > How about: > > `Print account balance` for the button name and `ACCOUNTS_SUMMARY` for the > notice code... Sounds great to me!
Created attachment 142871 [details] [review] Bug 31713: Add FEE_SUMMARY print slip link Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 142872 [details] [review] Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 142873 [details] [review] Bug 31713: (QA follow-up) Add current date to slip Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Reverting the KohaDates.now changes. We can simply use [% today %]. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 142874 [details] [review] Bug 31713: (follow-up) Fix terminology This patch fixes the terminology as proposed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 142875 [details] [review] Bug 31713: (follow-up) Display print option for any outstanding Prior to this patch we only allowed printing if the balance was owed to the library.. This patch exposes the option when the patron is owed too. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 142876 [details] [review] Bug 31713: (follow-up) Display print option for any outstanding Prior to this patch we only allowed printing if the balance was owed to the library.. This patch exposes the option when the patron is owed too. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 142926 [details] [review] Bug 31713: Add FEE_SUMMARY print slip link Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142927 [details] [review] Bug 31713: Add FEE_SUMMARY slip template This patch adds the new FEE_SUMMARY print slip notice template to the database. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142928 [details] [review] Bug 31713: (QA follow-up) Add current date to slip Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Reverting the KohaDates.now changes. We can simply use [% today %]. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142929 [details] [review] Bug 31713: (follow-up) Fix terminology This patch fixes the terminology as proposed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142930 [details] [review] Bug 31713: (follow-up) Display print option for any outstanding Prior to this patch we only allowed printing if the balance was owed to the library.. This patch exposes the option when the patron is owed too. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142931 [details] [review] Bug 31713: (QA follow-up) Make credits positive * This makes amount and amountoutstanding for credits positive * Adapts the total line to read credits instead of due when the balance is >0
Very low risk of side effects, dear RM, please consider :)
Pushed to master for 22.11. Nice work everyone, thanks!
*** Bug 12285 has been marked as a duplicate of this bug. ***