Attachment 142984 Details for Bug 31967 – Bug 31967: Search terms retained in header search when only one result

[patch] Bug 31967: Search terms retained in header search when only one result

Bug-31967-Search-terms-retained-in-header-search-w.patch (text/plain), 1.65 KB, created by Martin Renvoize (ashimema) on 2022-11-02 14:21:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-11-02 14:21:48 UTC

Size: 1.65 KB

patch

obsolete

>From bae3709ebeb01fa786666568ca161a5482821f9f Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 24 Oct 2022 20:47:41 -1000
>Subject: [PATCH] Bug 31967: Search terms retained in header search when only
> one result
>
>Bug 26247 added a system preference to manage the Retaining of search terms in header search.
>But this does not work if there is only one match and you go directly to details page.
>
>Test plan :
>1) Set system preference RetainCatalogSearchTerms to "Don't retain"
>2) Perform a search leading to a single result.
>   For example in KTD the ISBN 1932100083
>=> Without patch search bar is populated with search terms
>=> With patch search bar is not populated with search terms
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 5a14e60aaa..419b6095a3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -1949,7 +1949,7 @@ Note that permanent location is a code, and location may be an authval.
> 
>         });
> 
>-        [% IF (found1) %]
>+        [% IF found1 && Koha.Preference('RetainCatalogSearchTerms') %]
>             $(document).ready(function() {
>                 var search_index = localStorage.getItem("cat_search_pulldown_selection");
>                 var search_value = localStorage.getItem("searchbox_value");
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 31967: 142600 | 142601 | 142984