Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. This needs to be fixed in Javascript : https://git.koha-community.org/Koha-community/Koha/src/commit/b0cf6c087b9e23467b98faecd3eac1ec0d6bc968/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt#L1953
Created attachment 142600 [details] [review] Bug 31967: Search terms retained in header search when only one result Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. Test plan : 1) Set system preference RetainCatalogSearchTerms to "Don't retain" 2) Perform a search leading to a single result. For example in KTD the ISBN 1932100083 => Without patch search bar is populated with search terms => With patch search bar is not populated with search terms
Some librarians reported this is reaaaaaaally important since they search by scanning ISBN or item barcode. Retaining search terms does not allow to scan another barcode directly.
Created attachment 142601 [details] [review] Bug 31967: Search terms retained in header search when only one result Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. Test plan : 1) Set system preference RetainCatalogSearchTerms to "Don't retain" 2) Perform a search leading to a single result. For example in KTD the ISBN 1932100083 => Without patch search bar is populated with search terms => With patch search bar is not populated with search terms Signed-off-by: David Nind <david@davidnind.com>
Created attachment 142984 [details] [review] Bug 31967: Search terms retained in header search when only one result Bug 26247 added a system preference to manage the Retaining of search terms in header search. But this does not work if there is only one match and you go directly to details page. Test plan : 1) Set system preference RetainCatalogSearchTerms to "Don't retain" 2) Perform a search leading to a single result. For example in KTD the ISBN 1932100083 => Without patch search bar is populated with search terms => With patch search bar is not populated with search terms Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix, works.. Passing QA
Pushed to master for 22.11. Nice work everyone, thanks!