Bugzilla – Attachment 143138 Details for
Bug 31818
Advanced editor doesn't show keyboard shortcuts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31818: Enable table elements in keyboard shortcuts popover
Bug-31818-Enable-table-elements-in-keyboard-shortc.patch (text/plain), 1.69 KB, created by
Andrew Fuerste-Henry
on 2022-11-03 16:31:58 UTC
(
hide
)
Description:
Bug 31818: Enable table elements in keyboard shortcuts popover
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2022-11-03 16:31:58 UTC
Size:
1.69 KB
patch
obsolete
>From 7d6cbd4d2524951d1682122c787839f8d286b388 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 3 Nov 2022 15:20:34 +0000 >Subject: [PATCH] Bug 31818: Enable table elements in keyboard shortcuts > popover > >This patch updates the whitelist for the popover to ensrue our shortcuts table displays > >To test: >1 - Open the advanced cataloging editor >2 - Click 'Keyboard shortcuts' >3 - Is empty, be sad >4 - Apply patch >5 - Reload >6 - Click it again >7 - Shortcuts! > >Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> >--- > .../intranet-tmpl/prog/en/includes/cateditor-ui.inc | 9 +++++++++ > 1 file changed, 9 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >index 12a0de3d9c..c51ab8fb49 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >@@ -1306,6 +1306,15 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > }, > }); > >+ // Whitelist table elements to ensure popover displays all the info >+ $.fn.popover.Constructor.DEFAULTS.whiteList.table = []; >+ $.fn.popover.Constructor.DEFAULTS.whiteList.tr = []; >+ $.fn.popover.Constructor.DEFAULTS.whiteList.td = []; >+ $.fn.popover.Constructor.DEFAULTS.whiteList.div = []; >+ $.fn.popover.Constructor.DEFAULTS.whiteList.tbody = []; >+ $.fn.popover.Constructor.DEFAULTS.whiteList.thead = []; >+ // https://getbootstrap.com/docs/3.4/javascript/#popovers >+ > $('#show-shortcuts').popover({ > html: true, > placement: 'bottom', >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31818
:
143135
|
143138
|
143493