Attachment 143178 Details for Bug 32109 – Bug 32109: Fix spacing in toolbars containing text links

[patch] Bug 32109: Fix spacing in toolbars containing text links

Bug-32109-Fix-spacing-in-toolbars-containing-text-.patch (text/plain), 7.59 KB, created by Owen Leonard on 2022-11-04 12:00:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2022-11-04 12:00:06 UTC

Size: 7.59 KB

patch

obsolete

>From bfa26a12134dececdecdf3439698b0b25e7e92a8 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 4 Nov 2022 11:42:47 +0000
>Subject: [PATCH] Bug 32109: Fix spacing in toolbars containing text links
>
>This patch adds a new class to toolbars in certain contexts: Where the
>toolbar contains only text links (as opposed to Bootstrap-styled
>controls). This lets us set some comfortable padding on the links.
>
>To test, apply the patch and rebuild the staff interface CSS.
>
>Test the following pages to confirm that the toolbar of selection links
>("Select all," "Clear all," etc.) has legible spacing.
>
>- Cataloging -> Batch item modification -> List of submitted barcodes
>- Cataloging -> Batch item deletion -> List of submitted barcodes
>- Cataloging -> Batch record modification -> List of submitted records
>- Cataloging -> Batch record deletion -> List of submitted records
>- Tools -> Batch extend due dates -> Preview results
>- Tools -> Batch patron modification -> List of submitted patrons
>---
> koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss         | 7 +++++++
> koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc  | 2 +-
> .../prog/en/modules/tools/batch_delete_records.tt          | 4 ++--
> .../prog/en/modules/tools/batch_extend_due_dates.tt        | 2 +-
> .../prog/en/modules/tools/batch_record_modification.tt     | 4 ++--
> .../intranet-tmpl/prog/en/modules/tools/modborrowers.tt    | 2 +-
> 6 files changed, 14 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss
>index e18ff3dce1..75094af8e0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_toolbar.scss
>@@ -75,4 +75,11 @@
>             font-size: 100%;
>         }
>     }
>+
>+    &.selections-toolbar {
>+        a {
>+            display: inline-block;
>+            padding: 0 .5em;
>+        }
>+    }
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>index 237500bf7a..ae9cdcf6e8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>@@ -212,7 +212,7 @@
> 
>     [% IF display_columns_selection %][%# Needs js/pages/batchMod.js %]
>         [% IF checkboxes_edit OR checkboxes_delete %]
>-            <div id="toolbar">
>+            <div id="toolbar" class="selections-toolbar">
>                 <a id="selectallbutton" href="#"><i class="fa fa-check"></i> Select all</a> | <a id="clearallbutton" href="#"><i class="fa fa-remove"></i> Clear all</a> | <a id="clearonloanbutton" href="#">Clear on loan</a>
>             </div>
>         [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>index 845b3e90df..6960819092 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
>@@ -138,7 +138,7 @@
>   [% ELSIF op == 'list' %]
>     [% IF records %]
>       [% IF recordtype == 'biblio' %]
>-        <div id="toolbar">
>+        <div id="toolbar" class="selections-toolbar">
>           <a id="selectall" href="#"><i class="fa fa-check"></i> Select all</a>
>           | <a id="clearall" href="#"><i class="fa fa-remove"></i> Clear all</a>
>           | <a id="selectwithoutitems" href="#">Select without items</a>
>@@ -174,7 +174,7 @@
>           </table>
>           <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will delete all selected bibliographic records, attached subscriptions, existing holds, and attached items!</div>
>       [% ELSE %]
>-        <div id="toolbar">
>+        <div id="toolbar" class="selections-toolbar">
>           <a id="selectall" href="#"><i class="fa fa-check"></i> Select all</a>
>           | <a id="clearall" href="#"><i class="fa fa-remove"></i> Clear all</a>
>           | <a id="clearlinkedtobiblio" href="#">Clear used authorities</a>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt
>index c0b9682ef8..8e6629dceb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt
>@@ -127,7 +127,7 @@
>                     [% ELSIF view == 'list' %]
>                         [% IF checkouts.count %]
>                             <form action="/cgi-bin/koha/tools/batch_extend_due_dates.pl" method="post" id="process">
>-                                <div id="toolbar">
>+                                <div id="toolbar" class="selections-toolbar">
>                                     <a id="selectall" href="#"><i class="fa fa-check"></i> Select all</a>
>                                     | <a id="clearall" href="#"><i class="fa fa-remove"></i> Clear all</a>
>                                 </div>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>index 1a0344371e..0e2782a0d6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
>@@ -188,7 +188,7 @@
>                                     </div>
>                                 </div>
>                                 [% IF recordtype == 'biblio' %]
>-                                    <div id="toolbar">
>+                                    <div id="toolbar" class="selections-toolbar">
>                                         <a id="selectall" href="#"><i class="fa fa-check"></i> Select all</a>
>                                         | <a id="clearall" href="#"><i class="fa fa-remove"></i> Clear all</a>
>                                     </div>
>@@ -216,7 +216,7 @@
>                                     </table> 
>                                     <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected biblios!</div>
>                                 [% ELSE %]
>-                                    <div id="toolbar">
>+                                    <div id="toolbar" class="selections-toolbar">
>                                         <a id="selectall" href="#"><i class="fa fa-check"></i> Select all</a>
>                                         | <a id="clearall" href="#"><i class="fa fa-remove"></i> Clear all</a>
>                                     </div>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>index 2200c9d52e..c3a50a1952 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>@@ -201,7 +201,7 @@
>                     <form name="f" action="modborrowers.pl" method="post">
>                         <input type="hidden" name="op" value="do" />
>                         [% IF ( borrowers ) %]
>-                            <div id="toolbar"><a id="selectallbutton" href="#"><i class="fa fa-check"></i> Select all</a> | <a id="clearallbutton" href="#"><i class="fa fa-remove"></i> Clear all</a></div>
>+                            <div id="toolbar" class="selections-toolbar"><a id="selectallbutton" href="#"><i class="fa fa-check"></i> Select all</a> | <a id="clearallbutton" href="#"><i class="fa fa-remove"></i> Clear all</a></div>
>                         [% END %]
>                     [% END %]
>                         [% IF borrowers %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 32109: 143177 | 143178 | 143374 | 143837 | 143858 | 143890 | 143957