Bugzilla – Attachment 144062 Details for
Bug 32267
Koha/ERM/Agreements.t is failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32267: (bug 32154 follow-up) Fix Agreements.t
Bug-32267-bug-32154-follow-up-Fix-Agreementst.patch (text/plain), 1.30 KB, created by
Jonathan Druart
on 2022-11-18 13:18:05 UTC
(
hide
)
Description:
Bug 32267: (bug 32154 follow-up) Fix Agreements.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-11-18 13:18:05 UTC
Size:
1.30 KB
patch
obsolete
>From ccbc2e2215224d7fc36af6e8624f60cd0c4a1467 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 18 Nov 2022 14:02:06 +0100 >Subject: [PATCH] Bug 32267: (bug 32154 follow-up) Fix Agreements.t > > # Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111. > # Structures begin differing at: > # $got->[0]{user_role_id} = '2' > # $expected->[0]{user_role_id} = Does not exist > # Looks like you failed 1 test of 4. > >Another fix may be better, please suggest if you disagree >--- > t/db_dependent/Koha/ERM/Agreements.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/ERM/Agreements.t b/t/db_dependent/Koha/ERM/Agreements.t >index 5778523b197..6cbf8cac4d2 100755 >--- a/t/db_dependent/Koha/ERM/Agreements.t >+++ b/t/db_dependent/Koha/ERM/Agreements.t >@@ -104,7 +104,7 @@ subtest 'user_role' => sub { > my $retrieved_user_roles = $agreement->user_roles; > is( ref($retrieved_user_roles), 'Koha::ERM::UserRoles' ); > $retrieved_user_roles = >- [ map { delete $_->{agreement_id}; $_ } >+ [ map { delete $_->{agreement_id}; delete $_->{user_role_id}; $_ } > @{ $retrieved_user_roles->unblessed } ]; > is_deeply( $retrieved_user_roles, $user_roles ); > $agreement->user_roles( [] ); >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32267
:
144062
|
144064