Bug 32267 - Koha/ERM/Agreements.t is failing
Summary: Koha/ERM/Agreements.t is failing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 32154
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-18 13:16 UTC by Jonathan Druart
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:


Attachments
Bug 32267: (bug 32154 follow-up) Fix Agreements.t (1.30 KB, patch)
2022-11-18 13:18 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32267: (bug 32154 follow-up) Fix Agreements.t (1.36 KB, patch)
2022-11-18 13:54 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-18 13:16:36 UTC
#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 109.                                         #     Structures begin differing at:                                                                  
    #          $got->[0]{user_role_id} = '1'                                                              
    #     $expected->[0]{user_role_id} = Does not exist                                                   
    # Looks like you failed 1 test of 4.
Comment 1 Jonathan Druart 2022-11-18 13:18:05 UTC
Created attachment 144062 [details] [review]
Bug 32267: (bug 32154 follow-up) Fix Agreements.t

#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111.
    #     Structures begin differing at:
    #          $got->[0]{user_role_id} = '2'
    #     $expected->[0]{user_role_id} = Does not exist
    # Looks like you failed 1 test of 4.

Another fix may be better, please suggest if you disagree
Comment 2 Tomás Cohen Arazi (tcohen) 2022-11-18 13:54:16 UTC
Created attachment 144064 [details] [review]
Bug 32267: (bug 32154 follow-up) Fix Agreements.t

#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111.
    #     Structures begin differing at:
    #          $got->[0]{user_role_id} = '2'
    #     $expected->[0]{user_role_id} = Does not exist
    # Looks like you failed 1 test of 4.

Another fix may be better, please suggest if you disagree

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi (tcohen) 2022-11-18 15:08:14 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!