Bugzilla – Attachment 144063 Details for
Bug 32268
t/db_dependent/XSLT.t is failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32268: Prevent XSLT.t to fail randomly
Bug-32268-Prevent-XSLTt-to-fail-randomly.patch (text/plain), 1.82 KB, created by
Jonathan Druart
on 2022-11-18 13:43:31 UTC
(
hide
)
Description:
Bug 32268: Prevent XSLT.t to fail randomly
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-11-18 13:43:31 UTC
Size:
1.82 KB
patch
obsolete
>From ac2292b5dc6319d078f7b1ffbc051f05365e0500 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 18 Nov 2022 14:41:51 +0100 >Subject: [PATCH] Bug 32268: Prevent XSLT.t to fail randomly > >Can't call method "itemnumber" on an undefined value at /kohadevbox/koha/Koha/Recall.pm line 343. > >We should set item_level and not let TestBuilder pick a value. > >This may have been caught (make it more obvious) by the recent change to >TestBuilder for boolean (Bug 32030: fix test builder for boolean) >--- > t/db_dependent/XSLT.t | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/XSLT.t b/t/db_dependent/XSLT.t >index 314996d4887..c4013aed2fb 100755 >--- a/t/db_dependent/XSLT.t >+++ b/t/db_dependent/XSLT.t >@@ -133,11 +133,17 @@ subtest 'buildKohaItemsNamespace status tests' => sub { > like($xml,qr{<resultbranch>${library_name}</resultbranch>}, "Found resultbranch / holding branch" ); > > t::lib::Mocks::mock_preference('UseRecalls', 1); >- my $recall = $builder->build_object({ class => 'Koha::Recalls', value => { >- biblio_id => $item->biblionumber, >- item_id => $item->itemnumber, >- pickup_library_id => $item->holdingbranch, >- }}); >+ my $recall = $builder->build_object( >+ { >+ class => 'Koha::Recalls', >+ value => { >+ biblio_id => $item->biblionumber, >+ item_id => $item->itemnumber, >+ pickup_library_id => $item->holdingbranch, >+ item_level => 1, >+ } >+ } >+ ); > $recall->set_waiting; > $xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]); > like($xml,qr{<substatus>Recall waiting</substatus>},"Waiting status takes precedence over In transit (recalls)"); >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32268
:
144063
|
144066