Bug 32268 - t/db_dependent/XSLT.t is failing randomly
Summary: t/db_dependent/XSLT.t is failing randomly
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 19532
Blocks: 25551
  Show dependency treegraph
 
Reported: 2022-11-18 13:39 UTC by Jonathan Druart
Modified: 2023-06-08 22:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32268: Prevent XSLT.t to fail randomly (1.82 KB, patch)
2022-11-18 13:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32268: Prevent XSLT.t to fail randomly (1.88 KB, patch)
2022-11-18 14:25 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-18 13:39:07 UTC

    
Comment 1 Jonathan Druart 2022-11-18 13:43:31 UTC
Created attachment 144063 [details] [review]
Bug 32268: Prevent XSLT.t to fail randomly

Can't call method "itemnumber" on an undefined value at /kohadevbox/koha/Koha/Recall.pm line 343.

We should set item_level and not let TestBuilder pick a value.

This may have been caught (make it more obvious) by the recent change to
TestBuilder for boolean (Bug 32030: fix test builder for boolean)
Comment 2 Tomás Cohen Arazi 2022-11-18 14:25:49 UTC
Created attachment 144066 [details] [review]
Bug 32268: Prevent XSLT.t to fail randomly

Can't call method "itemnumber" on an undefined value at /kohadevbox/koha/Koha/Recall.pm line 343.

We should set item_level and not let TestBuilder pick a value.

This may have been caught (make it more obvious) by the recent change to
TestBuilder for boolean (Bug 32030: fix test builder for boolean)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi 2022-11-18 15:08:20 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!