Bugzilla – Attachment 144093 Details for
Bug 32261
Insufficient user feedback when selecting patron in autocomplete
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32261: Patron autocomplete - do not empty text field
Bug-32261-Patron-autocomplete---do-not-empty-text-.patch (text/plain), 1.60 KB, created by
Katrin Fischer
on 2022-11-19 20:18:12 UTC
(
hide
)
Description:
Bug 32261: Patron autocomplete - do not empty text field
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-11-19 20:18:12 UTC
Size:
1.60 KB
patch
obsolete
>From acac6b04d5cbd88d87773986ffafe8dad99c2f8c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 18 Nov 2022 09:52:35 +0100 >Subject: [PATCH] Bug 32261: Patron autocomplete - do not empty text field > >The jQuery UI autocomplete is supposed to replace the text field with >the 'value' attribute of the selected item. As it does not exist it's >emptied. We should not replace what the user typed in. > >Test plan: >Go to the Koha home page >Select "Search patrons" in the header >Type 'edn', it will return 1 result >Use the down key to select the item (it is not obvious but there is a >little change in the color when you select the item) >=> Without this patch the search field is emptied >=> With this patch applied the search field is not modified > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js b/koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js >index 6057cb8473..4189a2df1d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js >@@ -59,6 +59,9 @@ function patron_autocomplete(node, options) { > return on_select_callback(event, ui); > } > }, >+ focus: function( event, ui ) { >+ event.preventDefault(); // Don't replace the text field >+ }, > }) > .data( "ui-autocomplete" ) > ._renderItem = function( ul, item ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32261
:
144046
|
144047
|
144058
|
144059
| 144093 |
144094