Created attachment 144046 [details] [review] Bug 32261: Patron autocomplete - do not empty text field The jQuery UI autocomplete is supposed to replace the text field with the 'value' attribute of the selected item. As it does not exist it's emptied. We should not replace what the user typed in. Test plan: Go to the Koha home page Select "Search patrons" in the header Type 'edn', it will return 1 result Use the down key to select the item (it is not obvious but there is a little change in the color when you select the item) => Without this patch the search field is emptied => With this patch applied the search field is not modified
Created attachment 144047 [details] [review] Bug 32261: Add more UI feedback when selecting patron from autocomplete There is only a tiny change in the color of the selected item, but it's not obvious. Test plan: Regenerate the css files using `yarn build` Search for patrons and note that the down/up keys let you select a patron and the background color change. Note that the background color is not on the container and so is not similar as the hover rule (when using the mouse). We could change that, but then the behaviour is weird when you have both the mouse and the keyboard selecting items in the item list.
Created attachment 144058 [details] [review] Bug 32261: Patron autocomplete - do not empty text field The jQuery UI autocomplete is supposed to replace the text field with the 'value' attribute of the selected item. As it does not exist it's emptied. We should not replace what the user typed in. Test plan: Go to the Koha home page Select "Search patrons" in the header Type 'edn', it will return 1 result Use the down key to select the item (it is not obvious but there is a little change in the color when you select the item) => Without this patch the search field is emptied => With this patch applied the search field is not modified Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 144059 [details] [review] Bug 32261: Add more UI feedback when selecting patron from autocomplete There is only a tiny change in the color of the selected item, but it's not obvious. Test plan: Regenerate the css files using `yarn build` Search for patrons and note that the down/up keys let you select a patron and the background color change. Note that the background color is not on the container and so is not similar as the hover rule (when using the mouse). We could change that, but then the behaviour is weird when you have both the mouse and the keyboard selecting items in the item list. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 144093 [details] [review] Bug 32261: Patron autocomplete - do not empty text field The jQuery UI autocomplete is supposed to replace the text field with the 'value' attribute of the selected item. As it does not exist it's emptied. We should not replace what the user typed in. Test plan: Go to the Koha home page Select "Search patrons" in the header Type 'edn', it will return 1 result Use the down key to select the item (it is not obvious but there is a little change in the color when you select the item) => Without this patch the search field is emptied => With this patch applied the search field is not modified Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 144094 [details] [review] Bug 32261: Add more UI feedback when selecting patron from autocomplete There is only a tiny change in the color of the selected item, but it's not obvious. Test plan: Regenerate the css files using `yarn build` Search for patrons and note that the down/up keys let you select a patron and the background color change. Note that the background color is not on the container and so is not similar as the hover rule (when using the mouse). We could change that, but then the behaviour is weird when you have both the mouse and the keyboard selecting items in the item list. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.