Bugzilla – Attachment 144374 Details for
Bug 32349
Remove TEST_QA
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32349: Remove TEST_QA
Bug-32349-Remove-TESTQA.patch (text/plain), 2.48 KB, created by
Mason James
on 2022-12-01 10:22:44 UTC
(
hide
)
Description:
Bug 32349: Remove TEST_QA
Filename:
MIME Type:
Creator:
Mason James
Created:
2022-12-01 10:22:44 UTC
Size:
2.48 KB
patch
obsolete
>From 88fc2e716eb0ce9930bb7028e20108d1dba34cbc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 25 Nov 2022 09:07:34 +0100 >Subject: [PATCH] Bug 32349: Remove TEST_QA >Content-Type: text/plain; charset="utf-8" > >There is an env var that we are passing from koha-testing-docker, TEST_QA. >It's used in Koha from a single test file, t/00-testcritic.t. >If not set, no test is run. > >Do we really need this? libtest-perl-critic-perl is packaged and automatically installed. > >Signed-off-by: Mason James <mtj@kohaaloha.com> >--- > misc/migration_tools/bulkmarcimport.pl | 2 +- > t/00-testcritic.t | 7 ------- > xt/find-nonutf8 | 2 +- > 3 files changed, 2 insertions(+), 9 deletions(-) > >diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl >index d2dfe1ad56..e95b1fa199 100755 >--- a/misc/migration_tools/bulkmarcimport.pl >+++ b/misc/migration_tools/bulkmarcimport.pl >@@ -480,7 +480,7 @@ RECORD: while ( ) { > C4::Biblio::_strip_item_fields($clone_record, ''); > # This sets the marc fields if there was an error, and also calls > # defer_marc_save. >- ModBiblioMarc( $clone_record, $biblionumber ); >+ ModBiblioMarc( $clone_record, $biblionumber ) if $insert; > if ( $error_adding ) { > warn "ERROR: Adding items to bib $biblionumber failed: $error_adding"; > printlog({id=>$id||$originalid||$biblionumber, op=>"insertitem",status=>"ERROR"}) if ($logfile); >diff --git a/t/00-testcritic.t b/t/00-testcritic.t >index 4c7f44132a..cd3a7af71b 100755 >--- a/t/00-testcritic.t >+++ b/t/00-testcritic.t >@@ -1,18 +1,11 @@ > #!/usr/bin/env perl > > # This script can be used to run perlcritic on perl files in koha >-# The script is purely optional requiring Test::Perl::Critic to be installed >-# and the environment variable TEST_QA to be set > > use Modern::Perl; > use Test::More; > use English qw(-no_match_vars); > >-if ( not $ENV{TEST_QA} ) { >- my $msg = 'Author test. Set $ENV{TEST_QA} to a true value to run'; >- plan( skip_all => $msg ); >-} >- > eval { require Test::Perl::Critic; }; > > if ( $EVAL_ERROR ) { >diff --git a/xt/find-nonutf8 b/xt/find-nonutf8 >index 87ee78277b..d745c5d748 100755 >--- a/xt/find-nonutf8 >+++ b/xt/find-nonutf8 >@@ -1,4 +1,4 @@ >-#!/bin/sh >+#!/usr/bin/perl > # > # Find Koha source files that are not in UTF-8. Non-textual files are ignored. > # This script requires the isutf8 program from Joey Hess's moreutils package. >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32349
:
144226
|
144374
|
144566
|
145022
|
145023
|
145141
|
145142