There is an env var that we are passing from koha-testing-docker, TEST_QA. It's used in Koha from a single test file, t/00-testcritic.t. If not set, no test is run. Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.
Created attachment 144226 [details] [review] Bug 32349: Remove TEST_QA There is an env var that we are passing from koha-testing-docker, TEST_QA. It's used in Koha from a single test file, t/00-testcritic.t. If not set, no test is run. Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.
Mason, you are the only one this removal could affect. Do you agree with this?
Created attachment 144374 [details] [review] Bug 32349: Remove TEST_QA There is an env var that we are passing from koha-testing-docker, TEST_QA. It's used in Koha from a single test file, t/00-testcritic.t. If not set, no test is run. Do we really need this? libtest-perl-critic-perl is packaged and automatically installed. Signed-off-by: Mason James <mtj@kohaaloha.com>
(In reply to Jonathan Druart from comment #2) > Mason, you are the only one this removal could affect. Do you agree with > this? hiya, patch looks good to me :)
diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl index d2dfe1ad56..e95b1fa199 100755 --- a/misc/migration_tools/bulkmarcimport.pl +++ b/misc/migration_tools/bulkmarcimport.pl @@ -480,7 +480,7 @@ RECORD: while ( ) { C4::Biblio::_strip_item_fields($clone_record, ''); # This sets the marc fields if there was an error, and also calls # defer_marc_save. - ModBiblioMarc( $clone_record, $biblionumber ); + ModBiblioMarc( $clone_record, $biblionumber ) if $insert; Please explain what this change does here?
(In reply to Marcel de Rooy from comment #5) > diff --git a/misc/migration_tools/bulkmarcimport.pl > b/misc/migration_tools/bulkmarcimport.pl > index d2dfe1ad56..e95b1fa199 100755 > --- a/misc/migration_tools/bulkmarcimport.pl > +++ b/misc/migration_tools/bulkmarcimport.pl > @@ -480,7 +480,7 @@ RECORD: while ( ) { > C4::Biblio::_strip_item_fields($clone_record, ''); > # This sets the marc fields if there was an error, and also > calls > # defer_marc_save. > - ModBiblioMarc( $clone_record, $biblionumber ); > + ModBiblioMarc( $clone_record, $biblionumber ) if $insert; > > Please explain what this change does here? oops, i think the change to bulkmarcimport.pl might be an accident?
Created attachment 144566 [details] [review] Bug 32349: Remove TEST_QA There is an env var that we are passing from koha-testing-docker, TEST_QA. It's used in Koha from a single test file, t/00-testcritic.t. If not set, no test is run. Do we really need this? libtest-perl-critic-perl is packaged and automatically installed. Signed-off-by: Mason James <mtj@kohaaloha.com>
Sorry, it was related to another bug.
#!/usr/bin/perl And a bit later: set -e git ls-files | grep -Ev '\.(gif|jpg|png|pdf|ogg|psd|swf|odt|zip|ico|DS_Store|chr|dat)$' | grep -v /js/tinymce/ | while read filename do if ! isutf8 -q "$filename" then echo "$filename" fi done
Not good enough for me :)
Created attachment 145022 [details] [review] Bug 32349: Remove TEST_QA There is an env var that we are passing from koha-testing-docker, TEST_QA. It's used in Koha from a single test file, t/00-testcritic.t. If not set, no test is run. Do we really need this? libtest-perl-critic-perl is packaged and automatically installed. Signed-off-by: Mason James <mtj@kohaaloha.com>
Created attachment 145023 [details] [review] Bug 32349: Remove find-nonutf8 tests We don't run it and it does not seem very useful. Let's remove it.
(In reply to Marcel de Rooy from comment #10) > Not good enough for me :) Oops, indeed! I decided to remove it, what do you think?
Created attachment 145141 [details] [review] Bug 32349: Remove TEST_QA There is an env var that we are passing from koha-testing-docker, TEST_QA. It's used in Koha from a single test file, t/00-testcritic.t. If not set, no test is run. Do we really need this? libtest-perl-critic-perl is packaged and automatically installed. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 145142 [details] [review] Bug 32349: Remove find-nonutf8 tests We don't run it and it does not seem very useful. Let's remove it. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Moving furter to PQA
(In reply to Jonathan Druart from comment #13) > I decided to remove it, what do you think? Agreed.
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
*** Bug 32347 has been marked as a duplicate of this bug. ***
Backported to 22.05.xfor upcoming 22.05.09
applied to 21.11.x for 21.11.16
Not backported to 21.05.x