Attachment 144566 Details for Bug 32349 – Bug 32349: Remove TEST_QA

[patch] Bug 32349: Remove TEST_QA

Bug-32349-Remove-TESTQA.patch (text/plain), 1.58 KB, created by Jonathan Druart on 2022-12-14 07:57:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-12-14 07:57:37 UTC

Size: 1.58 KB

patch

obsolete

>From 2010e694f208c02951249e7ef95244ea44ba2081 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 25 Nov 2022 09:07:34 +0100
>Subject: [PATCH] Bug 32349: Remove TEST_QA
>
>There is an env var that we are passing from koha-testing-docker, TEST_QA.
>It's used in Koha from a single test file, t/00-testcritic.t.
>If not set, no test is run.
>
>Do we really need this? libtest-perl-critic-perl is packaged and automatically installed.
>
>Signed-off-by: Mason James <mtj@kohaaloha.com>
>---
> t/00-testcritic.t | 7 -------
> xt/find-nonutf8   | 2 +-
> 2 files changed, 1 insertion(+), 8 deletions(-)
>
>diff --git a/t/00-testcritic.t b/t/00-testcritic.t
>index 4c7f44132ab..cd3a7af71ba 100755
>--- a/t/00-testcritic.t
>+++ b/t/00-testcritic.t
>@@ -1,18 +1,11 @@
> #!/usr/bin/env perl
> 
> # This script can be used to run perlcritic on perl files in koha
>-# The script is purely optional requiring Test::Perl::Critic to be installed 
>-# and the environment variable TEST_QA to be set
> 
> use Modern::Perl;
> use Test::More;
> use English qw(-no_match_vars);
> 
>-if ( not $ENV{TEST_QA} ) {
>-    my $msg = 'Author test. Set $ENV{TEST_QA} to a true value to run';
>-    plan( skip_all => $msg );
>-}
>-
> eval { require Test::Perl::Critic; };
> 
> if ( $EVAL_ERROR ) {
>diff --git a/xt/find-nonutf8 b/xt/find-nonutf8
>index 87ee78277bd..d745c5d7489 100755
>--- a/xt/find-nonutf8
>+++ b/xt/find-nonutf8
>@@ -1,4 +1,4 @@
>-#!/bin/sh
>+#!/usr/bin/perl
> #
> # Find Koha source files that are not in UTF-8. Non-textual files are ignored.
> # This script requires the isutf8 program from Joey Hess's moreutils package.
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 32349: 144226 | 144374 | 144566 | 145022 | 145023 | 145141 | 145142