Bugzilla – Attachment 145129 Details for
Bug 32589
Improve headings on result tables for 'checkouts with no items' report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32589: Improve headings on result tables for 'Items with no checkouts'
Bug-32589-Improve-headings-on-result-tables-for-It.patch (text/plain), 4.99 KB, created by
Frédéric Demians
on 2023-01-07 10:37:54 UTC
(
hide
)
Description:
Bug 32589: Improve headings on result tables for 'Items with no checkouts'
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2023-01-07 10:37:54 UTC
Size:
4.99 KB
patch
obsolete
>From 97b132ed74495572c1b5a2e923017c0921baf4ca Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 7 Jan 2023 01:34:24 +0000 >Subject: [PATCH] Bug 32589: Improve headings on result tables for 'Items with > no checkouts' >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When no filter was selected on the search form, the heading on >the results table showed as NULL. When library or item type were >selected the codes instead of the descriptions showed. > >To test: >* Without patch: >* Run the 'items with no checkouts' report with different settings > for 'By:'. Verify the headings on the tables are not nice. >* Apply patch >* Rerun reports > * Headings should be "Ungrouped, item type or library descriptions > * Summary table also shows item type and library descriptions > >Signed-off-by: Frédéric Demians <f.demians@tamil.fr> > â OK. Would be nice to have decoding also in 'Filtered on' top section >--- > .../prog/en/modules/reports/catalogue_out.tt | 31 +++++++++++++++---- > 1 file changed, 25 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >index 35a62dd0dd..73060fdb0c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >@@ -1,4 +1,5 @@ > [% USE Branches %] >+[% USE ItemTypes %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Items with no checkouts › Reports › Koha</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -45,9 +46,16 @@ > [% ELSE %] > <p> > [% END %] >- [% IF ( loopfilte.sql ) %]<span class="sql">[% END %] >- [% loopfilte.crit | html %] = [% loopfilte.filter | html %] >- [% IF ( loopfilte.sql ) %]</span>[% END %] >+ [% IF ( loopfilte.sql ) %] >+ <span class="sql"> >+ [% loopfilte.crit | html %] = [% loopfilte.filter | html %] >+ </span> >+ [% ELSE %] >+ <span>[% loopfilte.crit | html %] = [% loopfilte.filter | html %]</span> >+ [% IF ( loopfilte.crit == "by" ) %] >+ [% group_by = loopfilte.filter %] >+ [% END %] >+ [% END %] > </p> > [% END %] > [% END %] >@@ -65,7 +73,13 @@ > [% FOREACH looptable IN mainloo.looptables %] > <tr> > <td> >- <a href="#table[% looptable.coltitle | uri %]">[% looptable.coltitle | html %]</a> >+ [% IF ( group_by=="itype" ) %] >+ <a href="#table[% looptable.coltitle | uri %]">[% ItemTypes.GetDescription( looptable.coltitle ) | html %]</a> >+ [% ELSIF ( group_by=="homebranch" ) %] >+ <a href="#table[% looptable.coltitle | uri %]">[% Branches.GetName( looptable.coltitle ) | html %]</a> >+ [% ELSE %] >+ <a href="#table[% looptable.coltitle | uri %]">[% looptable.coltitle | html %]</a> >+ [% END %] > </td> > <td> > [% IF ( looptable.looptable_count ) %] >@@ -89,8 +103,13 @@ > [% FOREACH looptable IN mainloo.looptables %] > <div class="page-section"> > <h3> >- <a id="table[% looptable.coltitle | html %]"></a> >- [% looptable.coltitle | html %] >+ [% IF ( group_by=="itype" ) %] >+ <a id="table[% looptable.coltitle | html %]" >[% ItemTypes.GetDescription( looptable.coltitle ) | html %]</a> >+ [% ELSIF ( group_by=="homebranch" ) %] >+ <a id="table[% looptable.coltitle | html %]" >[% Branches.GetName( looptable.coltitle ) | html %]</a> >+ [% ELSE %] >+ Ungrouped >+ [% END %] > </h3> > <table> > <tr> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32589
:
145123
|
145129
|
145860