When no group criteria is selected, the table heading above the results will read NULL on the 'checkouts with no items' report. This is not nice. If item type or library are selected, it will show the codes instead of the descriptions. This isn't nice either.
Created attachment 145123 [details] [review] Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions
Created attachment 145129 [details] [review] Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions Signed-off-by: Frédéric Demians <f.demians@tamil.fr> → OK. Would be nice to have decoding also in 'Filtered on' top section
Forget my comment about decoding top section: solved by bug 32588
(In reply to Frédéric Demians from comment #3) > Forget my comment about decoding top section: solved by bug 32588 Yes, I tried to break it up into smaller steps - thx for working through the tree :)
Created attachment 145860 [details] [review] Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions Signed-off-by: Frédéric Demians <f.demians@tamil.fr> → OK. Would be nice to have decoding also in 'Filtered on' top section Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Another nice little improvement, Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Missing dependencies for 22.05.x, no backport